linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will McVicker <willmcvicker@google.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"Cc: Android Kernel" <kernel-team@android.com>,
	linux-arm-kernel@lists.infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic
Date: Tue, 21 Sep 2021 10:45:42 -0700	[thread overview]
Message-ID: <CABYd82a4OwxHNUUmUtBmTpSvWLu-f4sepHMF49kPQtWLU3MkDA@mail.gmail.com> (raw)
In-Reply-To: <YUmVj80m/rEC2mT7@google.com>

On Tue, Sep 21, 2021 at 1:19 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote:
>
> > On 20/09/2021 21:03, Will McVicker wrote:
> > > Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to
> > > be enabled by default via "default y if ARCH_EXYNOS" versus being
> > > selected by the ARCH_EXYNOS config directly. This allows vendors to
> > > disable these configs if they wish and provides additional flexibility
> > > to modularize them in the presence of a generic kernel.
> >
> > This is not true. Vendors cannot disable these options as they are not
> > visible.
>
> Good point, well made.
>
> > Although I understand that Arnd prefers this way and I do not
> > object it, but your explanation is incorrect.

Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden
configs" part. I'll upload the series to include the fix that refactos
the Samsung SoC drivers menuconfig which will address that and allow
one to enable/disable those configs. I'm going to hold off though
until we hash out the rest of the discussion in the cover letter
email.

Thanks,
Will

>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-09-21 17:46 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 19:03 [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker
2021-09-20 19:03 ` [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic Will McVicker
2021-09-21  7:29   ` Krzysztof Kozlowski
2021-09-21  7:50     ` Geert Uytterhoeven
2021-09-21  8:35       ` Krzysztof Kozlowski
2021-09-21 17:58         ` Will McVicker
2021-09-21 18:04           ` Krzysztof Kozlowski
2021-09-23 12:57             ` Lee Jones
2021-09-23 13:27               ` Krzysztof Kozlowski
2021-09-23 14:18                 ` Lee Jones
2021-09-23 16:27                   ` Krzysztof Kozlowski
2021-09-23 16:30                     ` Krzysztof Kozlowski
2021-09-20 19:03 ` [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG " Will McVicker
2021-09-20 20:57   ` Will McVicker
2021-09-21  7:23   ` Krzysztof Kozlowski
2021-09-21  8:19     ` Lee Jones
2021-09-21 17:45       ` Will McVicker [this message]
2021-09-21 18:20         ` Krzysztof Kozlowski
2021-09-23 12:39           ` Lee Jones
2021-09-23 12:57             ` Krzysztof Kozlowski
2021-09-23 13:41               ` Lee Jones
2021-09-23 16:19                 ` Geert Uytterhoeven
2021-09-23 18:05                   ` Geert Uytterhoeven
2021-09-20 19:03 ` [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS " Will McVicker
2021-09-21  7:27   ` Krzysztof Kozlowski
2021-09-21  8:18     ` Lee Jones
2021-09-23 21:52   ` Linus Walleij
2021-09-21  7:08 ` [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Lee Jones
2021-09-21  7:19 ` Krzysztof Kozlowski
2021-09-21  7:22   ` Krzysztof Kozlowski
2021-09-21  8:11   ` Lee Jones
2021-09-21  8:25     ` Krzysztof Kozlowski
2021-09-21  8:41       ` Lee Jones
2021-09-25  2:17       ` Saravana Kannan
2021-09-27  8:08         ` Krzysztof Kozlowski
2021-09-27  8:16           ` Geert Uytterhoeven
2021-09-27 18:07           ` Saravana Kannan
2021-09-27 19:54             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABYd82a4OwxHNUUmUtBmTpSvWLu-f4sepHMF49kPQtWLU3MkDA@mail.gmail.com \
    --to=willmcvicker@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=will@kernel.org \
    --subject='Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).