From: Krzysztof Kozlowski <email@example.com> To: Will McVicker <firstname.lastname@example.org>, Lee Jones <email@example.com> Cc: Catalin Marinas <firstname.lastname@example.org>, Will Deacon <email@example.com>, "Cc: Android Kernel" <firstname.lastname@example.org>, email@example.com, Linux Kernel Mailing List <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic Date: Tue, 21 Sep 2021 20:20:48 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CABYd82a4OwxHNUUmUtBmTpSvWLu-f4sepHMF49kPQtWLU3MkDA@mail.gmail.com> On 21/09/2021 19:45, Will McVicker wrote: > On Tue, Sep 21, 2021 at 1:19 AM Lee Jones <email@example.com> wrote: >> >> On Tue, 21 Sep 2021, Krzysztof Kozlowski wrote: >> >>> On 20/09/2021 21:03, Will McVicker wrote: >>>> Switch the default logic to enable SOC_SAMSUNG and it's sub-configs to >>>> be enabled by default via "default y if ARCH_EXYNOS" versus being >>>> selected by the ARCH_EXYNOS config directly. This allows vendors to >>>> disable these configs if they wish and provides additional flexibility >>>> to modularize them in the presence of a generic kernel. >>> >>> This is not true. Vendors cannot disable these options as they are not >>> visible. >> >> Good point, well made. >> >>> Although I understand that Arnd prefers this way and I do not >>> object it, but your explanation is incorrect. > > Thanks Krzysztof for the reviews! I'm sorry I missed the whole "hidden > configs" part. I'll upload the series to include the fix that refactos > the Samsung SoC drivers menuconfig which will address that and allow > one to enable/disable those configs. I'm going to hold off though > until we hash out the rest of the discussion in the cover letter > email. No, please first read our discussions, including Lee's and Geert's comments. The drivers should not be converted to modules or made visible if such configuration does not work. If it works, please describe your testing setup. All these drivers are *necessary* for a multiplatform kernel supporting Exynos platforms, therefore disabling them does not make any sense (if you support Exynos platform). If your kernel does not support Exynos platform, just do not select ARCH_EXYNOS and problem disappears because none of these drivers will be visible and selected. Unless you describe here some out-of-tree kernel which wants ARCH_EXYNOS, because vendor did not upstream it's code, but you do not want existing Exynos upstream drivers. We do not support such configuration. Please push your lovely vendor to work with upstream. That's the only solution. It's the third time this abuse re-usage of ARCH_EXYNOS appears and the same as before - the vendor does not like to upstream stuff. There are few guys trying to upstream recent Samsung SoC support by themself (ping me for contacts if you would like to participate) but the one party which should be doing it - the lovely vendor - does not actually participate and instead sends ridiculous patches like this one here... or like this  . Nope, please work with upstreaming SoC support, instead of abusing ARCH_EXYNOS for out of tree code from the vendor.  https://firstname.lastname@example.org/  https://email@example.com/ Best regards, Krzysztof
next prev parent reply other threads:[~2021-09-21 18:21 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-20 19:03 [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker 2021-09-20 19:03 ` [PATCH v1 1/4] clk: samsung: change COMMON_CLK_SAMSUNG default config logic Will McVicker 2021-09-21 7:29 ` Krzysztof Kozlowski 2021-09-21 7:50 ` Geert Uytterhoeven 2021-09-21 8:35 ` Krzysztof Kozlowski 2021-09-21 17:58 ` Will McVicker 2021-09-21 18:04 ` Krzysztof Kozlowski 2021-09-23 12:57 ` Lee Jones 2021-09-23 13:27 ` Krzysztof Kozlowski 2021-09-23 14:18 ` Lee Jones 2021-09-23 16:27 ` Krzysztof Kozlowski 2021-09-23 16:30 ` Krzysztof Kozlowski 2021-09-20 19:03 ` [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG " Will McVicker 2021-09-20 20:57 ` Will McVicker 2021-09-21 7:23 ` Krzysztof Kozlowski 2021-09-21 8:19 ` Lee Jones 2021-09-21 17:45 ` Will McVicker 2021-09-21 18:20 ` Krzysztof Kozlowski [this message] 2021-09-23 12:39 ` Lee Jones 2021-09-23 12:57 ` Krzysztof Kozlowski 2021-09-23 13:41 ` Lee Jones 2021-09-23 16:19 ` Geert Uytterhoeven 2021-09-23 18:05 ` Geert Uytterhoeven 2021-09-20 19:03 ` [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS " Will McVicker 2021-09-21 7:27 ` Krzysztof Kozlowski 2021-09-21 8:18 ` Lee Jones 2021-09-23 21:52 ` Linus Walleij 2021-09-21 7:08 ` [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Lee Jones 2021-09-21 7:19 ` Krzysztof Kozlowski 2021-09-21 7:22 ` Krzysztof Kozlowski 2021-09-21 8:11 ` Lee Jones 2021-09-21 8:25 ` Krzysztof Kozlowski 2021-09-21 8:41 ` Lee Jones 2021-09-25 2:17 ` Saravana Kannan 2021-09-27 8:08 ` Krzysztof Kozlowski 2021-09-27 8:16 ` Geert Uytterhoeven 2021-09-27 18:07 ` Saravana Kannan 2021-09-27 19:54 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1 2/4] soc: samsung: change SOC_SAMSUNG default config logic' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).