* [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes
@ 2022-08-23 14:56 Rob Herring
2022-08-25 6:30 ` Krzysztof Kozlowski
2022-08-26 13:33 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-08-23 14:56 UTC (permalink / raw)
To: Rafał Miłecki, Broadcom internal kernel review list,
Linus Walleij, Krzysztof Kozlowski, Matthias Brugger,
Jonathan Neuschäfer, Geert Uytterhoeven, Tomasz Figa,
Sylwester Nawrocki, Alim Akhtar, Maxime Coquelin,
Alexandre Torgue, Nobuhiro Iwamatsu, Sowjanya D, Chris Packham,
Andy Teng, Jacopo Mondi
Cc: Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, openbmc, linux-renesas-soc,
linux-samsung-soc, linux-stm32
In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/pinctrl/brcm,bcm4908-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml | 1 +
.../devicetree/bindings/pinctrl/intel,pinctrl-thunderbay.yaml | 1 +
.../devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 2 ++
.../devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml | 1 +
.../devicetree/bindings/pinctrl/renesas,rza1-ports.yaml | 1 +
Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 3 +++
.../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
.../devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml | 1 +
10 files changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4908-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4908-pinctrl.yaml
index 175a992f15e1..8a9fb9b433ca 100644
--- a/Documentation/devicetree/bindings/pinctrl/brcm,bcm4908-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/brcm,bcm4908-pinctrl.yaml
@@ -23,6 +23,7 @@ patternProperties:
'-pins$':
type: object
$ref: pinmux-node.yaml#
+ additionalProperties: false
properties:
function:
diff --git a/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml b/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml
index 5e99d79499b4..846651ff77c9 100644
--- a/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-keembay.yaml
@@ -44,6 +44,7 @@ properties:
patternProperties:
'^gpio@[0-9a-f]*$':
type: object
+ additionalProperties: false
description:
Child nodes can be specified to contain pin configuration information,
diff --git a/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-thunderbay.yaml b/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-thunderbay.yaml
index 0ec476248f21..6f30b5337ca2 100644
--- a/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-thunderbay.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/intel,pinctrl-thunderbay.yaml
@@ -42,6 +42,7 @@ properties:
patternProperties:
'^gpio@[0-9a-f]*$':
type: object
+ additionalProperties: false
description:
Child nodes can be specified to contain pin configuration information,
diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
index a651b2744caf..491f67e7cc4f 100644
--- a/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
@@ -24,6 +24,7 @@ patternProperties:
'-pins$':
type: object
$ref: pinmux-node.yaml#
+ additionalProperties: false
properties:
marvell,function:
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
index e7601c0f5a69..840f649e36ce 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml
@@ -76,6 +76,8 @@ required:
patternProperties:
'-[0-9]*$':
type: object
+ additionalProperties: false
+
patternProperties:
'-pins*$':
type: object
diff --git a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
index 7a11beb8f222..7b7f840ffc4c 100644
--- a/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml
@@ -30,6 +30,7 @@ patternProperties:
"^gpio@[0-7]$":
type: object
+ additionalProperties: false
description:
Eight GPIO banks (gpio@0 to gpio@7), that each contain between 14 and 18
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
index 8ed4b98a1628..9083040c996a 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-ports.yaml
@@ -41,6 +41,7 @@ required:
patternProperties:
"^gpio-[0-9]*$":
type: object
+ additionalProperties: false
description:
Each port of the r7s72100 pin controller hardware is itself a GPIO
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
index 3a65c66ca71d..d006a940c7c6 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
@@ -97,6 +97,9 @@ patternProperties:
additionalProperties: false
"^(initial|sleep)-state$":
+ type: object
+ additionalProperties: false
+
patternProperties:
"^(pin-[a-z0-9-]+|[a-z0-9-]+-pin)$":
$ref: samsung,pinctrl-pins-cfg.yaml
diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
index d35dcc4f0242..53c952d93ea2 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml
@@ -115,9 +115,12 @@ patternProperties:
'-[0-9]*$':
type: object
+ additionalProperties: false
+
patternProperties:
'^pins':
type: object
+ additionalProperties: false
description: |
A pinctrl node should contain at least one subnode representing the
pinctrl group available on the machine. Each subnode will list the
diff --git a/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml
index 306524885a2b..98b4663f9766 100644
--- a/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml
@@ -36,6 +36,7 @@ patternProperties:
pins it needs, and how they should be configured, with regard to muxer
configuration, pullups, drive strength.
$ref: "pinmux-node.yaml"
+ additionalProperties: false
properties:
function:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes
2022-08-23 14:56 [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
@ 2022-08-25 6:30 ` Krzysztof Kozlowski
2022-08-26 13:33 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-25 6:30 UTC (permalink / raw)
To: Rob Herring, Rafał Miłecki,
Broadcom internal kernel review list, Linus Walleij,
Krzysztof Kozlowski, Matthias Brugger, Jonathan Neuschäfer,
Geert Uytterhoeven, Tomasz Figa, Sylwester Nawrocki, Alim Akhtar,
Maxime Coquelin, Alexandre Torgue, Nobuhiro Iwamatsu, Sowjanya D,
Chris Packham, Andy Teng, Jacopo Mondi
Cc: Krzysztof Kozlowski, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, openbmc, linux-renesas-soc,
linux-samsung-soc, linux-stm32
On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes
2022-08-23 14:56 [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25 6:30 ` Krzysztof Kozlowski
@ 2022-08-26 13:33 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-08-26 13:33 UTC (permalink / raw)
To: Rob Herring
Cc: Rafał Miłecki, Broadcom internal kernel review list,
Krzysztof Kozlowski, Matthias Brugger, Jonathan Neuschäfer,
Geert Uytterhoeven, Tomasz Figa, Sylwester Nawrocki, Alim Akhtar,
Maxime Coquelin, Alexandre Torgue, Nobuhiro Iwamatsu, Sowjanya D,
Chris Packham, Andy Teng, Jacopo Mondi, Krzysztof Kozlowski,
linux-gpio, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, openbmc, linux-renesas-soc, linux-samsung-soc,
linux-stm32
On Tue, Aug 23, 2022 at 4:57 PM Rob Herring <robh@kernel.org> wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Patch applied to the pinctrl tree for v6.1
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-26 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 14:56 [PATCH] dt-bindings: pinctrl: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25 6:30 ` Krzysztof Kozlowski
2022-08-26 13:33 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).