linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
@ 2021-09-14 20:21 Douglas Anderson
  2021-09-14 20:21 ` [PATCH v5 05/15] ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP Douglas Anderson
  2021-09-14 22:12 ` [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Linus Walleij
  0 siblings, 2 replies; 8+ messages in thread
From: Douglas Anderson @ 2021-09-14 20:21 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Sam Ravnborg
  Cc: devicetree, Steev Klimaszewski, dri-devel, linux-arm-msm,
	David Airlie, Maarten Lankhorst, Thomas Zimmermann, Linus W,
	Bjorn Andersson, Daniel Vetter, Maxime Ripard, Douglas Anderson,
	Adam Ford, Al Viro, Alexandre Belloni, Alexandre Torgue,
	Andreas Kemnade, Andrey Zhizhikin, Anson Huang, Arnd Bergmann,
	Catalin Marinas, Chen-Yu Tsai, Claudiu Beznea, Corentin Labbe,
	Daniel Thompson, Dmitry Baryshkov, Dmitry Osipenko, Emil Velikov,
	Enric Balletbo i Serra, Eugen Hristev, Fabio Estevam,
	Fabrice Gasnier, Florian Fainelli, Geert Uytterhoeven,
	Grygorii Strashko, Guido Günther, Jagan Teki,
	Jernej Skrabec, Joel Stanley, Jonathan Hunter, Kees Cook,
	Krzysztof Kozlowski, Krzysztof Kozlowski, Lionel Debieve,
	Liviu Dudau, Lorenzo Pieralisi, Ludovic Desroches, Magnus Damm,
	Manivannan Sadhasivam, Marek Szyprowski, Martin Jücker,
	Matthias Brugger, Michael Walle, NXP Linux Team, Nicolas Ferre,
	Nishanth Menon, Olivier Moysan, Otavio Salvador,
	Pengutronix Kernel Team, Razvan Stefanescu, Robert Richter,
	Russell King, Sascha Hauer, Shawn Guo, Stefan Wahren,
	Sudeep Holla, Tony Lindgren, Viresh Kumar, Vladimir Zapolskiy,
	Will Deacon, William Cohen, linux-arm-kernel, linux-kernel,
	linux-omap, linux-renesas-soc, linux-samsung-soc, linux-sunxi,
	linux-tegra, Łukasz Stelmach

The goal of this patch series is to move away from hardcoding exact
eDP panels in device tree files. As discussed in the various patches
in this series (I'm not repeating everything here), most eDP panels
are 99% probable and we can get that last 1% by allowing two "power
up" delays to be specified in the device tree file and then using the
panel ID (found in the EDID) to look up additional power sequencing
delays for the panel.

This patch series is the logical contiunation of a previous patch
series where I proposed solving this problem by adding a
board-specific compatible string [1]. In the discussion that followed
it sounded like people were open to something like the solution
proposed in this new series.

In version 2 I got rid of the idea that we could have a "fallback"
compatible string that we'd use if we didn't recognize the ID in the
EDID. This simplifies the bindings a lot and the implementation
somewhat. As a result of not having a "fallback", though, I'm not
confident in transitioning any existing boards over to this since
we'll have to fallback to very conservative timings if we don't
recognize the ID from the EDID and I can't guarantee that I've seen
every panel that might have shipped on an existing product. The plan
is to use "edp-panel" only on new boards or new revisions of old
boards where we can guarantee that every EDID that ships out of the
factory has an ID in the table.

Version 3 of this series now splits out all eDP panels to their own
driver and adds the generic eDP panel support to this new driver. I
believe this is what Sam was looking for [2].

Version 4 of this series is mostly small fixes / renames from review
feedback. It's largely the same as v3. Other than naming /
description / comment changes, the differences are:
- Dropped the MIPS config patch as per request.
- Reorder config patches first.
- Added a new patch to use the panel ID scheme for quirks.
- Landed the reorder of logicpd_type_28 / mitsubishi_aa070mc01

Version 5 of this series just fixes the panel ID encode macro to be
cleaner and adds Jani's review tags.

It could possibly be ready to land?

[1] https://lore.kernel.org/r/YFKQaXOmOwYyeqvM@google.com/
[2] https://lore.kernel.org/r/YRTsFNTn%2FT8fLxyB@ravnborg.org/

Changes in v5:
- Prettier encode panel ID function (thanks Andrzej!)
- Probable => Probeable

Changes in v4:
- "u8 *edid" => "void *edid" to avoid cast.
- ("Use new encoded panel id style for quirks matching") new for v4.
- Don't put kmalloc() in the "if" test even if the old code did.
- Don't refer to "panel-simple" in commit message.
- PANEL_SIMPLE_EDP => PANEL_EDP
- Remove "non-eDP" in panel-simple description.
- Reordered config patches to be before code patch
- decode_edid_id() => drm_edid_decode_panel_id()
- drm_do_get_edid_blk0() => drm_do_get_edid_base_block()
- drm_get_panel_id() => drm_edid_get_panel_id()
- encode_edid_id() => drm_edid_encode_panel_id()
- panel-simple-edp => panel-edp
- split panel id extraction out to its own function.

Changes in v3:
- ("Better describe eDP panel delays") new for v3.
- ("Don't re-read the EDID every time") moved to eDP only patch.
- ("Non-eDP panels don't need "HPD" handling") new for v3.
- Add AUO B116XAN06.1 to table.
- Add Sharp LQ116M1JW10 to table.
- Adjust endianness of product ID.
- Change init order to we power at the end.
- Decode hex product ID w/ same endianness as everyone else.
- Fallback to conservative delays if panel not recognized.
- Fix "prepare_to_enable" patch new for v3.
- Generic "edp-panel" handled by the eDP panel driver now.
- Move wayward panels patch new for v3.
- Rename delays more generically so they can be reused.
- Split eDP panels patch new for v3.
- Split the delay structure out patch just on eDP now.

Changes in v2:
- Add "-ms" suffix to delays.
- Don't support a "fallback" panel. Probed panels must be probed.
- No longer allow fallback to panel-simple.
- Not based on patch to copy "desc"--just allocate for probed panels.

Douglas Anderson (15):
  dt-bindings: drm/panel-simple-edp: Introduce generic eDP panels
  drm/edid: Break out reading block 0 of the EDID
  drm/edid: Allow querying/working with the panel ID from the EDID
  drm/edid: Use new encoded panel id style for quirks matching
  ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP
  arm64: defconfig: Everyone who had PANEL_SIMPLE now gets PANEL_EDP
  drm/panel-edp: Split eDP panels out of panel-simple
  drm/panel-edp: Move some wayward panels to the eDP driver
  drm/panel-simple: Non-eDP panels don't need "HPD" handling
  drm/panel-edp: Split the delay structure out
  drm/panel-edp: Better describe eDP panel delays
  drm/panel-edp: hpd_reliable shouldn't be subtraced from hpd_absent
  drm/panel-edp: Fix "prepare_to_enable" if panel doesn't handle HPD
  drm/panel-edp: Don't re-read the EDID every time we power off the
    panel
  drm/panel-edp: Implement generic "edp-panel"s probed by EDID

 .../bindings/display/panel/panel-edp.yaml     |  188 ++
 arch/arm/configs/at91_dt_defconfig            |    1 +
 arch/arm/configs/exynos_defconfig             |    1 +
 arch/arm/configs/imx_v6_v7_defconfig          |    1 +
 arch/arm/configs/lpc32xx_defconfig            |    1 +
 arch/arm/configs/multi_v5_defconfig           |    1 +
 arch/arm/configs/multi_v7_defconfig           |    1 +
 arch/arm/configs/omap2plus_defconfig          |    1 +
 arch/arm/configs/qcom_defconfig               |    1 +
 arch/arm/configs/realview_defconfig           |    1 +
 arch/arm/configs/sama5_defconfig              |    1 +
 arch/arm/configs/shmobile_defconfig           |    1 +
 arch/arm/configs/sunxi_defconfig              |    1 +
 arch/arm/configs/tegra_defconfig              |    1 +
 arch/arm/configs/versatile_defconfig          |    1 +
 arch/arm/configs/vexpress_defconfig           |    1 +
 arch/arm64/configs/defconfig                  |    1 +
 drivers/gpu/drm/drm_edid.c                    |  280 ++-
 drivers/gpu/drm/panel/Kconfig                 |   16 +-
 drivers/gpu/drm/panel/Makefile                |    1 +
 drivers/gpu/drm/panel/panel-edp.c             | 1895 +++++++++++++++++
 drivers/gpu/drm/panel/panel-simple.c          | 1072 +---------
 include/drm/drm_edid.h                        |   45 +
 23 files changed, 2351 insertions(+), 1162 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-edp.c

-- 
2.33.0.309.g3052b89438-goog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v5 05/15] ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP
  2021-09-14 20:21 [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Douglas Anderson
@ 2021-09-14 20:21 ` Douglas Anderson
  2021-09-14 22:12 ` [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Linus Walleij
  1 sibling, 0 replies; 8+ messages in thread
From: Douglas Anderson @ 2021-09-14 20:21 UTC (permalink / raw)
  To: Thierry Reding, Rob Herring, Sam Ravnborg
  Cc: devicetree, Steev Klimaszewski, dri-devel, linux-arm-msm,
	David Airlie, Maarten Lankhorst, Thomas Zimmermann, Linus W,
	Bjorn Andersson, Daniel Vetter, Maxime Ripard, Douglas Anderson,
	Al Viro, Alexandre Belloni, Alexandre Torgue, Andreas Kemnade,
	Andrey Zhizhikin, Anson Huang, Arnd Bergmann, Chen-Yu Tsai,
	Claudiu Beznea, Corentin Labbe, Daniel Thompson, Dmitry Osipenko,
	Emil Velikov, Eugen Hristev, Fabio Estevam, Fabrice Gasnier,
	Florian Fainelli, Geert Uytterhoeven, Grygorii Strashko,
	Jernej Skrabec, Joel Stanley, Jonathan Hunter, Kees Cook,
	Krzysztof Kozlowski, Lionel Debieve, Liviu Dudau,
	Lorenzo Pieralisi, Ludovic Desroches, Magnus Damm,
	Manivannan Sadhasivam, Marek Szyprowski, Martin Jücker,
	NXP Linux Team, Nicolas Ferre, Olivier Moysan, Otavio Salvador,
	Pengutronix Kernel Team, Razvan Stefanescu, Robert Richter,
	Russell King, Sascha Hauer, Shawn Guo, Stefan Wahren,
	Sudeep Holla, Tony Lindgren, Viresh Kumar, Vladimir Zapolskiy,
	William Cohen, linux-arm-kernel, linux-kernel, linux-omap,
	linux-renesas-soc, linux-samsung-soc, linux-sunxi, linux-tegra,
	Łukasz Stelmach

In the patch ("drm/panel-simple-edp: Split eDP panels out of
panel-simple") we will split the PANEL_SIMPLE driver in two. By
default let's give everyone who had the old driver enabled the new
driver too. If folks want to opt-out of one or the other they always
can later.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
---

(no changes since v4)

Changes in v4:
- PANEL_SIMPLE_EDP => PANEL_EDP
- Reordered config patches to be before code patch

 arch/arm/configs/at91_dt_defconfig   | 1 +
 arch/arm/configs/exynos_defconfig    | 1 +
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 arch/arm/configs/lpc32xx_defconfig   | 1 +
 arch/arm/configs/multi_v5_defconfig  | 1 +
 arch/arm/configs/multi_v7_defconfig  | 1 +
 arch/arm/configs/omap2plus_defconfig | 1 +
 arch/arm/configs/qcom_defconfig      | 1 +
 arch/arm/configs/realview_defconfig  | 1 +
 arch/arm/configs/sama5_defconfig     | 1 +
 arch/arm/configs/shmobile_defconfig  | 1 +
 arch/arm/configs/sunxi_defconfig     | 1 +
 arch/arm/configs/tegra_defconfig     | 1 +
 arch/arm/configs/versatile_defconfig | 1 +
 arch/arm/configs/vexpress_defconfig  | 1 +
 15 files changed, 15 insertions(+)

diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
index b1564e0aa000..a6310c8abcc3 100644
--- a/arch/arm/configs/at91_dt_defconfig
+++ b/arch/arm/configs/at91_dt_defconfig
@@ -144,6 +144,7 @@ CONFIG_VIDEO_MT9V032=m
 CONFIG_DRM=y
 CONFIG_DRM_ATMEL_HLCDC=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_FB_ATMEL=y
 CONFIG_BACKLIGHT_ATMEL_LCDC=y
 CONFIG_BACKLIGHT_PWM=y
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index f4e1873912a3..cae09010a799 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -227,6 +227,7 @@ CONFIG_DRM_EXYNOS_DPI=y
 CONFIG_DRM_EXYNOS_DSI=y
 CONFIG_DRM_EXYNOS_HDMI=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_PANEL_SAMSUNG_LD9040=y
 CONFIG_DRM_PANEL_SAMSUNG_S6E63J0X03=y
 CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=y
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 079fcd8d1d11..f46cdc4a0ca8 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -280,6 +280,7 @@ CONFIG_DRM=y
 CONFIG_DRM_MSM=y
 CONFIG_DRM_PANEL_LVDS=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_PANEL_SEIKO_43WVF1G=y
 CONFIG_DRM_TI_TFP410=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig
index 989bcc84e7fb..6c3e4a141963 100644
--- a/arch/arm/configs/lpc32xx_defconfig
+++ b/arch/arm/configs/lpc32xx_defconfig
@@ -108,6 +108,7 @@ CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_PL111=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
index 80a3ae02d759..fe8d760256a4 100644
--- a/arch/arm/configs/multi_v5_defconfig
+++ b/arch/arm/configs/multi_v5_defconfig
@@ -194,6 +194,7 @@ CONFIG_VIDEO_ATMEL_ISI=m
 CONFIG_DRM=y
 CONFIG_DRM_ATMEL_HLCDC=m
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_ASPEED_GFX=m
 CONFIG_FB_IMX=y
 CONFIG_FB_ATMEL=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index d9abaae118dd..610e3453d720 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -699,6 +699,7 @@ CONFIG_DRM_TEGRA=y
 CONFIG_DRM_STM=m
 CONFIG_DRM_STM_DSI=m
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_PANEL_SAMSUNG_LD9040=m
 CONFIG_DRM_PANEL_ORISETECH_OTM8009A=m
 CONFIG_DRM_PANEL_RAYDIUM_RM68200=m
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 2ac2418084ab..d933b787d934 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -511,6 +511,7 @@ CONFIG_OMAP2_DSS_DSI=y
 CONFIG_DRM_TILCDC=m
 CONFIG_DRM_PANEL_DSI_CM=m
 CONFIG_DRM_PANEL_SIMPLE=m
+CONFIG_DRM_PANEL_EDP=m
 CONFIG_DRM_PANEL_LG_LB035Q02=m
 CONFIG_DRM_PANEL_NEC_NL8048HL11=m
 CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 26353cbfa968..0daa9c0d298e 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -158,6 +158,7 @@ CONFIG_MEDIA_SUPPORT=y
 CONFIG_DRM=y
 CONFIG_DRM_MSM=m
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_ANALOGIX_ANX78XX=m
 CONFIG_FB=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
diff --git a/arch/arm/configs/realview_defconfig b/arch/arm/configs/realview_defconfig
index 4c01e313099f..3ef3521c19db 100644
--- a/arch/arm/configs/realview_defconfig
+++ b/arch/arm/configs/realview_defconfig
@@ -61,6 +61,7 @@ CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_DISPLAY_CONNECTOR=y
 CONFIG_DRM_SIMPLE_BRIDGE=y
 CONFIG_DRM_PL111=y
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index 17db3b3e2dd3..fe0d7ccc8fb2 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
@@ -160,6 +160,7 @@ CONFIG_VIDEO_MT9V032=m
 CONFIG_DRM=y
 CONFIG_DRM_ATMEL_HLCDC=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
 CONFIG_BACKLIGHT_PWM=y
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index d9a27e4e0914..b772105039f6 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -129,6 +129,7 @@ CONFIG_VIDEO_ML86V7667=y
 CONFIG_DRM=y
 CONFIG_DRM_RCAR_DU=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_DISPLAY_CONNECTOR=y
 CONFIG_DRM_LVDS_CODEC=y
 CONFIG_DRM_SII902X=y
diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
index a60c134c5e04..8ba7935bd039 100644
--- a/arch/arm/configs/sunxi_defconfig
+++ b/arch/arm/configs/sunxi_defconfig
@@ -108,6 +108,7 @@ CONFIG_DRM_SUN4I_HDMI_CEC=y
 CONFIG_DRM_SUN8I_DW_HDMI=y
 CONFIG_DRM_PANEL_LVDS=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_SIMPLE_BRIDGE=y
 CONFIG_DRM_LIMA=y
 CONFIG_FB_SIMPLE=y
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 3d8d8af9524d..055e35b48706 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -204,6 +204,7 @@ CONFIG_DRM_TEGRA=y
 CONFIG_DRM_TEGRA_STAGING=y
 CONFIG_DRM_PANEL_LVDS=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_LVDS_CODEC=y
 # CONFIG_LCD_CLASS_DEVICE is not set
 CONFIG_BACKLIGHT_CLASS_DEVICE=y
diff --git a/arch/arm/configs/versatile_defconfig b/arch/arm/configs/versatile_defconfig
index b703f4757021..d06aa64e05a1 100644
--- a/arch/arm/configs/versatile_defconfig
+++ b/arch/arm/configs/versatile_defconfig
@@ -57,6 +57,7 @@ CONFIG_GPIO_PL061=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_ARM_VERSATILE=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_DISPLAY_CONNECTOR=y
 CONFIG_DRM_SIMPLE_BRIDGE=y
 CONFIG_DRM_PL111=y
diff --git a/arch/arm/configs/vexpress_defconfig b/arch/arm/configs/vexpress_defconfig
index b5e246dd23f4..947987730eb7 100644
--- a/arch/arm/configs/vexpress_defconfig
+++ b/arch/arm/configs/vexpress_defconfig
@@ -77,6 +77,7 @@ CONFIG_SENSORS_VEXPRESS=y
 CONFIG_REGULATOR_VEXPRESS=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_EDP=y
 CONFIG_DRM_SII902X=y
 CONFIG_DRM_PL111=y
 CONFIG_FB=y
-- 
2.33.0.309.g3052b89438-goog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-14 20:21 [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Douglas Anderson
  2021-09-14 20:21 ` [PATCH v5 05/15] ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP Douglas Anderson
@ 2021-09-14 22:12 ` Linus Walleij
  2021-09-20 16:42   ` Doug Anderson
  1 sibling, 1 reply; 8+ messages in thread
From: Linus Walleij @ 2021-09-14 22:12 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: Thierry Reding, Rob Herring, Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Steev Klimaszewski, open list:DRM PANEL DRIVERS, MSM,
	David Airlie, Maarten Lankhorst, Thomas Zimmermann,
	Bjorn Andersson, Daniel Vetter, Maxime Ripard, Adam Ford,
	Al Viro, Alexandre Belloni, Alexandre Torgue, Andreas Kemnade,
	Andrey Zhizhikin, Anson Huang, Arnd Bergmann, Catalin Marinas,
	Chen-Yu Tsai, Claudiu Beznea, Corentin Labbe, Daniel Thompson,
	Dmitry Baryshkov, Dmitry Osipenko, Emil Velikov,
	Enric Balletbo i Serra, Eugen Hristev, Fabio Estevam,
	Fabrice Gasnier, Florian Fainelli, Geert Uytterhoeven,
	Grygorii Strashko, Guido Günther, Jagan Teki,
	Jernej Skrabec, Joel Stanley, Jonathan Hunter, Kees Cook,
	Krzysztof Kozlowski, Krzysztof Kozlowski, Lionel Debieve,
	Liviu Dudau, Lorenzo Pieralisi, Ludovic Desroches, Magnus Damm,
	Manivannan Sadhasivam, Marek Szyprowski, Martin Jücker,
	Matthias Brugger, Michael Walle, NXP Linux Team, Nicolas Ferre,
	Nishanth Menon, Olivier Moysan, Otavio Salvador,
	Pengutronix Kernel Team, Razvan Stefanescu, Robert Richter,
	Russell King, Sascha Hauer, Shawn Guo, Stefan Wahren,
	Sudeep Holla, Tony Lindgren, Viresh Kumar, Vladimir Zapolskiy,
	Will Deacon, William Cohen, Linux ARM, linux-kernel, Linux-OMAP,
	Linux-Renesas, linux-samsung-soc, linux-sunxi, linux-tegra,
	Łukasz Stelmach

On Tue, Sep 14, 2021 at 10:22 PM Douglas Anderson <dianders@chromium.org> wrote:

> Version 5 of this series just fixes the panel ID encode macro to be
> cleaner and adds Jani's review tags.
>
> It could possibly be ready to land?

Definitely IMO, the kernel look so much better after this change,
so for the series:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-14 22:12 ` [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Linus Walleij
@ 2021-09-20 16:42   ` Doug Anderson
  2021-09-24  8:03     ` Jani Nikula
  0 siblings, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2021-09-20 16:42 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Thierry Reding, Rob Herring, Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Steev Klimaszewski, open list:DRM PANEL DRIVERS, MSM,
	David Airlie, Maarten Lankhorst, Thomas Zimmermann,
	Bjorn Andersson, Daniel Vetter, Maxime Ripard, Adam Ford,
	Al Viro, Alexandre Belloni, Alexandre Torgue, Andreas Kemnade,
	Andrey Zhizhikin, Anson Huang, Arnd Bergmann, Catalin Marinas,
	Chen-Yu Tsai, Claudiu Beznea, Corentin Labbe, Daniel Thompson,
	Dmitry Baryshkov, Dmitry Osipenko, Emil Velikov,
	Enric Balletbo i Serra, Eugen Hristev, Fabio Estevam,
	Fabrice Gasnier, Florian Fainelli, Geert Uytterhoeven,
	Grygorii Strashko, Guido Günther, Jagan Teki,
	Jernej Skrabec, Joel Stanley, Jonathan Hunter, Kees Cook,
	Krzysztof Kozlowski, Krzysztof Kozlowski, Lionel Debieve,
	Liviu Dudau, Lorenzo Pieralisi, Ludovic Desroches, Magnus Damm,
	Manivannan Sadhasivam, Marek Szyprowski, Martin Jücker,
	Matthias Brugger, Michael Walle, NXP Linux Team, Nicolas Ferre,
	Nishanth Menon, Olivier Moysan, Otavio Salvador,
	Pengutronix Kernel Team, Razvan Stefanescu, Robert Richter,
	Russell King, Sascha Hauer, Shawn Guo, Stefan Wahren,
	Sudeep Holla, Tony Lindgren, Viresh Kumar, Vladimir Zapolskiy,
	Will Deacon, William Cohen, Linux ARM, linux-kernel, Linux-OMAP,
	Linux-Renesas, linux-samsung-soc, linux-sunxi, linux-tegra,
	Łukasz Stelmach

Hi,

On Tue, Sep 14, 2021 at 3:12 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Sep 14, 2021 at 10:22 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> > Version 5 of this series just fixes the panel ID encode macro to be
> > cleaner and adds Jani's review tags.
> >
> > It could possibly be ready to land?
>
> Definitely IMO, the kernel look so much better after this change,
> so for the series:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>

Pushed all 15 to drm-misc-next.

5540cf8f3e8d drm/panel-edp: Implement generic "edp-panel"s probed by EDID
24e27de11560 drm/panel-edp: Don't re-read the EDID every time we power
off the panel
a64ad9c3e4a5 drm/panel-edp: Fix "prepare_to_enable" if panel doesn't handle HPD
c46a4cc1403e drm/panel-edp: hpd_reliable shouldn't be subtraced from hpd_absent
52824ca4502d drm/panel-edp: Better describe eDP panel delays
9ea10a500045 drm/panel-edp: Split the delay structure out
b6d5ffce11dd drm/panel-simple: Non-eDP panels don't need "HPD" handling
3fd68b7b13c2 drm/panel-edp: Move some wayward panels to the eDP driver
5f04e7ce392d drm/panel-edp: Split eDP panels out of panel-simple
c0c11c70a6d0 arm64: defconfig: Everyone who had PANEL_SIMPLE now gets PANEL_EDP
310720875efa ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP
e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from the EDID
bac9c2948224 drm/edid: Break out reading block 0 of the EDID
29145a566873 dt-bindings: drm/panel-simple-edp: Introduce generic eDP panels

-Doug

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-20 16:42   ` Doug Anderson
@ 2021-09-24  8:03     ` Jani Nikula
  2021-09-24  9:10       ` Andrzej Hajda
  0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2021-09-24  8:03 UTC (permalink / raw)
  To: Doug Anderson, Linus Walleij
  Cc: Thierry Reding, Rob Herring, Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Steev Klimaszewski, open list:DRM PANEL DRIVERS, MSM,
	David Airlie, Maarten Lankhorst, Thomas Zimmermann,
	Bjorn Andersson, Daniel Vetter, Maxime Ripard, Adam Ford,
	Al Viro, Alexandre Belloni, Alexandre Torgue, Andreas Kemnade,
	Andrey Zhizhikin, Anson Huang, Arnd Bergmann, Catalin Marinas,
	Chen-Yu Tsai, Claudiu Beznea, Corentin Labbe, Daniel Thompson,
	Dmitry Baryshkov, Dmitry Osipenko, Emil Velikov,
	Enric Balletbo i Serra, Eugen Hristev, Fabio Estevam,
	Fabrice Gasnier, Florian Fainelli, Geert Uytterhoeven,
	Grygorii Strashko, Guido Günther, Jagan Teki,
	Jernej Skrabec, Joel Stanley, Jonathan Hunter, Kees Cook,
	Krzysztof Kozlowski, Krzysztof Kozlowski, Lionel Debieve,
	Liviu Dudau, Lorenzo Pieralisi, Ludovic Desroches, Magnus Damm,
	Manivannan Sadhasivam, Marek Szyprowski, Martin Jücker,
	Matthias Brugger, Michael Walle, NXP Linux Team, Nicolas Ferre,
	Nishanth Menon, Olivier Moysan, Otavio Salvador,
	Pengutronix Kernel Team, Razvan Stefanescu, Robert Richter,
	Russell King, Sascha Hauer, Shawn Guo, Stefan Wahren,
	Sudeep Holla, Tony Lindgren, Viresh Kumar, Vladimir Zapolskiy,
	Will Deacon, William Cohen, Linux ARM, linux-kernel, Linux-OMAP,
	Linux-Renesas, linux-samsung-soc, linux-sunxi, linux-tegra,
	Łukasz Stelmach, Stanislav Lisovskiy

On Mon, 20 Sep 2021, Doug Anderson <dianders@chromium.org> wrote:
> Pushed all 15 to drm-misc-next.
...
> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from the EDID

Hi Doug, Stan's reporting "initializer element is not constant" issues
here that were discussed before [1]. I wonder what gives, you said you'd
hit them on a draft version, but not with what was merged, and I can't
reproduce this either. Curious.

BR,
Jani.


In file included from drivers/gpu/drm/drm_edid.c:42:0:
./include/drm/drm_edid.h:525:2: error: initializer element is not constant
  ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
  ^
drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro ‘drm_edid_encode_panel_id’
  .panel_id = drm_edid_encode_panel_id(vend, product_id), \
	      ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
  EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
  ^~~~~~~~~~
./include/drm/drm_edid.h:525:2: note: (near initialization for ‘edid_quirk_list[0].panel_id’)
  ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
  ^
drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro ‘drm_edid_encode_panel_id’
  .panel_id = drm_edid_encode_panel_id(vend, product_id), \
	      ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
  EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
  ^~~~~~~~~~


[1] https://lore.kernel.org/all/CAD=FV=XHvFq5+Rtax7WNq2-BieQr-BM4UnmOcma_eTzkX2ZtNA@mail.gmail.com/


-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-24  8:03     ` Jani Nikula
@ 2021-09-24  9:10       ` Andrzej Hajda
  2021-09-24 13:59         ` Doug Anderson
  0 siblings, 1 reply; 8+ messages in thread
From: Andrzej Hajda @ 2021-09-24  9:10 UTC (permalink / raw)
  To: Jani Nikula, Doug Anderson, Linus Walleij
  Cc: Thierry Reding, Rob Herring, Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:DRM PANEL DRIVERS, MSM, David Airlie,
	Maarten Lankhorst, Thomas Zimmermann, Daniel Vetter,
	Maxime Ripard, Al Viro, Alexandre Belloni, Arnd Bergmann,
	Catalin Marinas, Emil Velikov, Enric Balletbo i Serra,
	Geert Uytterhoeven, Jagan Teki, Jernej Skrabec, Kees Cook,
	Krzysztof Kozlowski, Marek Szyprowski, Russell King, Will Deacon,
	Linux ARM, linux-kernel, Linux-OMAP, Linux-Renesas,
	linux-samsung-soc, linux-sunxi, linux-tegra, Stanislav Lisovskiy

Hi

removed most cc, due to server limitation


W dniu 24.09.2021 o 10:03, Jani Nikula pisze:
> On Mon, 20 Sep 2021, Doug Anderson <dianders@chromium.org> wrote:
>> Pushed all 15 to drm-misc-next.
> ...
>> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
>> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from 
>> the EDID
> Hi Doug, Stan's reporting "initializer element is not constant" issues
> here that were discussed before [1]. I wonder what gives, you said you'd
> hit them on a draft version, but not with what was merged, and I can't
> reproduce this either. Curious.


Apparently this is grey area of unclear specification.

gcc version below 8 reports error, above 8.1+ should work [1]. I am not 
sure if there is nice workaround for older gcc.


[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69960#c18


Regards

Andrzej


> BR,
> Jani.
>
>
> In file included from drivers/gpu/drm/drm_edid.c:42:0:
> ./include/drm/drm_edid.h:525:2: error: initializer element is not constant
> ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
> ^
> drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro 
> ‘drm_edid_encode_panel_id’
> .panel_id = drm_edid_encode_panel_id(vend, product_id), \
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
> EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
> ^~~~~~~~~~
> ./include/drm/drm_edid.h:525:2: note: (near initialization for 
> ‘edid_quirk_list[0].panel_id’)
> ((((u32)((vend)[0]) - '@') & 0x1f) << 26 | \
> ^
> drivers/gpu/drm/drm_edid.c:111:14: note: in expansion of macro 
> ‘drm_edid_encode_panel_id’
> .panel_id = drm_edid_encode_panel_id(vend, product_id), \
> ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/drm_edid.c:120:2: note: in expansion of macro ‘EDID_QUIRK’
> EDID_QUIRK("ACR", 44358, EDID_QUIRK_PREFER_LARGE_60),
> ^~~~~~~~~~
>
>
> [1] 
> https://lore.kernel.org/all/CAD=FV=XHvFq5+Rtax7WNq2-BieQr-BM4UnmOcma_eTzkX2ZtNA@mail.gmail.com/
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-24  9:10       ` Andrzej Hajda
@ 2021-09-24 13:59         ` Doug Anderson
  2021-09-24 14:55           ` Doug Anderson
  0 siblings, 1 reply; 8+ messages in thread
From: Doug Anderson @ 2021-09-24 13:59 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Jani Nikula, Linus Walleij, Thierry Reding, Rob Herring,
	Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:DRM PANEL DRIVERS, MSM, David Airlie,
	Maarten Lankhorst, Thomas Zimmermann, Daniel Vetter,
	Maxime Ripard, Al Viro, Alexandre Belloni, Arnd Bergmann,
	Catalin Marinas, Emil Velikov, Enric Balletbo i Serra,
	Geert Uytterhoeven, Jagan Teki, Jernej Skrabec, Kees Cook,
	Krzysztof Kozlowski, Marek Szyprowski, Russell King, Will Deacon,
	Linux ARM, linux-kernel, Linux-OMAP, Linux-Renesas,
	linux-samsung-soc, linux-sunxi, linux-tegra, Stanislav Lisovskiy,
	smyakam

Hi,

On Fri, Sep 24, 2021 at 2:10 AM Andrzej Hajda <a.hajda@samsung.com> wrote:
>
> Hi
>
> removed most cc, due to server limitation
>
>
> W dniu 24.09.2021 o 10:03, Jani Nikula pisze:
> > On Mon, 20 Sep 2021, Doug Anderson <dianders@chromium.org> wrote:
> >> Pushed all 15 to drm-misc-next.
> > ...
> >> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
> >> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from
> >> the EDID
> > Hi Doug, Stan's reporting "initializer element is not constant" issues
> > here that were discussed before [1]. I wonder what gives, you said you'd
> > hit them on a draft version, but not with what was merged, and I can't
> > reproduce this either. Curious.
>
>
> Apparently this is grey area of unclear specification.
>
> gcc version below 8 reports error, above 8.1+ should work [1]. I am not
> sure if there is nice workaround for older gcc.
>
>
> [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69960#c18

So I think the only solution is to go back to the character-at-a-time
version. It's slightly uglier but functionality trumps form.

I'll post something today though it might need to wait a few hours
before I can manage it.

-Doug

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding
  2021-09-24 13:59         ` Doug Anderson
@ 2021-09-24 14:55           ` Doug Anderson
  0 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2021-09-24 14:55 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Jani Nikula, Linus Walleij, Thierry Reding, Rob Herring,
	Sam Ravnborg,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:DRM PANEL DRIVERS, MSM, David Airlie,
	Maarten Lankhorst, Thomas Zimmermann, Daniel Vetter,
	Maxime Ripard, Al Viro, Alexandre Belloni, Arnd Bergmann,
	Catalin Marinas, Emil Velikov, Enric Balletbo i Serra,
	Geert Uytterhoeven, Jagan Teki, Jernej Skrabec, Kees Cook,
	Krzysztof Kozlowski, Marek Szyprowski, Russell King, Will Deacon,
	Linux ARM, linux-kernel, Linux-OMAP, Linux-Renesas,
	linux-samsung-soc, linux-sunxi, linux-tegra, Stanislav Lisovskiy,
	Srikanth Myakam

Hi,

On Fri, Sep 24, 2021 at 6:59 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Sep 24, 2021 at 2:10 AM Andrzej Hajda <a.hajda@samsung.com> wrote:
> >
> > Hi
> >
> > removed most cc, due to server limitation
> >
> >
> > W dniu 24.09.2021 o 10:03, Jani Nikula pisze:
> > > On Mon, 20 Sep 2021, Doug Anderson <dianders@chromium.org> wrote:
> > >> Pushed all 15 to drm-misc-next.
> > > ...
> > >> e8de4d55c259 drm/edid: Use new encoded panel id style for quirks matching
> > >> d9f91a10c3e8 drm/edid: Allow querying/working with the panel ID from
> > >> the EDID
> > > Hi Doug, Stan's reporting "initializer element is not constant" issues
> > > here that were discussed before [1]. I wonder what gives, you said you'd
> > > hit them on a draft version, but not with what was merged, and I can't
> > > reproduce this either. Curious.
> >
> >
> > Apparently this is grey area of unclear specification.
> >
> > gcc version below 8 reports error, above 8.1+ should work [1]. I am not
> > sure if there is nice workaround for older gcc.
> >
> >
> > [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69960#c18
>
> So I think the only solution is to go back to the character-at-a-time
> version. It's slightly uglier but functionality trumps form.
>
> I'll post something today though it might need to wait a few hours
> before I can manage it.

I managed to squeeze it in before my other obligations:

https://lore.kernel.org/all/20210924075317.1.I1e58d74d501613f1fe7585958f451160d11b8a98@changeid

I didn't CC everyone here but dri-devel and LKML are copied so
hopefully if I missed someone it should still be accessible.

-Doug

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-09-24 14:56 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 20:21 [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Douglas Anderson
2021-09-14 20:21 ` [PATCH v5 05/15] ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_EDP Douglas Anderson
2021-09-14 22:12 ` [PATCH v5 00/15] eDP: Support probing eDP panels dynamically instead of hardcoding Linus Walleij
2021-09-20 16:42   ` Doug Anderson
2021-09-24  8:03     ` Jani Nikula
2021-09-24  9:10       ` Andrzej Hajda
2021-09-24 13:59         ` Doug Anderson
2021-09-24 14:55           ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).