* Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory
[not found] ` <CAJKOXPeYpifDySTdvgk2ra4rjNtBdqGBQV8dsMeWkXCJQPP2zg@mail.gmail.com>
@ 2017-03-10 7:00 ` Jaehoon Chung
2017-03-10 9:49 ` Kishon Vijay Abraham I
2017-03-10 17:55 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2017-03-10 7:00 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kishon Vijay Abraham I
Cc: linux-kernel, kgene, kamil, Sylwester Nawrocki,
Javier Martinez Canillas, linux-samsung-soc
Hi All,
On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote:
> On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> Hi,
>>
>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>> Make the "samsung" directory and move the Samsung specific files to
>>> there for maintaining the files relevant to Samsung.
>>
>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>> is a good step to make it a little better. Can you also add a MAINTAINER for
>> drivers/phy/samsung?
>
> There is such:
>
> 10903 SAMSUNG USB2 PHY DRIVER
> 10904 M: Kamil Debski <kamil@wypas.org>
> 10905 M: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 10906 L: linux-kernel@vger.kernel.org
> 10907 S: Supported
> 10908 F: Documentation/devicetree/bindings/phy/samsung-phy.txt
> 10909 F: Documentation/phy/samsung-usb2.txt
> 10910 F: drivers/phy/phy-exynos4210-usb2.c
> 10911 F: drivers/phy/phy-exynos4x12-usb2.c
> 10912 F: drivers/phy/phy-exynos5250-usb2.c
> 10913 F: drivers/phy/phy-s5pv210-usb2.c
> 10914 F: drivers/phy/phy-samsung-usb2.c
> 10915 F: drivers/phy/phy-samsung-usb2.h
>
> but this patchset does not update it. Paths *everywhere* have to be updated.
Will update..How about the below updating?
M: Kamil Debski <kamil@wypas.org>
M: Sylwester Nawrocki <s.nawrocki@samsung.com>
M: Jaehoon Chung <jh80.chung@samsung.com>
L: linux-kernel@vger.kernel.org
S: Supported
F: Documentation/devicetree/bindings/phy/samsung-phy.txt
F: Documentation/phy/samsung-usb2.txt
F: driver/phy/samsung/
Let me know your opinion.
Best Regards,
Jaehoon Chung
>
> Best regards,
> Krzysztof
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory
2017-03-10 7:00 ` [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory Jaehoon Chung
@ 2017-03-10 9:49 ` Kishon Vijay Abraham I
2017-03-10 17:55 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2017-03-10 9:49 UTC (permalink / raw)
To: Jaehoon Chung, Krzysztof Kozlowski
Cc: linux-kernel, kgene, kamil, Sylwester Nawrocki,
Javier Martinez Canillas, linux-samsung-soc
Hi,
On Friday 10 March 2017 12:30 PM, Jaehoon Chung wrote:
> Hi All,
>
> On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote:
>> On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Hi,
>>>
>>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>>> Make the "samsung" directory and move the Samsung specific files to
>>>> there for maintaining the files relevant to Samsung.
>>>
>>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>>> is a good step to make it a little better. Can you also add a MAINTAINER for
>>> drivers/phy/samsung?
>>
>> There is such:
>>
>> 10903 SAMSUNG USB2 PHY DRIVER
>> 10904 M: Kamil Debski <kamil@wypas.org>
>> 10905 M: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> 10906 L: linux-kernel@vger.kernel.org
>> 10907 S: Supported
>> 10908 F: Documentation/devicetree/bindings/phy/samsung-phy.txt
>> 10909 F: Documentation/phy/samsung-usb2.txt
>> 10910 F: drivers/phy/phy-exynos4210-usb2.c
>> 10911 F: drivers/phy/phy-exynos4x12-usb2.c
>> 10912 F: drivers/phy/phy-exynos5250-usb2.c
>> 10913 F: drivers/phy/phy-s5pv210-usb2.c
>> 10914 F: drivers/phy/phy-samsung-usb2.c
>> 10915 F: drivers/phy/phy-samsung-usb2.h
>>
>> but this patchset does not update it. Paths *everywhere* have to be updated.
>
> Will update..How about the below updating?
> M: Kamil Debski <kamil@wypas.org>
> M: Sylwester Nawrocki <s.nawrocki@samsung.com>
> M: Jaehoon Chung <jh80.chung@samsung.com>
> L: linux-kernel@vger.kernel.org
> S: Supported
> F: Documentation/devicetree/bindings/phy/samsung-phy.txt
> F: Documentation/phy/samsung-usb2.txt
> F: driver/phy/samsung/
>
> Let me know your opinion.
Looks good to me.
Thanks
Kishon
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Best regards,
>> Krzysztof
>>
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory
2017-03-10 7:00 ` [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory Jaehoon Chung
2017-03-10 9:49 ` Kishon Vijay Abraham I
@ 2017-03-10 17:55 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2017-03-10 17:55 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Kishon Vijay Abraham I, linux-kernel, kgene, kamil,
Sylwester Nawrocki, Javier Martinez Canillas, linux-samsung-soc
On Fri, Mar 10, 2017 at 9:00 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi All,
>
> On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote:
>> On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Hi,
>>>
>>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>>> Make the "samsung" directory and move the Samsung specific files to
>>>> there for maintaining the files relevant to Samsung.
>>>
>>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>>> is a good step to make it a little better. Can you also add a MAINTAINER for
>>> drivers/phy/samsung?
>>
>> There is such:
>>
>> 10903 SAMSUNG USB2 PHY DRIVER
>> 10904 M: Kamil Debski <kamil@wypas.org>
>> 10905 M: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> 10906 L: linux-kernel@vger.kernel.org
>> 10907 S: Supported
>> 10908 F: Documentation/devicetree/bindings/phy/samsung-phy.txt
>> 10909 F: Documentation/phy/samsung-usb2.txt
>> 10910 F: drivers/phy/phy-exynos4210-usb2.c
>> 10911 F: drivers/phy/phy-exynos4x12-usb2.c
>> 10912 F: drivers/phy/phy-exynos5250-usb2.c
>> 10913 F: drivers/phy/phy-s5pv210-usb2.c
>> 10914 F: drivers/phy/phy-samsung-usb2.c
>> 10915 F: drivers/phy/phy-samsung-usb2.h
>>
>> but this patchset does not update it. Paths *everywhere* have to be updated.
>
> Will update..How about the below updating?
> M: Kamil Debski <kamil@wypas.org>
> M: Sylwester Nawrocki <s.nawrocki@samsung.com>
> M: Jaehoon Chung <jh80.chung@samsung.com>
> L: linux-kernel@vger.kernel.org
> S: Supported
> F: Documentation/devicetree/bindings/phy/samsung-phy.txt
> F: Documentation/phy/samsung-usb2.txt
> F: driver/phy/samsung/
Hm? Except recent phy-exynos-pcie you did not contribute to other PHY
drivers. You did not reviewed them on the lists. I think that
maintenance starts with reviewing... which did not happen in this
case.
Did you discuss it with existing maintainers (I know that Sylwester is
too polite... but I do not care about politics and I can say straight
from the shoulder).
Maybe you wanted:
SAMSUNG PHY DRIVERS
M: Kamil Debski <kamil@wypas.org>
M: Sylwester Nawrocki <s.nawrocki@samsung.com>
L: linux-kernel@vger.kernel.org
S: Supported
F: Documentation/devicetree/bindings/phy/samsung-phy.txt
F: Documentation/phy/samsung-usb2.txt
F: driver/phy/samsung/
SAMSUNG PCIE PHY DRIVER
M: Jaehoon Chung <jh80.chung@samsung.com>
L: linux-kernel@vger.kernel.org
S: Supported
F: driver/phy/samsung/phy-exynos-pcie.c
That looks much more sensible to me.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory
[not found] ` <CAFp+6iGj=me4uOpOy338oxiAi=0sLW4WnkCzzAMELkxp=ZmrVA@mail.gmail.com>
@ 2017-03-12 23:18 ` Jaehoon Chung
2017-03-13 8:59 ` Vivek Gautam
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2017-03-12 23:18 UTC (permalink / raw)
To: Vivek Gautam, Kishon Vijay Abraham I
Cc: linux-kernel, Kukjin Kim, krzk, kamil, Sylwester Nawrocki,
javier, linux-samsung-soc
Hi Vivek,
On 03/12/2017 06:18 PM, Vivek Gautam wrote:
> Hi Kishon,
>
>
> On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> Hi,
>>
>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>> Make the "samsung" directory and move the Samsung specific files to
>>> there for maintaining the files relevant to Samsung.
>>
>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>> is a good step to make it a little better. Can you also add a MAINTAINER for
>> drivers/phy/samsung?
>
> I remember making a similar attempt in past [1], but that time we couldn't
> reach an agreement as to whether group the phy drivers based on
> vendors or based on the type of phy.
>
> If you are fine with grouping the drivers for each vendor, I hope you can
> consider picking that patch (I can respin the patch based on linux-phy/next).
> Other driver maintainers were also cool with that older patch.
>
> Let me know your comments.
>
> [1] https://patchwork.kernel.org/patch/8762561/
I didn't know you had already sent the patches.
My RFC patch can be dropped. I think it's good way.
Best Regards,
Jaehoon Chung
>
> Regards
> Vivek
>
>>
>> Thanks
>> Kishon
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> ---
>>> drivers/phy/Kconfig | 96 +----------------------
>>> drivers/phy/Makefile | 14 +---
>>> drivers/phy/samsung/Kconfig | 92 ++++++++++++++++++++++
>>> drivers/phy/samsung/Makefile | 11 +++
>>> drivers/phy/{ => samsung}/phy-exynos-dp-video.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos-mipi-video.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos-pcie.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos4210-usb2.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos5250-sata.c | 0
>>> drivers/phy/{ => samsung}/phy-exynos5250-usb2.c | 0
>>> drivers/phy/{ => samsung}/phy-s5pv210-usb2.c | 0
>>> drivers/phy/{ => samsung}/phy-samsung-usb2.c | 0
>>> drivers/phy/{ => samsung}/phy-samsung-usb2.h | 0
>>> 15 files changed, 108 insertions(+), 105 deletions(-)
>>> create mode 100644 drivers/phy/samsung/Kconfig
>>> create mode 100644 drivers/phy/samsung/Makefile
>>> rename drivers/phy/{ => samsung}/phy-exynos-dp-video.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos-mipi-video.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos-pcie.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos4210-usb2.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos5250-sata.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-exynos5250-usb2.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-s5pv210-usb2.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.c (100%)
>>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.h (100%)
>
> [snip]
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory
2017-03-12 23:18 ` Jaehoon Chung
@ 2017-03-13 8:59 ` Vivek Gautam
0 siblings, 0 replies; 5+ messages in thread
From: Vivek Gautam @ 2017-03-13 8:59 UTC (permalink / raw)
To: Jaehoon Chung
Cc: Kishon Vijay Abraham I, linux-kernel, Kukjin Kim,
Krzysztof Kozlowski, kamil, Sylwester Nawrocki,
Javier Martinez Canillas, linux-samsung-soc
Hi Jaehoon,
On Mon, Mar 13, 2017 at 4:48 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Vivek,
>
> On 03/12/2017 06:18 PM, Vivek Gautam wrote:
>> Hi Kishon,
>>
>>
>> On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Hi,
>>>
>>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>>> Make the "samsung" directory and move the Samsung specific files to
>>>> there for maintaining the files relevant to Samsung.
>>>
>>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>>> is a good step to make it a little better. Can you also add a MAINTAINER for
>>> drivers/phy/samsung?
>>
>> I remember making a similar attempt in past [1], but that time we couldn't
>> reach an agreement as to whether group the phy drivers based on
>> vendors or based on the type of phy.
>>
>> If you are fine with grouping the drivers for each vendor, I hope you can
>> consider picking that patch (I can respin the patch based on linux-phy/next).
>> Other driver maintainers were also cool with that older patch.
>>
>> Let me know your comments.
>>
>> [1] https://patchwork.kernel.org/patch/8762561/
>
> I didn't know you had already sent the patches.
> My RFC patch can be dropped. I think it's good way.
It is alright. Thank you for acknowledgement on dropping your patch.
Regards
Vivek
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Regards
>> Vivek
>>
>>>
>>> Thanks
>>> Kishon
>>>>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>> ---
>>>> drivers/phy/Kconfig | 96 +----------------------
>>>> drivers/phy/Makefile | 14 +---
>>>> drivers/phy/samsung/Kconfig | 92 ++++++++++++++++++++++
>>>> drivers/phy/samsung/Makefile | 11 +++
>>>> drivers/phy/{ => samsung}/phy-exynos-dp-video.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos-mipi-video.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos-pcie.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos4210-usb2.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos5250-sata.c | 0
>>>> drivers/phy/{ => samsung}/phy-exynos5250-usb2.c | 0
>>>> drivers/phy/{ => samsung}/phy-s5pv210-usb2.c | 0
>>>> drivers/phy/{ => samsung}/phy-samsung-usb2.c | 0
>>>> drivers/phy/{ => samsung}/phy-samsung-usb2.h | 0
>>>> 15 files changed, 108 insertions(+), 105 deletions(-)
>>>> create mode 100644 drivers/phy/samsung/Kconfig
>>>> create mode 100644 drivers/phy/samsung/Makefile
>>>> rename drivers/phy/{ => samsung}/phy-exynos-dp-video.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos-mipi-video.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos-pcie.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos4210-usb2.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos5250-sata.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-exynos5250-usb2.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-s5pv210-usb2.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.c (100%)
>>>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.h (100%)
>>
>> [snip]
>>
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-13 9:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170309113312epcas5p3eceb2a9cce9fc8ff6871bee7b45dc15e@epcas5p3.samsung.com>
[not found] ` <20170309113311.15345-1-jh80.chung@samsung.com>
[not found] ` <58C142F6.2030708@ti.com>
[not found] ` <CAJKOXPeYpifDySTdvgk2ra4rjNtBdqGBQV8dsMeWkXCJQPP2zg@mail.gmail.com>
2017-03-10 7:00 ` [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory Jaehoon Chung
2017-03-10 9:49 ` Kishon Vijay Abraham I
2017-03-10 17:55 ` Krzysztof Kozlowski
[not found] ` <CAFp+6iGj=me4uOpOy338oxiAi=0sLW4WnkCzzAMELkxp=ZmrVA@mail.gmail.com>
2017-03-12 23:18 ` Jaehoon Chung
2017-03-13 8:59 ` Vivek Gautam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).