From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Will McVicker <willmcvicker@google.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Saravana Kannan <saravanak@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 07/12] clk: samsung: set exynos arm64 clk driver as tristate
Date: Wed, 29 Sep 2021 15:09:20 +0200 [thread overview]
Message-ID: <ac328b6a-a8e2-873d-4015-814cb4f5588e@canonical.com> (raw)
In-Reply-To: <20210928235635.1348330-8-willmcvicker@google.com>
On 29/09/2021 01:56, Will McVicker wrote:
> This sets the COMMON_CLK_SAMSUNG and EXYNOS_ARM64_COMMON_CLK drivers as
> tristate so that we can compile them as modules.
This is not the only thing you are doing. You are removing the enforced
built-in and this must be here explained and tested. The policy so far
was that all S3C, S5P and Exynos supported platforms select (enforce)
necessary drivers. Please explain in commit msg reasoning why this is
being changed and what's the impact (whether it actually works).
What is more, it seems you entirely ignored Geert's comments. I pointed
attention to it last time and you just said you will send v2 instead of
joining discussion.
It's a NAK for this reason - ignoring what Geert brought: you just broke
distro configs for Exynos.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-09-29 13:09 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 23:56 [PATCH v2 00/12] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker
2021-09-28 23:56 ` [PATCH v2 01/12] arm64: don't have ARCH_EXYNOS select EXYNOS_CHIPID Will McVicker
2021-09-29 13:58 ` (subset) " Krzysztof Kozlowski
2021-09-29 14:00 ` Krzysztof Kozlowski
2021-09-28 23:56 ` [PATCH v2 02/12] timekeeping: add API for getting timekeeping_suspended Will McVicker
2021-09-29 3:42 ` John Stultz
2021-09-29 20:01 ` Will McVicker
2021-09-29 20:46 ` John Stultz
2021-09-30 18:31 ` Will McVicker
2021-09-28 23:56 ` [PATCH v2 03/12] clk: samsung: add support for CPU clocks Will McVicker
2021-09-28 23:56 ` [PATCH v2 04/12] clk: samsung: exynos5433: update apollo and atlas clock probing Will McVicker
2021-09-28 23:56 ` [PATCH v2 05/12] clk: export __clk_lookup Will McVicker
2021-10-08 4:31 ` Stephen Boyd
2021-09-28 23:56 ` [PATCH v2 06/12] clk: samsung: modularize exynos arm64 clk drivers Will McVicker
2021-09-28 23:56 ` [PATCH v2 07/12] clk: samsung: set exynos arm64 clk driver as tristate Will McVicker
2021-09-29 13:09 ` Krzysztof Kozlowski [this message]
2021-09-28 23:56 ` [PATCH v2 08/12] pinctrl: samsung: modularize the ARM and ARM64 pinctrls Will McVicker
2021-09-29 2:01 ` Chanho Park
2021-09-28 23:56 ` [PATCH v2 09/12] pinctrl: samsung: set PINCTRL_EXYNOS and PINCTRL_SAMSUNG as tristate Will McVicker
2021-09-28 23:56 ` [PATCH v2 10/12] soc: samsung: pmu: modularize the Exynos ARMv8 PMU driver Will McVicker
2021-09-29 13:11 ` Krzysztof Kozlowski
2021-09-28 23:56 ` [PATCH v2 11/12] soc: samsung: pm_domains: modularize EXYNOS_PM_DOMAINS Will McVicker
2021-09-29 13:36 ` Krzysztof Kozlowski
2021-09-28 23:56 ` [PATCH v2 12/12] ARM: rtc: remove HAVE_S3C_RTC in favor of direct dependencies Will McVicker
2021-09-29 11:52 ` Alexandre Belloni
2021-09-29 13:02 ` [PATCH v2 00/12] arm64: Kconfig: Update ARCH_EXYNOS select configs Krzysztof Kozlowski
2021-09-29 19:48 ` Will McVicker
2021-09-30 6:14 ` Krzysztof Kozlowski
2021-09-30 9:01 ` Arnd Bergmann
2021-09-30 9:30 ` Lee Jones
2021-09-30 10:33 ` Krzysztof Kozlowski
2021-09-30 12:34 ` Lee Jones
2021-09-30 12:38 ` Krzysztof Kozlowski
2021-09-30 10:05 ` Geert Uytterhoeven
2021-09-30 9:23 ` Lee Jones
2021-09-30 10:17 ` Geert Uytterhoeven
2021-09-30 10:56 ` Lee Jones
2021-09-30 11:25 ` Geert Uytterhoeven
2021-09-30 12:08 ` Lee Jones
2021-09-30 16:09 ` Geert Uytterhoeven
2021-09-30 10:52 ` Krzysztof Kozlowski
2021-09-30 12:32 ` Lee Jones
2021-09-30 11:01 ` Tomasz Figa
2021-09-30 11:27 ` Geert Uytterhoeven
2021-09-30 11:51 ` Lee Jones
2021-09-30 12:10 ` Tomasz Figa
2021-09-30 12:15 ` Krzysztof Kozlowski
2021-09-30 12:45 ` Lee Jones
2021-10-01 4:01 ` Christoph Hellwig
2021-10-01 4:52 ` Saravana Kannan
2021-10-01 4:55 ` Christoph Hellwig
2021-09-30 12:21 ` Krzysztof Kozlowski
2021-09-30 12:39 ` Lee Jones
2021-09-30 13:08 ` Krzysztof Kozlowski
2021-09-30 13:29 ` Lee Jones
2021-09-30 16:12 ` Geert Uytterhoeven
2021-09-30 16:21 ` Lee Jones
2021-09-30 16:26 ` Geert Uytterhoeven
2021-09-30 18:02 ` Will McVicker
2021-10-01 4:04 ` Christoph Hellwig
2021-10-01 4:52 ` Olof Johansson
2021-10-01 5:23 ` Saravana Kannan
2021-10-01 5:35 ` Olof Johansson
2021-10-01 5:59 ` Will McVicker
2021-10-01 8:01 ` Krzysztof Kozlowski
2021-10-01 6:02 ` Saravana Kannan
2021-10-01 6:27 ` Olof Johansson
2021-10-01 6:30 ` Olof Johansson
2021-10-01 12:00 ` Arnd Bergmann
2021-10-01 12:31 ` Lee Jones
2021-10-01 15:43 ` Olof Johansson
2021-10-01 11:38 ` Linus Walleij
2021-10-01 11:59 ` Geert Uytterhoeven
2021-10-01 15:59 ` Olof Johansson
2021-10-01 16:51 ` Will McVicker
2021-10-01 17:15 ` Olof Johansson
2021-10-01 17:48 ` Will McVicker
2021-10-01 8:19 ` Geert Uytterhoeven
2021-10-01 9:00 ` Arnd Bergmann
2021-10-01 15:27 ` Olof Johansson
2021-10-01 19:26 ` Saravana Kannan
2021-10-02 1:47 ` Tomasz Figa
2021-10-02 21:03 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac328b6a-a8e2-873d-4015-814cb4f5588e@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=geert@linux-m68k.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tomasz.figa@gmail.com \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).