linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE
@ 2021-05-12  6:39 Zou Wei
  2021-05-12 11:47 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-05-12  6:39 UTC (permalink / raw)
  To: krzysztof.kozlowski, vkoul
  Cc: linux-arm-kernel, linux-samsung-soc, dmaengine, linux-kernel, Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/dma/s3c24xx-dma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
index 8e14c72..f1ebaa6 100644
--- a/drivers/dma/s3c24xx-dma.c
+++ b/drivers/dma/s3c24xx-dma.c
@@ -1175,6 +1175,7 @@ static const struct platform_device_id s3c24xx_dma_driver_ids[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE(platform, s3c24xx_dma_driver_ids);
 
 static struct soc_data *s3c24xx_dma_get_soc_data(struct platform_device *pdev)
 {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE
  2021-05-12  6:39 [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE Zou Wei
@ 2021-05-12 11:47 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-12 11:47 UTC (permalink / raw)
  To: Zou Wei, vkoul
  Cc: linux-arm-kernel, linux-samsung-soc, dmaengine, linux-kernel

On 12/05/2021 02:39, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.


Hi,

Thanks for the patch. It cannot be built as a module.

> 
> Reported-by: Hulk Robot <hulkci@huawei.com>

Please make the reports public. This is open source work and public
collaboration.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-12 11:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12  6:39 [PATCH -next] dmaengine: s3c24xx: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 11:47 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).