* [PATCH] devfreq: exyos-bus: drop of_match_ptr for ID table
@ 2023-03-11 17:37 Krzysztof Kozlowski
2023-03-13 10:37 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 17:37 UTC (permalink / raw)
To: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Krzysztof Kozlowski,
Alim Akhtar, linux-pm, linux-samsung-soc, linux-arm-kernel,
linux-kernel
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).
drivers/devfreq/exynos-bus.c:504:34: error: ‘exynos_bus_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/devfreq/exynos-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index 027e8f336acc..f7c554051232 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -513,7 +513,7 @@ static struct platform_driver exynos_bus_platdrv = {
.driver = {
.name = "exynos-bus",
.pm = &exynos_bus_pm,
- .of_match_table = of_match_ptr(exynos_bus_of_match),
+ .of_match_table = exynos_bus_of_match,
},
};
module_platform_driver(exynos_bus_platdrv);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] devfreq: exyos-bus: drop of_match_ptr for ID table
2023-03-11 17:37 [PATCH] devfreq: exyos-bus: drop of_match_ptr for ID table Krzysztof Kozlowski
@ 2023-03-13 10:37 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2023-03-13 10:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Chanwoo Choi, MyungJoo Ham, Kyungmin Park,
Alim Akhtar, linux-pm, linux-samsung-soc, linux-arm-kernel,
linux-kernel
On 23. 3. 12. 02:37, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/devfreq/exynos-bus.c:504:34: error: ‘exynos_bus_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/devfreq/exynos-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 027e8f336acc..f7c554051232 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -513,7 +513,7 @@ static struct platform_driver exynos_bus_platdrv = {
> .driver = {
> .name = "exynos-bus",
> .pm = &exynos_bus_pm,
> - .of_match_table = of_match_ptr(exynos_bus_of_match),
> + .of_match_table = exynos_bus_of_match,
> },
> };
> module_platform_driver(exynos_bus_platdrv);
Applied it with 'PM / ' prefix to keep the consistent title style.
- PM / devfreq: exyos-bus: drop of_match_ptr for ID table
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-13 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 17:37 [PATCH] devfreq: exyos-bus: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-13 10:37 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).