From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergey Lisov <sleirsgoevy@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants
Date: Sun, 12 Mar 2023 18:09:10 +0100 [thread overview]
Message-ID: <f34ba6e5-4a8d-0812-c334-ea47de7b1d21@linaro.org> (raw)
In-Reply-To: <640e0136.c20a0220.2d5bf.1959@mx.google.com>
On 12/03/2023 17:43, Sergey Lisov wrote:
>> Bindings and DTS (and driver) are always separate.
>
> Okay, will split the patch.
>
>> Compatibles must be specific.
>
> No, this way you'd have tons of identical compatibles that only differ in
> the exynosXXXX digits, and are functionally equivalent.
Thanks for letting me know.
https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
>> That's non-bisectable change (also breaking other users of DTS), so you
>> need to explain in commit msg rationale - devices were never compatible
>> and using exynos7 does not work in certain cases.
BTW, this rationale was only example - you need to come with something real.
Best regards,
Krzysztof
next parent reply other threads:[~2023-03-12 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <640e0136.c20a0220.2d5bf.1959@mx.google.com>
2023-03-12 17:09 ` Krzysztof Kozlowski [this message]
2023-03-12 17:26 ` [PATCH v3 1/2] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants Sergey Lisov
[not found] <640e0b2d.c20a0220.63661.19a4@mx.google.com>
2023-03-12 17:29 ` Krzysztof Kozlowski
2023-03-12 13:03 [PATCH v3 0/2] mmc: dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems Sergey Lisov
2023-03-12 13:03 ` [PATCH v3 1/2] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants Sergey Lisov
2023-03-12 13:35 ` Krzysztof Kozlowski
2023-03-12 16:43 ` Sergey Lisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f34ba6e5-4a8d-0812-c334-ea47de7b1d21@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sleirsgoevy@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).