* [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
@ 2019-12-03 6:58 Can Guo
0 siblings, 0 replies; 7+ messages in thread
From: Can Guo @ 2019-12-03 6:58 UTC (permalink / raw)
To: asutoshd, nguyenb, rnayak, linux-scsi, kernel-team, saravanak,
salyzyn, cang
Cc: Alim Akhtar, Avri Altman, Pedro Sousa, James E.J. Bottomley,
Martin K. Petersen, Bean Huo, Evan Green, open list
Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
unique ID by appending the scsi host number to its device name.
Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)
Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
index dc2f6d2..d2197a3 100644
--- a/drivers/scsi/ufs/ufs_bsg.c
+++ b/drivers/scsi/ufs/ufs_bsg.c
@@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
bsg_dev->parent = get_device(parent);
bsg_dev->release = ufs_bsg_node_release;
- dev_set_name(bsg_dev, "ufs-bsg");
+ dev_set_name(bsg_dev, "ufs-bsg%u", shost->host_no);
ret = device_add(bsg_dev);
if (ret)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
[not found] <0101016eca8dc8ee-d58c2ce0-2c25-40ee-8ae0-237fce4fa82d-000000@us-west-2.amazonses.com>
@ 2019-12-09 23:53 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2019-12-09 23:53 UTC (permalink / raw)
To: Can Guo
Cc: asutoshd, nguyenb, rnayak, linux-scsi, kernel-team, saravanak,
salyzyn, Alim Akhtar, Avri Altman, Pedro Sousa,
James E.J. Bottomley, Martin K. Petersen, Bean Huo, Evan Green,
open list
Can,
You seem to be sending duplicates of almost every mail which makes it
hard for me (and patchwork) to track your series. The mails are
identical except for Message-Id:.
Also, don't resubmit patches just to add Reviewed-by: tags. Patchwork
will pick up the tags. Only resubmit if you are making changes. And if
you do, use -vN to bump the version.
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
> unique ID by appending the scsi host number to its device name.
>
> Fixes: df032bf27 (scsi: ufs: Add a bsg endpoint that supports UPIUs)
Please use 12-char SHA and enclose commit summary in quotes. See:
Documentation/process/submitting-patches.rst
Fixes: df032bf27a41 ("scsi: ufs: Add a bsg endpoint that supports UPIUs")
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Applied to 5.5/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
2019-12-02 3:23 Can Guo
@ 2019-12-02 17:53 ` Christoph Hellwig
0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2019-12-02 17:53 UTC (permalink / raw)
To: Can Guo
Cc: asutoshd, nguyenb, rnayak, linux-scsi, kernel-team, saravanak,
salyzyn, Alim Akhtar, Avri Altman, Pedro Sousa,
James E.J. Bottomley, Martin K. Petersen, Bean Huo, Evan Green,
open list
On Mon, Dec 02, 2019 at 03:23:25AM +0000, Can Guo wrote:
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
> unique ID by appending the scsi host number to its device name.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
This should also get a Fixes: tag so that it gets backported.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
[not found] <0101016ec4a25faa-77e03f78-006b-4b7c-bf8a-d56378f4b1be-000000@us-west-2.amazonses.com>
2019-12-02 7:23 ` Avri Altman
@ 2019-12-02 7:34 ` Avri Altman
1 sibling, 0 replies; 7+ messages in thread
From: Avri Altman @ 2019-12-02 7:34 UTC (permalink / raw)
To: Can Guo, asutoshd, nguyenb, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn
Cc: Alim Akhtar, Pedro Sousa, James E.J. Bottomley,
Martin K. Petersen, Bean Huo, Evan Green, open list
>
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an unique
> ID by appending the scsi host number to its device name.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
2019-12-02 7:23 ` Avri Altman
@ 2019-12-02 7:29 ` cang
0 siblings, 0 replies; 7+ messages in thread
From: cang @ 2019-12-02 7:29 UTC (permalink / raw)
To: Avri Altman
Cc: asutoshd, nguyenb, rnayak, linux-scsi, kernel-team, saravanak,
salyzyn, Alim Akhtar, Pedro Sousa, James E.J. Bottomley,
Martin K. Petersen, Bean Huo, Evan Green, open list
On 2019-12-02 15:23, Avri Altman wrote:
> Hi,
>>
>> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg
>> an unique
>> ID by appending the scsi host number to its device name.
> Can you refer me to such a design?
>
> Thanks,
> Avri
>
Consider a platform which has an embedded UFS device and supports a UFS
card meanwhile.
This conbination is very popular nowadays. BTW, 845 started supporting
two UFS hosts 3 years ago.
Thanks,
Can Guo
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>>
>> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
>> index
>> dc2f6d2..3ef5b78 100644
>> --- a/drivers/scsi/ufs/ufs_bsg.c
>> +++ b/drivers/scsi/ufs/ufs_bsg.c
>> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
>> bsg_dev->parent = get_device(parent);
>> bsg_dev->release = ufs_bsg_node_release;
>>
>> - dev_set_name(bsg_dev, "ufs-bsg");
>> + dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
>>
>> ret = device_add(bsg_dev);
>> if (ret)
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
[not found] <0101016ec4a25faa-77e03f78-006b-4b7c-bf8a-d56378f4b1be-000000@us-west-2.amazonses.com>
@ 2019-12-02 7:23 ` Avri Altman
2019-12-02 7:29 ` cang
2019-12-02 7:34 ` Avri Altman
1 sibling, 1 reply; 7+ messages in thread
From: Avri Altman @ 2019-12-02 7:23 UTC (permalink / raw)
To: Can Guo, asutoshd, nguyenb, rnayak, linux-scsi, kernel-team,
saravanak, salyzyn
Cc: Alim Akhtar, Pedro Sousa, James E.J. Bottomley,
Martin K. Petersen, Bean Huo, Evan Green, open list
Hi,
>
> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an unique
> ID by appending the scsi host number to its device name.
Can you refer me to such a design?
Thanks,
Avri
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
>
> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c index
> dc2f6d2..3ef5b78 100644
> --- a/drivers/scsi/ufs/ufs_bsg.c
> +++ b/drivers/scsi/ufs/ufs_bsg.c
> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
> bsg_dev->parent = get_device(parent);
> bsg_dev->release = ufs_bsg_node_release;
>
> - dev_set_name(bsg_dev, "ufs-bsg");
> + dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
>
> ret = device_add(bsg_dev);
> if (ret)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
@ 2019-12-02 3:23 Can Guo
2019-12-02 17:53 ` Christoph Hellwig
0 siblings, 1 reply; 7+ messages in thread
From: Can Guo @ 2019-12-02 3:23 UTC (permalink / raw)
To: asutoshd, nguyenb, rnayak, linux-scsi, kernel-team, saravanak,
salyzyn, cang
Cc: Alim Akhtar, Avri Altman, Pedro Sousa, James E.J. Bottomley,
Martin K. Petersen, Bean Huo, Evan Green, open list
Considering there can be multiple UFS hosts in SoC, give each ufs-bsg an
unique ID by appending the scsi host number to its device name.
Signed-off-by: Can Guo <cang@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
index dc2f6d2..3ef5b78 100644
--- a/drivers/scsi/ufs/ufs_bsg.c
+++ b/drivers/scsi/ufs/ufs_bsg.c
@@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
bsg_dev->parent = get_device(parent);
bsg_dev->release = ufs_bsg_node_release;
- dev_set_name(bsg_dev, "ufs-bsg");
+ dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
ret = device_add(bsg_dev);
if (ret)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-09 23:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 6:58 [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg Can Guo
[not found] <0101016eca8dc8ee-d58c2ce0-2c25-40ee-8ae0-237fce4fa82d-000000@us-west-2.amazonses.com>
2019-12-09 23:53 ` Martin K. Petersen
[not found] <0101016ec4a25faa-77e03f78-006b-4b7c-bf8a-d56378f4b1be-000000@us-west-2.amazonses.com>
2019-12-02 7:23 ` Avri Altman
2019-12-02 7:29 ` cang
2019-12-02 7:34 ` Avri Altman
-- strict thread matches above, loose matches on Subject: below --
2019-12-02 3:23 Can Guo
2019-12-02 17:53 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).