From: Stanley Chu <stanley.chu@mediatek.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Kuohong Wang (王國鴻)" <kuohong.wang@mediatek.com>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
"Andy Teng (鄧如宏)" <Andy.Teng@mediatek.com>
Subject: Re: [PATCH v1 1/2] block: bypass blk_set_runtime_active for uninitialized q->dev
Date: Thu, 12 Sep 2019 16:33:12 +0800 [thread overview]
Message-ID: <1568277192.16730.16.camel@mtkswgap22> (raw)
In-Reply-To: <66fddf12-0dc4-1c73-affd-f8404e87342f@kernel.dk>
Hi Jens,
> > void blk_set_runtime_active(struct request_queue *q)
> > {
> > + if (!q->dev)
> > + return;
> > +
> > spin_lock_irq(&q->queue_lock);
> > q->rpm_status = RPM_ACTIVE;
> > pm_runtime_mark_last_busy(q->dev);
>
> I'd prefer just doing:
>
> if (q->dev) {
> ...
> }
>
> instead. Other than that little complaint, looks good to me.
>
OK! I will change it in v2.
Thanks,
Stanley
next prev parent reply other threads:[~2019-09-12 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 6:32 [PATCH v1] fixup null q->dev checking in both block and scsi layer Stanley Chu
2019-09-11 6:32 ` [PATCH v1 1/2] block: bypass blk_set_runtime_active for uninitialized q->dev Stanley Chu
2019-09-11 22:13 ` Jens Axboe
2019-09-12 8:33 ` Stanley Chu [this message]
2019-09-11 6:32 ` [PATCH v1 2/2] scsi: core: remove dummy q->dev check Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568277192.16730.16.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=Andy.Teng@mediatek.com \
--cc=Chun-hung.Wu@mediatek.com \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).