From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>,
"John Garry" <john.garry@huawei.com>
Subject: [PATCH 01/18] scsi: hisi_sas: Don't create debugfs dump folder twice
Date: Tue, 22 Oct 2019 00:21:58 +0800 [thread overview]
Message-ID: <1571674935-108326-2-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1571674935-108326-1-git-send-email-john.garry@huawei.com>
From: Xiang Chen <chenxiang66@hisilicon.com>
Due to a merge error, we attempt to create 2x debugfs dump folders, which
fails:
[ 861.101914] debugfs: Directory 'dump' with parent '0000:74:02.0'
already present!
This breaks the dump function.
To fix, remove the superfluous attempt to create the folder.
Fixes: 7ec7082c57ec ("scsi: hisi_sas: Add hisi_sas_debugfs_alloc() to centralise allocation")
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 1a25f0f15fd0..ceba1016b77f 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -3712,9 +3712,6 @@ static int hisi_sas_debugfs_alloc(struct hisi_hba *hisi_hba)
int p, c, d;
size_t sz;
- hisi_hba->debugfs_dump_dentry =
- debugfs_create_dir("dump", hisi_hba->debugfs_dir);
-
sz = hw->debugfs_reg_array[DEBUGFS_GLOBAL]->count * 4;
hisi_hba->debugfs_regs[DEBUGFS_GLOBAL] =
devm_kmalloc(dev, sz, GFP_KERNEL);
--
2.17.1
next prev parent reply other threads:[~2019-10-21 16:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 16:21 [PATCH 00/18] hisi_sas: Misc patches, mostly debugfs John Garry
2019-10-21 16:21 ` John Garry [this message]
2019-10-21 16:21 ` [PATCH 02/18] scsi: hisi_sas: Set the BIST init value before enabling BIST John Garry
2019-10-21 16:22 ` [PATCH 03/18] scsi: hisi_sas: use wait_for_completion_timeout() when clearing ITCT John Garry
2019-10-21 16:22 ` [PATCH 04/18] scsi: hisi_sas: Replace in_softirq() check in hisi_sas_task_exec() John Garry
2019-10-21 16:22 ` [PATCH 05/18] scsi: hisi_sas: Add timestamp for a debugfs dump John Garry
2019-10-24 9:20 ` kbuild test robot
2019-10-24 9:54 ` John Garry
2019-10-21 16:22 ` [PATCH 06/18] scsi: hisi_sas: Add debugfs file structure for CQ John Garry
2019-10-21 16:22 ` [PATCH 07/18] scsi: hisi_sas: Add debugfs file structure for DQ John Garry
2019-10-21 16:22 ` [PATCH 08/18] scsi: hisi_sas: Add debugfs file structure for registers John Garry
2019-10-21 16:22 ` [PATCH 09/18] scsi: hisi_sas: Add debugfs file structure for port John Garry
2019-10-21 16:22 ` [PATCH 10/18] scsi: hisi_sas: Add debugfs file structure for IOST John Garry
2019-10-21 16:22 ` [PATCH 11/18] scsi: hisi_sas: Add debugfs file structure for ITCT John Garry
2019-10-21 16:22 ` [PATCH 12/18] scsi: hisi_sas: Add debugfs file structure for IOST cache John Garry
2019-10-21 16:22 ` [PATCH 13/18] scsi: hisi_sas: Add debugfs file structure for ITCT cache John Garry
2019-10-21 16:22 ` [PATCH 14/18] scsi: hisi_sas: Allocate memory for multiple dumps of debugfs John Garry
2019-10-21 16:22 ` [PATCH 15/18] scsi: hisi_sas: Add module parameter for debugfs dump count John Garry
2019-10-21 16:22 ` [PATCH 16/18] scsi: hisi_sas: Add ability to have multiple debugfs dumps John Garry
2019-10-21 16:22 ` [PATCH 17/18] scsi: hisi_sas: Delete the debugfs folder of hisi_sas when the probe fails John Garry
2019-10-21 16:22 ` [PATCH 18/18] scsi: hisi_sas: Record the phy down event in debugfs John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571674935-108326-2-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).