linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linuxarm@huawei.com>,
	<linux-kernel@vger.kernel.org>,
	Luo Jiaxing <luojiaxing@huawei.com>,
	"John Garry" <john.garry@huawei.com>
Subject: [PATCH 05/18] scsi: hisi_sas: Add timestamp for a debugfs dump
Date: Tue, 22 Oct 2019 00:22:02 +0800	[thread overview]
Message-ID: <1571674935-108326-6-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1571674935-108326-1-git-send-email-john.garry@huawei.com>

From: Luo Jiaxing <luojiaxing@huawei.com>

It's useful to know when the dump occurred, so add a timestamp file for
this.

Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas.h      | 2 ++
 drivers/scsi/hisi_sas/hisi_sas_main.c | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 83232e8472fb..7069dae4cec9 100644
--- a/drivers/scsi/hisi_sas/hisi_sas.h
+++ b/drivers/scsi/hisi_sas/hisi_sas.h
@@ -21,6 +21,7 @@
 #include <linux/platform_device.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
+#include <linux/timer.h>
 #include <scsi/sas_ata.h>
 #include <scsi/libsas.h>
 
@@ -410,6 +411,7 @@ struct hisi_hba {
 	struct hisi_sas_iost *debugfs_iost;
 	struct hisi_sas_itct *debugfs_itct;
 	u64 *debugfs_iost_cache;
+	u64 debugfs_timestamp;
 	u64 *debugfs_itct_cache;
 
 	struct dentry *debugfs_dir;
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index a7bac5dc389a..a983d08c03aa 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -3194,6 +3194,7 @@ static const struct file_operations hisi_sas_debugfs_itct_cache_fops = {
 
 static void hisi_sas_debugfs_create_files(struct hisi_hba *hisi_hba)
 {
+	u64 *debugfs_timestamp;
 	struct dentry *dump_dentry;
 	struct dentry *dentry;
 	char name[256];
@@ -3201,10 +3202,14 @@ static void hisi_sas_debugfs_create_files(struct hisi_hba *hisi_hba)
 	int c;
 	int d;
 
+	debugfs_timestamp = &hisi_hba->debugfs_timestamp;
 	/* Create dump dir inside device dir */
 	dump_dentry = debugfs_create_dir("dump", hisi_hba->debugfs_dir);
 	hisi_hba->debugfs_dump_dentry = dump_dentry;
 
+	debugfs_create_u64("timestamp", 0400, dump_dentry,
+			   debugfs_timestamp);
+
 	debugfs_create_file("global", 0400, dump_dentry, hisi_hba,
 			    &hisi_sas_debugfs_global_fops);
 
@@ -3684,7 +3689,9 @@ void hisi_sas_debugfs_work_handler(struct work_struct *work)
 {
 	struct hisi_hba *hisi_hba =
 		container_of(work, struct hisi_hba, debugfs_work);
+	u64 timestamp = local_clock() / NSEC_PER_MSEC;
 
+	hisi_hba->debugfs_timestamp = timestamp;
 	if (hisi_hba->debugfs_snapshot)
 		return;
 	hisi_hba->debugfs_snapshot = true;
-- 
2.17.1


  parent reply	other threads:[~2019-10-21 16:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 16:21 [PATCH 00/18] hisi_sas: Misc patches, mostly debugfs John Garry
2019-10-21 16:21 ` [PATCH 01/18] scsi: hisi_sas: Don't create debugfs dump folder twice John Garry
2019-10-21 16:21 ` [PATCH 02/18] scsi: hisi_sas: Set the BIST init value before enabling BIST John Garry
2019-10-21 16:22 ` [PATCH 03/18] scsi: hisi_sas: use wait_for_completion_timeout() when clearing ITCT John Garry
2019-10-21 16:22 ` [PATCH 04/18] scsi: hisi_sas: Replace in_softirq() check in hisi_sas_task_exec() John Garry
2019-10-21 16:22 ` John Garry [this message]
2019-10-24  9:20   ` [PATCH 05/18] scsi: hisi_sas: Add timestamp for a debugfs dump kbuild test robot
2019-10-24  9:54     ` John Garry
2019-10-21 16:22 ` [PATCH 06/18] scsi: hisi_sas: Add debugfs file structure for CQ John Garry
2019-10-21 16:22 ` [PATCH 07/18] scsi: hisi_sas: Add debugfs file structure for DQ John Garry
2019-10-21 16:22 ` [PATCH 08/18] scsi: hisi_sas: Add debugfs file structure for registers John Garry
2019-10-21 16:22 ` [PATCH 09/18] scsi: hisi_sas: Add debugfs file structure for port John Garry
2019-10-21 16:22 ` [PATCH 10/18] scsi: hisi_sas: Add debugfs file structure for IOST John Garry
2019-10-21 16:22 ` [PATCH 11/18] scsi: hisi_sas: Add debugfs file structure for ITCT John Garry
2019-10-21 16:22 ` [PATCH 12/18] scsi: hisi_sas: Add debugfs file structure for IOST cache John Garry
2019-10-21 16:22 ` [PATCH 13/18] scsi: hisi_sas: Add debugfs file structure for ITCT cache John Garry
2019-10-21 16:22 ` [PATCH 14/18] scsi: hisi_sas: Allocate memory for multiple dumps of debugfs John Garry
2019-10-21 16:22 ` [PATCH 15/18] scsi: hisi_sas: Add module parameter for debugfs dump count John Garry
2019-10-21 16:22 ` [PATCH 16/18] scsi: hisi_sas: Add ability to have multiple debugfs dumps John Garry
2019-10-21 16:22 ` [PATCH 17/18] scsi: hisi_sas: Delete the debugfs folder of hisi_sas when the probe fails John Garry
2019-10-21 16:22 ` [PATCH 18/18] scsi: hisi_sas: Record the phy down event in debugfs John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571674935-108326-6-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=luojiaxing@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).