* [next] scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer
@ 2020-07-23 11:56 Varun Prakash
2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Varun Prakash @ 2020-07-23 11:56 UTC (permalink / raw)
To: martin.petersen; +Cc: linux-scsi, dan.carpenter, dt, ganji.aravind, varun
'tdata' pointer will never be NULL so remove NULL checks.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Varun Prakash <varun@chelsio.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 932dbd4..71aebaf 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -1899,7 +1899,7 @@ int cxgbi_conn_alloc_pdu(struct iscsi_task *task, u8 op)
u32 last_tdata_offset, last_tdata_count;
int err = 0;
- if (!tcp_task || !tdata) {
+ if (!tcp_task) {
pr_err("task 0x%p, tcp_task 0x%p, tdata 0x%p.\n",
task, tcp_task, tdata);
return -ENOMEM;
@@ -2155,7 +2155,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
struct page *pg;
int err;
- if (!tcp_task || !tdata || tcp_task->dd_data != tdata) {
+ if (!tcp_task || (tcp_task->dd_data != tdata)) {
pr_err("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
task, task->sc, tcp_task,
tcp_task ? tcp_task->dd_data : NULL, tdata);
@@ -2371,7 +2371,7 @@ int cxgbi_conn_xmit_pdu(struct iscsi_task *task)
u32 datalen;
int err;
- if (!tcp_task || !tdata || (tcp_task->dd_data != tdata)) {
+ if (!tcp_task || (tcp_task->dd_data != tdata)) {
pr_err("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
task, task->sc, tcp_task,
tcp_task ? tcp_task->dd_data : NULL, tdata);
@@ -2472,7 +2472,7 @@ void cxgbi_cleanup_task(struct iscsi_task *task)
struct iscsi_tcp_task *tcp_task = task->dd_data;
struct cxgbi_task_data *tdata = iscsi_task_cxgbi_data(task);
- if (!tcp_task || !tdata || (tcp_task->dd_data != tdata)) {
+ if (!tcp_task || (tcp_task->dd_data != tdata)) {
pr_info("task 0x%p,0x%p, tcp_task 0x%p, tdata 0x%p/0x%p.\n",
task, task->sc, tcp_task,
tcp_task ? tcp_task->dd_data : NULL, tdata);
--
2.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [next] scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer
2020-07-23 11:56 [next] scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer Varun Prakash
@ 2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-07-25 2:50 UTC (permalink / raw)
To: Varun Prakash
Cc: Martin K . Petersen, dt, ganji.aravind, dan.carpenter, linux-scsi
On Thu, 23 Jul 2020 17:26:31 +0530, Varun Prakash wrote:
> 'tdata' pointer will never be NULL so remove NULL checks.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer
https://git.kernel.org/mkp/scsi/c/61965bf6c142
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 11:56 [next] scsi: libcxgbi: Remove unnecessary NULL checks for 'tdata' pointer Varun Prakash
2020-07-25 2:50 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).