* [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
@ 2021-01-18 18:49 Enzo Matsumiya
2021-01-19 8:55 ` Daniel Wagner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Enzo Matsumiya @ 2021-01-18 18:49 UTC (permalink / raw)
To: linux-scsi, linux-kernel
Cc: Enzo Matsumiya, Nilesh Javali, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, Martin K. Petersen, Arun Easi, Quinn Tran,
Himanshu Madhani
Parameter ql2xenforce_iocb_limit is enabled by default.
Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index f80abe28f35a..0e0fe5b09496 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
int ql2xenforce_iocb_limit = 1;
module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(ql2xenforce_iocb_limit,
- "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
+ "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
/*
* CT6 CTX allocation cache
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
2021-01-18 18:49 [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit Enzo Matsumiya
@ 2021-01-19 8:55 ` Daniel Wagner
2021-01-19 15:16 ` Himanshu Madhani
2021-01-21 3:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Wagner @ 2021-01-19 8:55 UTC (permalink / raw)
To: Enzo Matsumiya
Cc: linux-scsi, linux-kernel, Nilesh Javali,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Arun Easi, Quinn Tran, Himanshu Madhani
On Mon, Jan 18, 2021 at 03:49:22PM -0300, Enzo Matsumiya wrote:
> Parameter ql2xenforce_iocb_limit is enabled by default.
>
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
2021-01-18 18:49 [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit Enzo Matsumiya
2021-01-19 8:55 ` Daniel Wagner
@ 2021-01-19 15:16 ` Himanshu Madhani
2021-01-21 3:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2021-01-19 15:16 UTC (permalink / raw)
To: Enzo Matsumiya
Cc: linux-scsi, Linux Kernel Mailing List, Nilesh Javali,
GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Arun Easi, Quinn Tran
> On Jan 18, 2021, at 12:49 PM, Enzo Matsumiya <ematsumiya@suse.de> wrote:
>
> Parameter ql2xenforce_iocb_limit is enabled by default.
>
> Fixes: 89c72f4245a8 ("scsi: qla2xxx: Add IOCB resource tracking")
> Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index f80abe28f35a..0e0fe5b09496 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -42,7 +42,7 @@ MODULE_PARM_DESC(ql2xfulldump_on_mpifail,
> int ql2xenforce_iocb_limit = 1;
> module_param(ql2xenforce_iocb_limit, int, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(ql2xenforce_iocb_limit,
> - "Enforce IOCB throttling, to avoid FW congestion. (default: 0)");
> + "Enforce IOCB throttling, to avoid FW congestion. (default: 1)");
>
> /*
> * CT6 CTX allocation cache
> --
> 2.29.2
>
Good Catch.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
2021-01-18 18:49 [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit Enzo Matsumiya
2021-01-19 8:55 ` Daniel Wagner
2021-01-19 15:16 ` Himanshu Madhani
@ 2021-01-21 3:35 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-01-21 3:35 UTC (permalink / raw)
To: linux-scsi, linux-kernel, Enzo Matsumiya
Cc: Martin K . Petersen, Himanshu Madhani, James E.J. Bottomley,
Arun Easi, Nilesh Javali, GR-QLogic-Storage-Upstream, Quinn Tran
On Mon, 18 Jan 2021 15:49:22 -0300, Enzo Matsumiya wrote:
> Parameter ql2xenforce_iocb_limit is enabled by default.
Applied to 5.11/scsi-fixes, thanks!
[1/1] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit
https://git.kernel.org/mkp/scsi/c/aa2c24e7f415
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-21 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 18:49 [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit Enzo Matsumiya
2021-01-19 8:55 ` Daniel Wagner
2021-01-19 15:16 ` Himanshu Madhani
2021-01-21 3:35 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).