linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
@ 2021-03-10 18:44 Bodo Stroesser
  2021-03-16  3:18 ` Martin K. Petersen
  2021-03-19  3:46 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Bodo Stroesser @ 2021-03-10 18:44 UTC (permalink / raw)
  To: linux-scsi, target-devel, Martin K. Petersen, Mike Christie
  Cc: Bodo Stroesser

In patch
 "scsi: target: tcmu: Replace radix_tree with XArray"
meaning of last parameter of tcmu_blocks_release was changed.
So in the callers we should subtract 1 from the previous
parameter.

Unfortunately that change got lost at one of the two places
where tcmu_blocks_release is called. That does not lead to any
problems, but we should adjust it anyway.

Signed-off-by: Bodo Stroesser <bostroesser@gmail.com>
---
 drivers/target/target_core_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 9e1b115cb032..bdfc057f000c 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1658,7 +1658,7 @@ static void tcmu_dev_kref_release(struct kref *kref)
 	xa_destroy(&udev->commands);
 	WARN_ON(!all_expired);
 
-	tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max + 1);
+	tcmu_blocks_release(&udev->data_blocks, 0, udev->dbi_max);
 	bitmap_free(udev->data_bitmap);
 	mutex_unlock(&udev->cmdr_lock);
 
-- 
2.12.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
  2021-03-10 18:44 [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release Bodo Stroesser
@ 2021-03-16  3:18 ` Martin K. Petersen
  2021-03-19  3:46 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-03-16  3:18 UTC (permalink / raw)
  To: Bodo Stroesser
  Cc: linux-scsi, target-devel, Martin K. Petersen, Mike Christie


Bodo,

> In patch "scsi: target: tcmu: Replace radix_tree with XArray" meaning
> of last parameter of tcmu_blocks_release was changed.  So in the
> callers we should subtract 1 from the previous parameter.

Applied to 5.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
  2021-03-10 18:44 [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release Bodo Stroesser
  2021-03-16  3:18 ` Martin K. Petersen
@ 2021-03-19  3:46 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-03-19  3:46 UTC (permalink / raw)
  To: target-devel, linux-scsi, Bodo Stroesser, Mike Christie
  Cc: Martin K . Petersen

On Wed, 10 Mar 2021 19:44:58 +0100, Bodo Stroesser wrote:

> In patch
>  "scsi: target: tcmu: Replace radix_tree with XArray"
> meaning of last parameter of tcmu_blocks_release was changed.
> So in the callers we should subtract 1 from the previous
> parameter.
> 
> Unfortunately that change got lost at one of the two places
> where tcmu_blocks_release is called. That does not lead to any
> problems, but we should adjust it anyway.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release
      https://git.kernel.org/mkp/scsi/c/471ee95ccca9

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-19  3:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 18:44 [PATCH] scsi: target: tcmu: Adjust parameter in call to tcmu_blocks_release Bodo Stroesser
2021-03-16  3:18 ` Martin K. Petersen
2021-03-19  3:46 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).