[PATCH 0/2] mpi3mr: Use shared host tagset

[PATCH 0/2] mpi3mr: Use shared host tagset

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

- Enabled the shared host tagset,
- Also increased the cmd_per_lun to 128.

Sreekanth Reddy (2):
  mpi3mr: Enable shared host tagset
  mpi3mr: Increase cmd_per_lun to 128

 drivers/scsi/mpi3mr/mpi3mr.h    | 2 +-
 drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

[PATCH 1/2] mpi3mr: Enable shared host tagset

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

Enable shared host tagset to make sure that total outstanding
IOs count won't cross controller's can_queue.

Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index d8c195b..da85eda 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -4321,6 +4321,8 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	shost->max_channel = 0;
 	shost->max_id = 0xFFFFFFFF;
 
+	shost->host_tagset = 1;
+
 	if (prot_mask >= 0)
 		scsi_host_set_prot(shost, prot_mask);
 	else {
-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

[PATCH 2/2] mpi3mr: Increase cmd_per_lun to 128

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Increase cmd_per_lun to 128.

Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpi3mr/mpi3mr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/mpi3mr/mpi3mr.h b/drivers/scsi/mpi3mr/mpi3mr.h
index 0e1cb4a..0557dbf 100644
--- a/drivers/scsi/mpi3mr/mpi3mr.h
+++ b/drivers/scsi/mpi3mr/mpi3mr.h
@@ -71,7 +71,7 @@ extern atomic64_t event_counter;
 #define MPI3MR_SG_DEPTH		(MPI3MR_PAGE_SIZE_4K / sizeof(struct mpi3_sge_common))
 
 /* Definitions for MAX values for shost */
-#define MPI3MR_MAX_CMDS_LUN	7
+#define MPI3MR_MAX_CMDS_LUN	128
 #define MPI3MR_MAX_CDB_LENGTH	32
 
 /* Admin queue management definitions */
-- 
2.27.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH 1/2] mpi3mr: Enable shared host tagset

[John Garry]

On 28/06/2022 08:48, Sreekanth Reddy wrote:
> Enable shared host tagset to make sure that total outstanding
> IOs count won't cross controller's can_queue.
> 
> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
> ---
>   drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> index d8c195b..da85eda 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> @@ -4321,6 +4321,8 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	shost->max_channel = 0;
>   	shost->max_id = 0xFFFFFFFF;
>   
> +	shost->host_tagset = 1;
> +

nit: any reason not to set the flag in the scsi_host_template instead?

>   	if (prot_mask >= 0)
>   		scsi_host_set_prot(shost, prot_mask);
>   	else {

Re: [PATCH 1/2] mpi3mr: Enable shared host tagset

[Sreekanth Reddy]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Tue, Jun 28, 2022 at 8:32 PM John Garry <john.garry@huawei.com> wrote:
>
> On 28/06/2022 08:48, Sreekanth Reddy wrote:
> > Enable shared host tagset to make sure that total outstanding
> > IOs count won't cross controller's can_queue.
> >
> > Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
> > ---
> >   drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
> > index d8c195b..da85eda 100644
> > --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
> > +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
> > @@ -4321,6 +4321,8 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >       shost->max_channel = 0;
> >       shost->max_id = 0xFFFFFFFF;
> >
> > +     shost->host_tagset = 1;
> > +
>
> nit: any reason not to set the flag in the scsi_host_template instead?

There is no specific reason. Please let me know if I need to repost
the patch with the host_tagset flag set in the scsi_host_template.

>
> >       if (prot_mask >= 0)
> >               scsi_host_set_prot(shost, prot_mask);
> >       else {
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH 1/2] mpi3mr: Enable shared host tagset

[John Garry]

On 28/06/2022 18:41, Sreekanth Reddy wrote:
> On Tue, Jun 28, 2022 at 8:32 PM John Garry <john.garry@huawei.com> wrote:
>>
>> On 28/06/2022 08:48, Sreekanth Reddy wrote:
>>> Enable shared host tagset to make sure that total outstanding
>>> IOs count won't cross controller's can_queue.
>>>
>>> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
>>> ---
>>>    drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
>>> index d8c195b..da85eda 100644
>>> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c
>>> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
>>> @@ -4321,6 +4321,8 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>>        shost->max_channel = 0;
>>>        shost->max_id = 0xFFFFFFFF;
>>>
>>> +     shost->host_tagset = 1;
>>> +
>>
>> nit: any reason not to set the flag in the scsi_host_template instead?
> 
> There is no specific reason. Please let me know if I need to repost
> the patch with the host_tagset flag set in the scsi_host_template.
> 

You don't need to repost just for me. I was just hinting that this can 
be set in the scsi_host_template, which is a bit neater.

Thanks,
John

>>
>>>        if (prot_mask >= 0)
>>>                scsi_host_set_prot(shost, prot_mask);
>>>        else {
>>

Re: [PATCH 0/2] mpi3mr: Use shared host tagset

[Martin K. Petersen]

Sreekanth,

> - Enabled the shared host tagset,
> - Also increased the cmd_per_lun to 128.

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/2] mpi3mr: Use shared host tagset

[Martin K. Petersen]

On Tue, 28 Jun 2022 13:18:46 +0530, Sreekanth Reddy wrote:

> - Enabled the shared host tagset,
> - Also increased the cmd_per_lun to 128.
> 
> Sreekanth Reddy (2):
>   mpi3mr: Enable shared host tagset
>   mpi3mr: Increase cmd_per_lun to 128
> 
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/2] mpi3mr: Enable shared host tagset
      https://git.kernel.org/mkp/scsi/c/465191d6526a
[2/2] mpi3mr: Increase cmd_per_lun to 128
      https://git.kernel.org/mkp/scsi/c/d29ea7b71621

-- 
Martin K. Petersen	Oracle Linux Engineering