* [PATCH] qla2xxx: Fix debugfs output for fw_resource_count
@ 2024-04-26 2:00 himanshu.madhani
2024-05-07 1:28 ` Martin K. Petersen
2024-05-11 18:39 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: himanshu.madhani @ 2024-04-26 2:00 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, martin.petersen, linux-scsi
From: Himanshu Madhani <himanshu.madhani@oracle.com>
DebugFS output for fw_resource_count shows:
estimate exchange used[0] high water limit [1945] n estimate iocb2 used [0] high water limit [5141]
estimate exchange2 used[0] high water limit [1945]
Which shows incorrect display due to missing newline in seq_print().
Fixes: 5f63a163ed2f1 ("scsi: qla2xxx: Fix exchange oversubscription for management commands")
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
drivers/scsi/qla2xxx/qla_dfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index 55ff3d7482b3..7375d00fe30f 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -274,7 +274,7 @@ qla_dfs_fw_resource_cnt_show(struct seq_file *s, void *unused)
seq_printf(s, "Driver: estimate iocb used [%d] high water limit [%d]\n",
iocbs_used, ha->base_qpair->fwres.iocbs_limit);
- seq_printf(s, "estimate exchange used[%d] high water limit [%d] n",
+ seq_printf(s, "estimate exchange used[%d] high water limit [%d] \n",
exch_used, ha->base_qpair->fwres.exch_limit);
if (ql2xenforce_iocb_limit == 2) {
--
2.41.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qla2xxx: Fix debugfs output for fw_resource_count
2024-04-26 2:00 [PATCH] qla2xxx: Fix debugfs output for fw_resource_count himanshu.madhani
@ 2024-05-07 1:28 ` Martin K. Petersen
2024-05-11 18:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-05-07 1:28 UTC (permalink / raw)
To: himanshu.madhani; +Cc: GR-QLogic-Storage-Upstream, martin.petersen, linux-scsi
Himanshu,
> DebugFS output for fw_resource_count shows:
>
> estimate exchange used[0] high water limit [1945] n estimate iocb2 used [0] high water limit [5141]
> estimate exchange2 used[0] high water limit [1945]
>
> Which shows incorrect display due to missing newline in seq_print().
Applied to 6.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qla2xxx: Fix debugfs output for fw_resource_count
2024-04-26 2:00 [PATCH] qla2xxx: Fix debugfs output for fw_resource_count himanshu.madhani
2024-05-07 1:28 ` Martin K. Petersen
@ 2024-05-11 18:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-05-11 18:39 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, linux-scsi, himanshu.madhani
Cc: Martin K . Petersen
On Fri, 26 Apr 2024 02:00:56 +0000, himanshu.madhani@oracle.com wrote:
> DebugFS output for fw_resource_count shows:
>
> estimate exchange used[0] high water limit [1945] n estimate iocb2 used [0] high water limit [5141]
> estimate exchange2 used[0] high water limit [1945]
>
> Which shows incorrect display due to missing newline in seq_print().
>
> [...]
Applied to 6.10/scsi-queue, thanks!
[1/1] qla2xxx: Fix debugfs output for fw_resource_count
https://git.kernel.org/mkp/scsi/c/998d09c5ef61
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-11 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26 2:00 [PATCH] qla2xxx: Fix debugfs output for fw_resource_count himanshu.madhani
2024-05-07 1:28 ` Martin K. Petersen
2024-05-11 18:39 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).