* [PATCH 0/2] qla2xxx: fixes for the driver
@ 2018-01-22 20:04 Himanshu Madhani
2018-01-22 20:04 ` [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd() Himanshu Madhani
2018-01-22 20:04 ` [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done() Himanshu Madhani
0 siblings, 2 replies; 7+ messages in thread
From: Himanshu Madhani @ 2018-01-22 20:04 UTC (permalink / raw)
To: James.Bottomley, martin.petersen; +Cc: himanshu.madhani, linux-scsi
Hi Martin,
This series has small fixes for the driver.
Please apply to 4.16/scsi-queue.
Thanks,
Himanshu
Himanshu Madhani (2):
qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()
qla2xxx: Fix logo flag for qlt_free_session_done()
drivers/scsi/qla2xxx/qla_init.c | 5 +++--
drivers/scsi/qla2xxx/qla_target.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.12.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()
2018-01-22 20:04 [PATCH 0/2] qla2xxx: fixes for the driver Himanshu Madhani
@ 2018-01-22 20:04 ` Himanshu Madhani
2018-01-23 1:04 ` Martin K. Petersen
2018-01-22 20:04 ` [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done() Himanshu Madhani
1 sibling, 1 reply; 7+ messages in thread
From: Himanshu Madhani @ 2018-01-22 20:04 UTC (permalink / raw)
To: James.Bottomley, martin.petersen; +Cc: himanshu.madhani, linux-scsi
This patch fixes following sparse warning
drivers/scsi/qla2xxx/qla_init.c:1570:44: sparse: incorrect type in assignment
(different base types)
Fixes: 07a21872cf2b ("scsi: qla2xxx: Fix queue ID for async abort with Multiqueue")
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
---
drivers/scsi/qla2xxx/qla_init.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 27e67f7ae18a..5b6f3c53fdcf 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -1567,9 +1567,10 @@ qla24xx_async_abort_cmd(srb_t *cmd_sp)
abt_iocb->u.abt.cmd_hndl = cmd_sp->handle;
if (vha->flags.qpairs_available && cmd_sp->qpair)
- abt_iocb->u.abt.req_que_no = cmd_sp->qpair->req->id;
+ abt_iocb->u.abt.req_que_no =
+ cpu_to_le16(cmd_sp->qpair->req->id);
else
- abt_iocb->u.abt.req_que_no = vha->req->id;
+ abt_iocb->u.abt.req_que_no = cpu_to_le16(vha->req->id);
sp->done = qla24xx_abort_sp_done;
abt_iocb->timeout = qla24xx_abort_iocb_timeout;
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done()
2018-01-22 20:04 [PATCH 0/2] qla2xxx: fixes for the driver Himanshu Madhani
2018-01-22 20:04 ` [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd() Himanshu Madhani
@ 2018-01-22 20:04 ` Himanshu Madhani
2018-01-23 1:08 ` Martin K. Petersen
1 sibling, 1 reply; 7+ messages in thread
From: Himanshu Madhani @ 2018-01-22 20:04 UTC (permalink / raw)
To: James.Bottomley, martin.petersen; +Cc: himanshu.madhani, linux-scsi
From: Himanshu Madhani <hmadhani@redhat.com>
Commit 3515832cc61467bfb87191a30401de1700e9956a fixed the target
re-login after session relogin is complete, but missed out the
qlt_free_session_done() path.
This patch clears send_els_logo flag in qlt_free_session_done() callback.
Fixes: 3515832cc614 ("scsi: qla2xxx: Reset the logo flag, after target re-login.")
Signed-off-by: Himanshu Madhani <hmadhani@redhat.com>
---
drivers/scsi/qla2xxx/qla_target.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index dd8edae4c152..14359656591e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -988,6 +988,7 @@ void qlt_free_session_done(struct work_struct *work)
logo.id = sess->d_id;
logo.cmd_count = 0;
+ sess->send_els_logo = 0;
qlt_send_first_logo(vha, &logo);
}
--
2.12.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd()
2018-01-22 20:04 ` [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd() Himanshu Madhani
@ 2018-01-23 1:04 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2018-01-23 1:04 UTC (permalink / raw)
To: Himanshu Madhani; +Cc: James.Bottomley, martin.petersen, linux-scsi
Himanshu,
> This patch fixes following sparse warning
>
> drivers/scsi/qla2xxx/qla_init.c:1570:44: sparse: incorrect type in assignment
> (different base types)
Amended the original commit. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done()
2018-01-22 20:04 ` [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done() Himanshu Madhani
@ 2018-01-23 1:08 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2018-01-23 1:08 UTC (permalink / raw)
To: Himanshu Madhani; +Cc: James.Bottomley, martin.petersen, linux-scsi
Himanshu,
> Commit 3515832cc61467bfb87191a30401de1700e9956a fixed the target
> re-login after session relogin is complete, but missed out the
> qlt_free_session_done() path.
>
> This patch clears send_els_logo flag in qlt_free_session_done() callback.
Applied to 4.16/scsi-queue. And please run checkpatch before sending.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] qla2xxx: Fixes for the driver
2019-10-22 19:36 [PATCH 0/2] qla2xxx: Fixes for the driver Himanshu Madhani
@ 2019-10-23 2:36 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2019-10-23 2:36 UTC (permalink / raw)
To: Himanshu Madhani; +Cc: James.Bottomley, martin.petersen, linux-scsi
Himanshu,
> This series has couple bug fixes for the driver.
>
> First patch addresses initialization error with the newer adapter on a
> blade systems.
>
> Second patch adds protection for accidental flash corruption using SysFS path.
Applied to 5.4/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/2] qla2xxx: Fixes for the driver
@ 2019-10-22 19:36 Himanshu Madhani
2019-10-23 2:36 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Himanshu Madhani @ 2019-10-22 19:36 UTC (permalink / raw)
To: James.Bottomley, martin.petersen; +Cc: hmadhani, linux-scsi
Hi Martin,
This series has couple bug fixes for the driver.
First patch addresses initialization error with the newer adapter on a
blade systems.
Second patch adds protection for accidental flash corruption using SysFS path.
Please apply them to 5.4/scsi-fixes branch for inclusion in 5.4-rc5.
Thanks,
Himanshu
Himanshu Madhani (1):
qla2xxx: Initialized mailbox to prevent driver load failure
Quinn Tran (1):
qla2xxx: Fix partial flash write of MBI
drivers/scsi/qla2xxx/qla_attr.c | 7 +++----
drivers/scsi/qla2xxx/qla_mbx.c | 3 ++-
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.12.0
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-23 2:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 20:04 [PATCH 0/2] qla2xxx: fixes for the driver Himanshu Madhani
2018-01-22 20:04 ` [PATCH 1/2] qla2xxx: Fix warning reported for req_que_no in qla24xx_async_cmd() Himanshu Madhani
2018-01-23 1:04 ` Martin K. Petersen
2018-01-22 20:04 ` [PATCH 2/2] qla2xxx: Fix logo flag for qlt_free_session_done() Himanshu Madhani
2018-01-23 1:08 ` Martin K. Petersen
2019-10-22 19:36 [PATCH 0/2] qla2xxx: Fixes for the driver Himanshu Madhani
2019-10-23 2:36 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).