* [PATCH] scsi: bfa: release allocated memory in case of error
@ 2019-09-10 23:44 Navid Emamdoost
2019-10-01 2:54 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Navid Emamdoost @ 2019-09-10 23:44 UTC (permalink / raw)
Cc: emamd001, smccaman, kjlu, Navid Emamdoost, Anil Gurumurthy,
Sudarsana Kalluru, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory
needs to be released.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/scsi/bfa/bfad_attr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfad_attr.c b/drivers/scsi/bfa/bfad_attr.c
index 29ab81df75c0..fbfce02e5b93 100644
--- a/drivers/scsi/bfa/bfad_attr.c
+++ b/drivers/scsi/bfa/bfad_attr.c
@@ -275,8 +275,10 @@ bfad_im_get_stats(struct Scsi_Host *shost)
rc = bfa_port_get_stats(BFA_FCPORT(&bfad->bfa),
fcstats, bfad_hcb_comp, &fcomp);
spin_unlock_irqrestore(&bfad->bfad_lock, flags);
- if (rc != BFA_STATUS_OK)
+ if (rc != BFA_STATUS_OK) {
+ kfree(fcstats);
return NULL;
+ }
wait_for_completion(&fcomp.comp);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] scsi: bfa: release allocated memory in case of error
2019-09-10 23:44 [PATCH] scsi: bfa: release allocated memory in case of error Navid Emamdoost
@ 2019-10-01 2:54 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-01 2:54 UTC (permalink / raw)
To: Navid Emamdoost
Cc: emamd001, smccaman, kjlu, Anil Gurumurthy, Sudarsana Kalluru,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Navid,
> In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory
> needs to be released.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-01 2:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 23:44 [PATCH] scsi: bfa: release allocated memory in case of error Navid Emamdoost
2019-10-01 2:54 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).