linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] scsi: bfa: Remove set but not used variable 'fchs'
@ 2020-04-18  7:10 YueHaibing
  2020-04-27 20:21 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-04-18  7:10 UTC (permalink / raw)
  To: Anil Gurumurthy, Sudarsana Kalluru, James E.J. Bottomley,
	Martin K. Petersen
  Cc: YueHaibing, linux-scsi, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/bfa/bfa_svc.c: In function 'uf_recv':
drivers/scsi/bfa/bfa_svc.c:5520:17: warning:
 variable 'fchs' set but not used [-Wunused-but-set-variable]
  struct fchs_s *fchs;
                 ^

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/scsi/bfa/bfa_svc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/bfa/bfa_svc.c b/drivers/scsi/bfa/bfa_svc.c
index d8a9e40fa257..0b7d2e8f4a66 100644
--- a/drivers/scsi/bfa/bfa_svc.c
+++ b/drivers/scsi/bfa/bfa_svc.c
@@ -5517,7 +5517,6 @@ uf_recv(struct bfa_s *bfa, struct bfi_uf_frm_rcvd_s *m)
 	struct bfa_uf_s *uf = &ufm->uf_list[uf_tag];
 	struct bfa_uf_buf_s *uf_buf;
 	uint8_t *buf;
-	struct fchs_s *fchs;
 
 	uf_buf = (struct bfa_uf_buf_s *)
 			bfa_mem_get_dmabuf_kva(ufm, uf_tag, uf->pb_len);
@@ -5526,8 +5525,6 @@ uf_recv(struct bfa_s *bfa, struct bfi_uf_frm_rcvd_s *m)
 	m->frm_len = be16_to_cpu(m->frm_len);
 	m->xfr_len = be16_to_cpu(m->xfr_len);
 
-	fchs = (struct fchs_s *)uf_buf;
-
 	list_del(&uf->qe);	/* dequeue from posted queue */
 
 	uf->data_ptr = buf;






^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] scsi: bfa: Remove set but not used variable 'fchs'
  2020-04-18  7:10 [PATCH -next] scsi: bfa: Remove set but not used variable 'fchs' YueHaibing
@ 2020-04-27 20:21 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-04-27 20:21 UTC (permalink / raw)
  To: YueHaibing, James E.J. Bottomley, Anil Gurumurthy, Sudarsana Kalluru
  Cc: Martin K . Petersen, kernel-janitors, linux-scsi

On Sat, 18 Apr 2020 07:10:57 +0000, YueHaibing wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/scsi/bfa/bfa_svc.c: In function 'uf_recv':
> drivers/scsi/bfa/bfa_svc.c:5520:17: warning:
>  variable 'fchs' set but not used [-Wunused-but-set-variable]
>   struct fchs_s *fchs;
>                  ^
> 
> [...]

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: bfa: Remove set but not used variable 'fchs'
      https://git.kernel.org/mkp/scsi/c/0745c834f793

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-27 20:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-18  7:10 [PATCH -next] scsi: bfa: Remove set but not used variable 'fchs' YueHaibing
2020-04-27 20:21 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).