* [PATCH] scsi: qedf: remove redundant initialization of variable rc
@ 2020-05-27 11:52 Colin King
2020-06-03 2:31 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-05-27 11:52 UTC (permalink / raw)
To: QLogic-Storage-Upstream, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable rc is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/qedf/qedf_fip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c
index bb82f0875eca..ad6a56ce72a8 100644
--- a/drivers/scsi/qedf/qedf_fip.c
+++ b/drivers/scsi/qedf/qedf_fip.c
@@ -20,7 +20,7 @@ void qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf)
#define MY_FIP_ALL_FCF_MACS ((__u8[6]) { 1, 0x10, 0x18, 1, 0, 2 })
static u8 my_fcoe_all_fcfs[ETH_ALEN] = MY_FIP_ALL_FCF_MACS;
unsigned long flags = 0;
- int rc = -1;
+ int rc;
skb = dev_alloc_skb(sizeof(struct fip_vlan));
if (!skb) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qedf: remove redundant initialization of variable rc
2020-05-27 11:52 [PATCH] scsi: qedf: remove redundant initialization of variable rc Colin King
@ 2020-06-03 2:31 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-06-03 2:31 UTC (permalink / raw)
To: QLogic-Storage-Upstream, linux-scsi, James E . J . Bottomley, Colin King
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Wed, 27 May 2020 12:52:42 +0100, Colin King wrote:
> The variable rc is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qedf: Remove redundant initialization of variable rc
https://git.kernel.org/mkp/scsi/c/89523cb8a67c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 11:52 [PATCH] scsi: qedf: remove redundant initialization of variable rc Colin King
2020-06-03 2:31 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).