* [PATCH -next] scsi: dpt_i2o: remove some not needed memset
@ 2020-07-18 12:32 Wang Hai
2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-07-18 12:32 UTC (permalink / raw)
To: aacraid, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
Fixes coccicheck warning:
./drivers/scsi/dpt_i2o.c:3070:11-29: WARNING:
dma_alloc_coherent use in sys_tbl already zeroes out memory, so memset is not needed
./drivers/scsi/dpt_i2o.c:2780:10-28: WARNING:
dma_alloc_coherent use in status already zeroes out memory, so memset is not needed
./drivers/scsi/dpt_i2o.c:2834:20-38: WARNING:
dma_alloc_coherent use in pHba -> reply_pool already zeroes out memory, so memset is not needed
./drivers/scsi/dpt_i2o.c:1328:10-28: WARNING:
dma_alloc_coherent use in status already zeroes out memory, so memset is not needed
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/scsi/dpt_i2o.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 0497ef6a9453..f654ad8a3d69 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -1331,7 +1331,6 @@ static s32 adpt_i2o_reset_hba(adpt_hba* pHba)
printk(KERN_ERR"IOP reset failed - no free memory.\n");
return -ENOMEM;
}
- memset(status,0,4);
msg[0]=EIGHT_WORD_MSG_SIZE|SGL_OFFSET_0;
msg[1]=I2O_CMD_ADAPTER_RESET<<24|HOST_TID<<12|ADAPTER_TID;
@@ -2784,7 +2783,6 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
pHba->name);
return -ENOMEM;
}
- memset(status, 0, 4);
writel(EIGHT_WORD_MSG_SIZE| SGL_OFFSET_6, &msg[0]);
writel(I2O_CMD_OUTBOUND_INIT<<24 | HOST_TID<<12 | ADAPTER_TID, &msg[1]);
@@ -2838,7 +2836,6 @@ static s32 adpt_i2o_init_outbound_q(adpt_hba* pHba)
printk(KERN_ERR "%s: Could not allocate reply pool\n", pHba->name);
return -ENOMEM;
}
- memset(pHba->reply_pool, 0 , pHba->reply_fifo_size * REPLY_FRAME_SIZE * 4);
for(i = 0; i < pHba->reply_fifo_size; i++) {
writel(pHba->reply_pool_pa + (i * REPLY_FRAME_SIZE * 4),
@@ -3073,7 +3070,6 @@ static int adpt_i2o_build_sys_table(void)
printk(KERN_WARNING "SysTab Set failed. Out of memory.\n");
return -ENOMEM;
}
- memset(sys_tbl, 0, sys_tbl_len);
sys_tbl->num_entries = hba_count;
sys_tbl->version = I2OVERSION;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: dpt_i2o: remove some not needed memset
2020-07-18 12:32 [PATCH -next] scsi: dpt_i2o: remove some not needed memset Wang Hai
@ 2020-07-25 2:50 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2020-07-25 2:50 UTC (permalink / raw)
To: jejb, Wang Hai, aacraid; +Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Sat, 18 Jul 2020 20:32:24 +0800, Wang Hai wrote:
> Fixes coccicheck warning:
>
> ./drivers/scsi/dpt_i2o.c:3070:11-29: WARNING:
> dma_alloc_coherent use in sys_tbl already zeroes out memory, so memset is not needed
> ./drivers/scsi/dpt_i2o.c:2780:10-28: WARNING:
> dma_alloc_coherent use in status already zeroes out memory, so memset is not needed
> ./drivers/scsi/dpt_i2o.c:2834:20-38: WARNING:
> dma_alloc_coherent use in pHba -> reply_pool already zeroes out memory, so memset is not needed
> ./drivers/scsi/dpt_i2o.c:1328:10-28: WARNING:
> dma_alloc_coherent use in status already zeroes out memory, so memset is not needed
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: dpt_i2o: Remove superfluous memset()
https://git.kernel.org/mkp/scsi/c/003015b890e1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 12:32 [PATCH -next] scsi: dpt_i2o: remove some not needed memset Wang Hai
2020-07-25 2:50 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).