* [PATCH] scsi: bnx2fc: move declaration of 'bnx2fc_percpu' to bnx2fc.h
@ 2020-09-21 14:26 Jason Yan
0 siblings, 0 replies; only message in thread
From: Jason Yan @ 2020-09-21 14:26 UTC (permalink / raw)
To: skashyap, jhasan, GR-QLogic-Storage-Upstream, jejb,
martin.petersen, linux-scsi
Cc: Jason Yan, Hulk Robot
This addresses the following sparse warning:
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:23:1: warning: symbol
'__pcpu_scope_bnx2fc_percpu' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/bnx2fc/bnx2fc.h | 2 ++
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
index b6e8ed757252..41b99a74613a 100644
--- a/drivers/scsi/bnx2fc/bnx2fc.h
+++ b/drivers/scsi/bnx2fc/bnx2fc.h
@@ -175,6 +175,8 @@ struct bnx2fc_percpu_s {
spinlock_t fp_work_lock;
};
+DECLARE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);
+
struct bnx2fc_fw_stats {
u64 fc_crc_cnt;
u64 fcoe_tx_pkt_cnt;
diff --git a/drivers/scsi/bnx2fc/bnx2fc_hwi.c b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
index 08992095ce7a..cee66fcf8dec 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c
@@ -15,8 +15,6 @@
#include "bnx2fc.h"
-DECLARE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);
-
static void bnx2fc_fastpath_notification(struct bnx2fc_hba *hba,
struct fcoe_kcqe *new_cqe_kcqe);
static void bnx2fc_process_ofld_cmpl(struct bnx2fc_hba *hba,
--
2.25.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-21 14:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 14:26 [PATCH] scsi: bnx2fc: move declaration of 'bnx2fc_percpu' to bnx2fc.h Jason Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).