* [PATCH 0/3] qedf misc bug fixes
@ 2022-01-17 13:53 Nilesh Javali
2022-01-17 13:53 ` [PATCH 1/3] qedf: Add stag_work to all the vports Nilesh Javali
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Nilesh Javali @ 2022-01-17 13:53 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, loberman, jpittman, GR-QLogic-Storage-Upstream
Martin,
Please apply the qedf driver misc bug fixes to the scsi tree
at your earliest convenience.
Thanks,
Nilesh
Saurav Kashyap (3):
qedf: Add stag_work to all the vports
qedf: Fix refcount issue when LOGO is received during TMF
qedf: Change context reset messages to ratelimited
drivers/scsi/qedf/qedf_io.c | 1 +
drivers/scsi/qedf/qedf_main.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
base-commit: 315d049ad1951cef02d9337a2469cac51cca6932
--
2.23.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] qedf: Add stag_work to all the vports
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
@ 2022-01-17 13:53 ` Nilesh Javali
2022-01-17 13:53 ` [PATCH 2/3] qedf: Fix refcount issue when LOGO is received during TMF Nilesh Javali
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nilesh Javali @ 2022-01-17 13:53 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, loberman, jpittman, GR-QLogic-Storage-Upstream
From: Saurav Kashyap <skashyap@marvell.com>
Call trace seen when creating NPIV ports, only 32 out of 64 show online.
stag work was not initialized for vport, hence initialize the stag work.
WARNING: CPU: 8 PID: 645 at kernel/workqueue.c:1635 __queue_delayed_work+0x68/0x80
CPU: 8 PID: 645 Comm: kworker/8:1 Kdump: loaded Tainted: G IOE --------- --
4.18.0-348.el8.x86_64 #1
Hardware name: Dell Inc. PowerEdge MX740c/0177V9, BIOS 2.12.2 07/09/2021
Workqueue: events fc_lport_timeout [libfc]
RIP: 0010:__queue_delayed_work+0x68/0x80
Code: 89 b2 88 00 00 00 44 89 82 90 00 00 00 48 01 c8 48 89 42 50 41 81
f8 00 20 00 00 75 1d e9 60 24 07 00 44 89 c7 e9 98 f6 ff ff <0f> 0b eb
c5 0f 0b eb a1 0f 0b eb a7 0f 0b eb ac 44 89 c6 e9 40 23
RSP: 0018:ffffae514bc3be40 EFLAGS: 00010006
RAX: ffff8d25d6143750 RBX: 0000000000000202 RCX: 0000000000000002
RDX: ffff8d2e31383748 RSI: ffff8d25c000d600 RDI: ffff8d2e31383788
RBP: ffff8d2e31380de0 R08: 0000000000002000 R09: ffff8d2e31383750
R10: ffffffffc0c957e0 R11: ffff8d2624800000 R12: ffff8d2e31380a58
R13: ffff8d2d915eb000 R14: ffff8d25c499b5c0 R15: ffff8d2e31380e18
FS: 0000000000000000(0000) GS:ffff8d2d1fb00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055fd0484b8b8 CR3: 00000008ffc10006 CR4: 00000000007706e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
queue_delayed_work_on+0x36/0x40
qedf_elsct_send+0x57/0x60 [qedf]
fc_lport_enter_flogi+0x90/0xc0 [libfc]
fc_lport_timeout+0xb7/0x140 [libfc]
process_one_work+0x1a7/0x360
? create_worker+0x1a0/0x1a0
worker_thread+0x30/0x390
? create_worker+0x1a0/0x1a0
kthread+0x116/0x130
? kthread_flush_work_fn+0x10/0x10
ret_from_fork+0x35/0x40
---[ end trace 008f00f722f2c2ff ]--
Initialize stag work for all the vports.
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
drivers/scsi/qedf/qedf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index cdc66e2a9488..3a5ce540cfc4 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -1864,6 +1864,7 @@ static int qedf_vport_create(struct fc_vport *vport, bool disabled)
vport_qedf->cmd_mgr = base_qedf->cmd_mgr;
init_completion(&vport_qedf->flogi_compl);
INIT_LIST_HEAD(&vport_qedf->fcports);
+ INIT_DELAYED_WORK(&vport_qedf->stag_work, qedf_stag_change_work);
rc = qedf_vport_libfc_config(vport, vn_port);
if (rc) {
--
2.23.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] qedf: Fix refcount issue when LOGO is received during TMF
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
2022-01-17 13:53 ` [PATCH 1/3] qedf: Add stag_work to all the vports Nilesh Javali
@ 2022-01-17 13:53 ` Nilesh Javali
2022-01-17 13:53 ` [PATCH 3/3] qedf: Change context reset messages to ratelimited Nilesh Javali
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Nilesh Javali @ 2022-01-17 13:53 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, loberman, jpittman, GR-QLogic-Storage-Upstream
From: Saurav Kashyap <skashyap@marvell.com>
Hung task call trace was seen during LOGO processing.
[ 974.309060] [0000:00:00.0]:[qedf_eh_device_reset:868]: 1:0:2:0: LUN RESET Issued...
[ 974.309065] [0000:00:00.0]:[qedf_initiate_tmf:2422]: tm_flags 0x10 sc_cmd 00000000c16b930f op = 0x2a target_id = 0x2 lun=0
[ 974.309178] [0000:00:00.0]:[qedf_initiate_tmf:2431]: portid=016900 tm_flags =LUN RESET
[ 974.309222] [0000:00:00.0]:[qedf_initiate_tmf:2438]: orig io_req = 00000000ec78df8f xid = 0x180 ref_cnt = 1.
[ 974.309625] host1: rport 016900: Received LOGO request while in state Ready
[ 974.309627] host1: rport 016900: Delete port
[ 974.309642] host1: rport 016900: work event 3
[ 974.309644] host1: rport 016900: lld callback ev 3
[ 974.313243] [0000:61:00.2]:[qedf_execute_tmf:2383]:1: fcport is uploading, not executing flush.
[ 974.313295] [0000:61:00.2]:[qedf_execute_tmf:2400]:1: task mgmt command success...
[ 984.031088] INFO: task jbd2/dm-15-8:7645 blocked for more than 120 seconds.
[ 984.031136] Not tainted 4.18.0-305.el8.x86_64 #1
[ 984.031166] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 984.031209] jbd2/dm-15-8 D 0 7645 2 0x80004080
[ 984.031212] Call Trace:
[ 984.031222] __schedule+0x2c4/0x700
[ 984.031230] ? unfreeze_partials.isra.83+0x16e/0x1a0
[ 984.031233] ? bit_wait_timeout+0x90/0x90
[ 984.031235] schedule+0x38/0xa0
[ 984.031238] io_schedule+0x12/0x40
[ 984.031240] bit_wait_io+0xd/0x50
[ 984.031243] __wait_on_bit+0x6c/0x80
[ 984.031248] ? free_buffer_head+0x21/0x50
[ 984.031251] out_of_line_wait_on_bit+0x91/0xb0
[ 984.031257] ? init_wait_var_entry+0x50/0x50
[ 984.031268] jbd2_journal_commit_transaction+0x112e/0x19f0 [jbd2]
[ 984.031280] kjournald2+0xbd/0x270 [jbd2]
[ 984.031284] ? finish_wait+0x80/0x80
[ 984.031291] ? commit_timeout+0x10/0x10 [jbd2]
[ 984.031294] kthread+0x116/0x130
[ 984.031300] ? kthread_flush_work_fn+0x10/0x10
[ 984.031305] ret_from_fork+0x1f/0x40
There was a ref count issue when LOGO is received during TMF.
This leads to one of the IO hanging with the driver.
Fix the ref count.
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
drivers/scsi/qedf/qedf_io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index 99a56ca1fb16..fab43dabe5b3 100644
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -2250,6 +2250,7 @@ int qedf_initiate_cleanup(struct qedf_ioreq *io_req,
io_req->tm_flags == FCP_TMF_TGT_RESET) {
clear_bit(QEDF_CMD_OUTSTANDING, &io_req->flags);
io_req->sc_cmd = NULL;
+ kref_put(&io_req->refcount, qedf_release_cmd);
complete(&io_req->tm_done);
}
--
2.23.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] qedf: Change context reset messages to ratelimited
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
2022-01-17 13:53 ` [PATCH 1/3] qedf: Add stag_work to all the vports Nilesh Javali
2022-01-17 13:53 ` [PATCH 2/3] qedf: Fix refcount issue when LOGO is received during TMF Nilesh Javali
@ 2022-01-17 13:53 ` Nilesh Javali
2022-01-19 3:39 ` [PATCH 0/3] qedf misc bug fixes Martin K. Petersen
2022-01-25 5:40 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Nilesh Javali @ 2022-01-17 13:53 UTC (permalink / raw)
To: martin.petersen
Cc: linux-scsi, loberman, jpittman, GR-QLogic-Storage-Upstream
From: Saurav Kashyap <skashyap@marvell.com>
If FCoE is not configured, libfc/libfcoe keeps on retrying FLOGI and
after 3 retries driver does a context reset and tries fipvlan again.
This leads to context reset message flooding the logs. Hence
ratelimit the message to prevent flooding the logs.
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
drivers/scsi/qedf/qedf_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 3a5ce540cfc4..6ad28bc8e948 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -911,7 +911,7 @@ void qedf_ctx_soft_reset(struct fc_lport *lport)
struct qed_link_output if_link;
if (lport->vport) {
- QEDF_ERR(NULL, "Cannot issue host reset on NPIV port.\n");
+ printk_ratelimited("Cannot issue host reset on NPIV port.\n");
return;
}
@@ -3981,7 +3981,9 @@ void qedf_stag_change_work(struct work_struct *work)
struct qedf_ctx *qedf =
container_of(work, struct qedf_ctx, stag_work.work);
- QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
+ printk_ratelimited("[%s]:[%s:%d]:%d: Performing software context reset.",
+ dev_name(&qedf->pdev->dev), __func__, __LINE__,
+ qedf->dbg_ctx.host_no);
qedf_ctx_soft_reset(qedf->lport);
}
--
2.23.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] qedf misc bug fixes
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
` (2 preceding siblings ...)
2022-01-17 13:53 ` [PATCH 3/3] qedf: Change context reset messages to ratelimited Nilesh Javali
@ 2022-01-19 3:39 ` Martin K. Petersen
2022-01-25 5:40 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-01-19 3:39 UTC (permalink / raw)
To: Nilesh Javali
Cc: martin.petersen, linux-scsi, loberman, jpittman,
GR-QLogic-Storage-Upstream
Nilesh,
> Please apply the qedf driver misc bug fixes to the scsi tree at your
> earliest convenience.
Applied to 5.17/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] qedf misc bug fixes
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
` (3 preceding siblings ...)
2022-01-19 3:39 ` [PATCH 0/3] qedf misc bug fixes Martin K. Petersen
@ 2022-01-25 5:40 ` Martin K. Petersen
4 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-01-25 5:40 UTC (permalink / raw)
To: Nilesh Javali
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, loberman,
linux-scsi, jpittman
On Mon, 17 Jan 2022 05:53:08 -0800, Nilesh Javali wrote:
> Martin,
>
> Please apply the qedf driver misc bug fixes to the scsi tree
> at your earliest convenience.
>
> Thanks,
> Nilesh
>
> [...]
Applied to 5.17/scsi-fixes, thanks!
[1/3] qedf: Add stag_work to all the vports
https://git.kernel.org/mkp/scsi/c/b70a99fd1328
[2/3] qedf: Fix refcount issue when LOGO is received during TMF
https://git.kernel.org/mkp/scsi/c/5239ab63f17c
[3/3] qedf: Change context reset messages to ratelimited
https://git.kernel.org/mkp/scsi/c/64fd4af6274e
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-25 5:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17 13:53 [PATCH 0/3] qedf misc bug fixes Nilesh Javali
2022-01-17 13:53 ` [PATCH 1/3] qedf: Add stag_work to all the vports Nilesh Javali
2022-01-17 13:53 ` [PATCH 2/3] qedf: Fix refcount issue when LOGO is received during TMF Nilesh Javali
2022-01-17 13:53 ` [PATCH 3/3] qedf: Change context reset messages to ratelimited Nilesh Javali
2022-01-19 3:39 ` [PATCH 0/3] qedf misc bug fixes Martin K. Petersen
2022-01-25 5:40 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).