* [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS
@ 2023-03-17 17:51 Danila Chernetsov
2023-04-03 2:15 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Danila Chernetsov @ 2023-03-17 17:51 UTC (permalink / raw)
To: Kashyap Desai
Cc: Danila Chernetsov, Sumit Saxena, Shivasharan S,
James E.J. Bottomley, Martin K. Petersen, megaraidlinux.pdl,
linux-scsi, linux-kernel, lvc-project
When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is dereferenced below.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 0f2bb84d2a68 ("[SCSI] megaraid: simplify internal command handling")
Signed-off-by: Danila Chernetsov <listdansp@mail.ru>
---
drivers/scsi/megaraid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index bf491af9f0d6..16e2cf848c6e 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -1441,6 +1441,7 @@ mega_cmd_done(adapter_t *adapter, u8 completed[], int nstatus, int status)
*/
if (cmdid == CMDID_INT_CMDS) {
scb = &adapter->int_scb;
+ cmd = scb->cmd;
list_del_init(&scb->list);
scb->state = SCB_FREE;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS
2023-03-17 17:51 [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS Danila Chernetsov
@ 2023-04-03 2:15 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2023-04-03 2:15 UTC (permalink / raw)
To: Kashyap Desai, Danila Chernetsov
Cc: Martin K . Petersen, Sumit Saxena, Shivasharan S,
James E.J. Bottomley, megaraidlinux.pdl, linux-scsi,
linux-kernel, lvc-project
On Fri, 17 Mar 2023 17:51:09 +0000, Danila Chernetsov wrote:
> When cmdid == CMDID_INT_CMDS, the 'cmds' pointer is NULL but is dereferenced below.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>
Applied to 6.4/scsi-queue, thanks!
[1/1] megaraid: fix mega_cmd_done CMDID_INT_CMDS
https://git.kernel.org/mkp/scsi/c/75cb113cd43f
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-03 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-17 17:51 [PATCH] megaraid: fix mega_cmd_done CMDID_INT_CMDS Danila Chernetsov
2023-04-03 2:15 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).