From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Yu Kuai <yukuai1@huaweicloud.com>, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Ming Lei <ming.lei@redhat.com>, Keith Busch <kbusch@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ed Tsai <ed.tsai@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v6 1/4] block: Make fair tag sharing configurable
Date: Thu, 18 Jan 2024 08:31:51 +0100 [thread overview]
Message-ID: <20240118073151.GA21386@lst.de> (raw)
In-Reply-To: <aedc82bc-ef10-4bc6-b76c-bf239f48450f@acm.org>
On Tue, Jan 16, 2024 at 09:36:27AM -0800, Bart Van Assche wrote:
> My concern is that the complexity of the algorithm introduced by that patch
> series is significant. I prefer code that is easy to understand. This is why
> I haven't started yet with a detailed review. If anyone else wants to review
> that patch series that's fine with me.
Given that simply disabling fair sharing isn't going to fly we'll need
something more complex than that.
The question is how much complexity do we need, and for that it would
be good to collect the use cases first.
next prev parent reply other threads:[~2024-01-18 7:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 19:31 [PATCH v6 0/6] Disable fair tag sharing for UFS devices Bart Van Assche
2023-11-30 19:31 ` [PATCH v6 1/4] block: Make fair tag sharing configurable Bart Van Assche
2023-12-01 12:52 ` Johannes Thumshirn
2023-12-01 22:14 ` Bart Van Assche
2023-12-02 7:21 ` Yu Kuai
2023-12-04 4:13 ` Bart Van Assche
2023-12-25 12:51 ` Yu Kuai
2023-12-26 2:22 ` Bart Van Assche
2024-01-11 19:22 ` Bart Van Assche
2024-01-12 1:08 ` Yu Kuai
2024-01-12 4:39 ` Christoph Hellwig
2024-01-14 3:22 ` Yu Kuai
2024-01-15 5:59 ` Christoph Hellwig
2024-01-15 6:18 ` Yu Kuai
2024-01-16 2:59 ` Bart Van Assche
2024-01-16 10:24 ` Yu Kuai
2024-01-16 17:36 ` Bart Van Assche
2024-01-18 7:31 ` Christoph Hellwig [this message]
2024-01-18 18:40 ` Bart Van Assche
2024-01-23 9:13 ` Christoph Hellwig
2024-01-23 15:16 ` Bart Van Assche
2024-01-24 9:08 ` Christoph Hellwig
2024-01-30 0:03 ` Bart Van Assche
2024-01-31 6:22 ` Christoph Hellwig
2024-01-31 21:32 ` Bart Van Assche
2024-01-31 21:37 ` Keith Busch
2024-01-31 21:42 ` Bart Van Assche
2024-01-31 23:04 ` Keith Busch
2024-01-31 23:41 ` Bart Van Assche
2024-01-31 23:52 ` Damien Le Moal
2024-01-16 2:52 ` Bart Van Assche
2023-11-30 19:31 ` [PATCH v6 2/4] scsi: core: Make fair tag sharing configurable in the host template Bart Van Assche
2023-11-30 19:31 ` [PATCH v6 3/4] scsi: core: Make fair tag sharing configurable via sysfs Bart Van Assche
2023-11-30 19:31 ` [PATCH v6 4/4] scsi: ufs: Disable fair tag sharing Bart Van Assche
2023-12-04 7:52 ` [PATCH v6 0/6] Disable fair tag sharing for UFS devices Christoph Hellwig
2023-12-05 3:15 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118073151.GA21386@lst.de \
--to=hch@lst.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ed.tsai@mediatek.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=ming.lei@redhat.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).