From: John Garry <john.garry@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <lenb@kernel.org>,
<rjw@rjwysocki.net>, <gregkh@linuxfoundation.org>,
<maz@kernel.org>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <linux-acpi@vger.kernel.org>,
<dwagner@suse.de>
Subject: Re: [PATCH v4 1/5] genirq/affinity: Add irq_update_affinity_desc()
Date: Tue, 1 Dec 2020 15:22:38 +0000 [thread overview]
Message-ID: <22315d74-0696-85ef-882c-85961cfb4f32@huawei.com> (raw)
In-Reply-To: <87y2iih1pv.fsf@nanos.tec.linutronix.de>
Hi Thomas,
I'll go with something extra like:
>
>> Add a function to allow the affinity of an interrupt be switched to
>> managed, such that interrupts allocated for platform devices may be
>> managed.
>
> Could you please add a paragraph which explains the limitations of that
> interface?
This new interface has certain limitations, and attempts to use it in
the following circumstances will fail:
- For when the kernel is configured for generic IRQ reservation mode (in
config GENERIC_IRQ_RESERVATION_MODE). The reason being that it could
conflict with managed vs. non-managed interrupt accounting there.
- The interrupt is already started, which should not be the case during init
- The interrupt is already configured as managed, which means double init
>
>> +/**
>> + * irq_update_affinity_desc - Update affinity management for an interrupt
>> + * @irq: The interrupt number to update
>> + * @affinity: Pointer to the affinity descriptor
>> + *
>> + * This interface can be used to configure the affinity management of
>> + * interrupts which have been allocated already.
>
/*
* There are certain limitations on when it may be used - attempts to
use it for when the kernel is configured for generic IRQ reservation
mode (in config GENERIC_IRQ_RESERVATION_MODE) will fail, as it may
conflict with managed/non-managed interrupt accounting. In addition,
attempts to use it on an interrupt which is already started or which has
already been configured as managed will also fail, as these mean invalid
init state or double init.
...
Let me know if not good, if not I'll post again soon.
Thanks,
John
next prev parent reply other threads:[~2020-12-01 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:35 [PATCH v4 0/5] Support managed interrupts for platform devices John Garry
2020-11-30 17:35 ` [PATCH v4 1/5] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-11-30 23:19 ` Thomas Gleixner
2020-12-01 15:22 ` John Garry [this message]
2020-12-01 17:28 ` Thomas Gleixner
2020-11-30 17:35 ` [PATCH v4 2/5] resource: Add irqresource_disabled() John Garry
2020-12-01 19:02 ` Rafael J. Wysocki
2020-11-30 17:35 ` [PATCH v4 3/5] ACPI: Drop acpi_dev_irqresource_disabled() John Garry
2020-12-01 19:01 ` Rafael J. Wysocki
2020-11-30 17:35 ` [PATCH v4 4/5] Driver core: platform: Add devm_platform_get_irqs_affinity() John Garry
2020-11-30 17:35 ` [PATCH v4 5/5] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22315d74-0696-85ef-882c-85961cfb4f32@huawei.com \
--to=john.garry@huawei.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).