From: "Rafael J. Wysocki" <rafael@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
dwagner@suse.de
Subject: Re: [PATCH v4 3/5] ACPI: Drop acpi_dev_irqresource_disabled()
Date: Tue, 1 Dec 2020 20:01:39 +0100 [thread overview]
Message-ID: <CAJZ5v0gnwJ37rzi_+FMB-eN1OAW0n86pYN8FWa_Tc4eWvjNv-Q@mail.gmail.com> (raw)
In-Reply-To: <1606757759-6076-4-git-send-email-john.garry@huawei.com>
On Mon, Nov 30, 2020 at 6:41 PM John Garry <john.garry@huawei.com> wrote:
>
> The functionality of acpi_dev_irqresource_disabled() is same as in common
> irqresource_disabled(), so drop acpi_dev_irqresource_disabled() in favour
> of that function.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/acpi/resource.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index ad04824ca3ba..58203193417e 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -380,13 +380,6 @@ unsigned int acpi_dev_get_irq_type(int triggering, int polarity)
> }
> EXPORT_SYMBOL_GPL(acpi_dev_get_irq_type);
>
> -static void acpi_dev_irqresource_disabled(struct resource *res, u32 gsi)
> -{
> - res->start = gsi;
> - res->end = gsi;
> - res->flags = IORESOURCE_IRQ | IORESOURCE_DISABLED | IORESOURCE_UNSET;
> -}
> -
> static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
> u8 triggering, u8 polarity, u8 shareable,
> bool legacy)
> @@ -394,7 +387,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
> int irq, p, t;
>
> if (!valid_IRQ(gsi)) {
> - acpi_dev_irqresource_disabled(res, gsi);
> + irqresource_disabled(res, gsi);
> return;
> }
>
> @@ -426,7 +419,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
> res->start = irq;
> res->end = irq;
> } else {
> - acpi_dev_irqresource_disabled(res, gsi);
> + irqresource_disabled(res, gsi);
> }
> }
>
> @@ -463,7 +456,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
> */
> irq = &ares->data.irq;
> if (index >= irq->interrupt_count) {
> - acpi_dev_irqresource_disabled(res, 0);
> + irqresource_disabled(res, 0);
> return false;
> }
> acpi_dev_get_irqresource(res, irq->interrupts[index],
> @@ -473,7 +466,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
> case ACPI_RESOURCE_TYPE_EXTENDED_IRQ:
> ext_irq = &ares->data.extended_irq;
> if (index >= ext_irq->interrupt_count) {
> - acpi_dev_irqresource_disabled(res, 0);
> + irqresource_disabled(res, 0);
> return false;
> }
> if (is_gsi(ext_irq))
> @@ -481,7 +474,7 @@ bool acpi_dev_resource_interrupt(struct acpi_resource *ares, int index,
> ext_irq->triggering, ext_irq->polarity,
> ext_irq->shareable, false);
> else
> - acpi_dev_irqresource_disabled(res, 0);
> + irqresource_disabled(res, 0);
> break;
> default:
> res->flags = 0;
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-12-01 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:35 [PATCH v4 0/5] Support managed interrupts for platform devices John Garry
2020-11-30 17:35 ` [PATCH v4 1/5] genirq/affinity: Add irq_update_affinity_desc() John Garry
2020-11-30 23:19 ` Thomas Gleixner
2020-12-01 15:22 ` John Garry
2020-12-01 17:28 ` Thomas Gleixner
2020-11-30 17:35 ` [PATCH v4 2/5] resource: Add irqresource_disabled() John Garry
2020-12-01 19:02 ` Rafael J. Wysocki
2020-11-30 17:35 ` [PATCH v4 3/5] ACPI: Drop acpi_dev_irqresource_disabled() John Garry
2020-12-01 19:01 ` Rafael J. Wysocki [this message]
2020-11-30 17:35 ` [PATCH v4 4/5] Driver core: platform: Add devm_platform_get_irqs_affinity() John Garry
2020-11-30 17:35 ` [PATCH v4 5/5] scsi: hisi_sas: Expose HW queues for v2 hw John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gnwJ37rzi_+FMB-eN1OAW0n86pYN8FWa_Tc4eWvjNv-Q@mail.gmail.com \
--to=rafael@kernel.org \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).