* Re: linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c)
[not found] <20200707180800.549b561b@canb.auug.org.au>
@ 2020-07-07 17:09 ` Randy Dunlap
2020-07-07 18:12 ` James Smart
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-07-07 17:09 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-scsi, James Smart, dick kennedy
On 7/7/20 1:08 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20200706:
>
on i386:
when CONFIG_ACPI is not set/enabled:
../drivers/scsi/lpfc/lpfc_init.c:1265:15: error: implicit declaration of function 'get_cpu_idle_time'; did you mean 'get_cpu_device'? [-Werror=implicit-function-declaration]
The cpufreq people want justification for using
get_cpu_idle_time(). Please see
https://lore.kernel.org/linux-scsi/20200707030943.xkocccy6qy2c3hrx@vireshk-i7/
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c)
2020-07-07 17:09 ` linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c) Randy Dunlap
@ 2020-07-07 18:12 ` James Smart
2020-07-08 2:46 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: James Smart @ 2020-07-07 18:12 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-scsi, dick kennedy
On 7/7/2020 10:09 AM, Randy Dunlap wrote:
> On 7/7/20 1:08 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20200706:
>>
> on i386:
>
> when CONFIG_ACPI is not set/enabled:
>
>
> ../drivers/scsi/lpfc/lpfc_init.c:1265:15: error: implicit declaration of function 'get_cpu_idle_time'; did you mean 'get_cpu_device'? [-Werror=implicit-function-declaration]
>
>
> The cpufreq people want justification for using
> get_cpu_idle_time(). Please see
> https://lore.kernel.org/linux-scsi/20200707030943.xkocccy6qy2c3hrx@vireshk-i7/
>
>
>
The driver is using cpu utilization in order to choose between softirq
or work queues in handling an interrupt. Less-utilized, softirq is used.
higher utilized, work queue is used. The utilization is checked
periodically via a heartbeat.
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c)
2020-07-07 18:12 ` James Smart
@ 2020-07-08 2:46 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2020-07-08 2:46 UTC (permalink / raw)
To: James Smart
Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-scsi, dick kennedy,
Rafael J. Wysocki
Hi James,
On Tue, Jul 7, 2020 at 11:43 PM James Smart <james.smart@broadcom.com> wrote:
>
> On 7/7/2020 10:09 AM, Randy Dunlap wrote:
> > On 7/7/20 1:08 AM, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Changes since 20200706:
> >>
> > on i386:
> >
> > when CONFIG_ACPI is not set/enabled:
> >
> >
> > ../drivers/scsi/lpfc/lpfc_init.c:1265:15: error: implicit declaration of function 'get_cpu_idle_time'; did you mean 'get_cpu_device'? [-Werror=implicit-function-declaration]
> >
> >
> > The cpufreq people want justification for using
I am one of cpufreq people :)
> > get_cpu_idle_time(). Please see
> > https://lore.kernel.org/linux-scsi/20200707030943.xkocccy6qy2c3hrx@vireshk-i7/
> >
>
> The driver is using cpu utilization in order to choose between softirq
> or work queues in handling an interrupt. Less-utilized, softirq is used.
> higher utilized, work queue is used. The utilization is checked
> periodically via a heartbeat.
I understand that you need to use this functionality, what I was
rather asking was
why do you need to use a routine that is for cpufreq related stuff only.
I also see that drivers/macintosh/rack-meter.c has its own
implementation for this.
What I would suggest is that, if required, we should add/move a
generic implementation
of this to another file (which is available to all) and then let
everyone use it.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-08 2:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200707180800.549b561b@canb.auug.org.au>
2020-07-07 17:09 ` linux-next: Tree for Jul 7 (scsi/lpfc/lpfc_init.c) Randy Dunlap
2020-07-07 18:12 ` James Smart
2020-07-08 2:46 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).