From: Shyam S <born27thfeb@gmail.com>
To: James Smart <james.smart@broadcom.com>
Cc: Nilesh Javali <njavali@marvell.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 2/3] qla2xxx: SAN congestion management(SCM) implementation.
Date: Thu, 11 Jun 2020 11:10:16 -0700 [thread overview]
Message-ID: <CA+ihqdi2oQVW7Nks3wfvN=KVhtNNhJg2yeCxZMgKt-t-qc36qw@mail.gmail.com> (raw)
In-Reply-To: <CA+ihqdjtoA=1q7N0pg1TQDAMGo1XtNN8+XnO1qXORyqGYfpq=A@mail.gmail.com>
Resending to the reflector.
On Mon, May 18, 2020 at 4:25 PM Shyam S <born27thfeb@gmail.com> wrote:
>
>
>>
>>
>> > Q: what purpose are these shorter "meta" event structures serving ? Why
>> > hold onto (what I assume is) the last event. Wouldn't something
>> > monitoring netlink and use of the existing fc_host_fpin_rcv() interface
>> > be enough ? it should see all events.
>
>
> The Idea was to be able to have a longer term view within the driver so that while debugging issues, correlations can be made between symptoms exhibited by the driver with these statistics.
>
> All your other comments make complete sense to me. I'll re-work the changes to move them up the stack.
>
>
> Regards
> Shyam
next prev parent reply other threads:[~2020-06-11 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 10:10 [PATCH 0/3] qla2xxx SAN Congestion Management (SCM) support Nilesh Javali
2020-05-14 10:10 ` [PATCH 1/3] qla2xxx: Change in PUREX to handle FPIN ELS requests Nilesh Javali
2020-05-14 17:03 ` himanshu.madhani
2020-05-15 18:52 ` James Smart
2020-05-14 10:10 ` [PATCH 2/3] qla2xxx: SAN congestion management(SCM) implementation Nilesh Javali
2020-05-14 18:52 ` himanshu.madhani
2020-05-15 22:48 ` James Smart
[not found] ` <CA+ihqdiA7AN05k5MjPG=o8_pf=L-La6UigY4t0emKgJMXm=hnQ@mail.gmail.com>
[not found] ` <BYAPR18MB2805AEA357302FCFA20D2B57B48F0@BYAPR18MB2805.namprd18.prod.outlook.com>
2020-06-11 17:42 ` Shyam Sundar
2020-06-25 23:25 ` James Smart
2020-06-26 0:14 ` Shyam Sundar
2020-07-30 16:10 ` Shyam Sundar
2020-09-21 17:48 ` James Smart
[not found] ` <CA+ihqdjtoA=1q7N0pg1TQDAMGo1XtNN8+XnO1qXORyqGYfpq=A@mail.gmail.com>
2020-06-11 18:10 ` Shyam S [this message]
2020-05-14 10:10 ` [PATCH 3/3] qla2xxx: Pass SCM counters to the application Nilesh Javali
2020-05-14 19:15 ` himanshu.madhani
2020-05-14 14:11 ` [PATCH 0/3] qla2xxx SAN Congestion Management (SCM) support Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ihqdi2oQVW7Nks3wfvN=KVhtNNhJg2yeCxZMgKt-t-qc36qw@mail.gmail.com' \
--to=born27thfeb@gmail.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=james.smart@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).