* [PATCH] scsi: megaraid: make smp_affinity_enable static
@ 2020-09-15 8:39 Jason Yan
2020-09-15 9:22 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jason Yan @ 2020-09-15 8:39 UTC (permalink / raw)
To: kashyap.desai, sumit.saxena, shivasharan.srikanteshwara, jejb,
martin.petersen, damien.lemoal, megaraidlinux.pdl, linux-scsi
Cc: Jason Yan, Hulk Robot
This addresses the following sparse warning:
drivers/scsi/megaraid/megaraid_sas_base.c:80:5: warning: symbol
'smp_affinity_enable' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 2b7e7b5f38ed..e158d3d62056 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -77,7 +77,7 @@ unsigned int resetwaittime = MEGASAS_RESET_WAIT_TIME;
module_param(resetwaittime, int, 0444);
MODULE_PARM_DESC(resetwaittime, "Wait time in (1-180s) after I/O timeout before resetting adapter. Default: 180s");
-int smp_affinity_enable = 1;
+static int smp_affinity_enable = 1;
module_param(smp_affinity_enable, int, 0444);
MODULE_PARM_DESC(smp_affinity_enable, "SMP affinity feature enable/disable Default: enable(1)");
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: megaraid: make smp_affinity_enable static
2020-09-15 8:39 [PATCH] scsi: megaraid: make smp_affinity_enable static Jason Yan
@ 2020-09-15 9:22 ` Damien Le Moal
2020-09-15 22:08 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2020-09-15 9:22 UTC (permalink / raw)
To: Jason Yan, kashyap.desai, sumit.saxena,
shivasharan.srikanteshwara, jejb, martin.petersen,
megaraidlinux.pdl, linux-scsi
Cc: Hulk Robot
On 2020/09/15 17:38, Jason Yan wrote:
> This addresses the following sparse warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c:80:5: warning: symbol
> 'smp_affinity_enable' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 2b7e7b5f38ed..e158d3d62056 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -77,7 +77,7 @@ unsigned int resetwaittime = MEGASAS_RESET_WAIT_TIME;
> module_param(resetwaittime, int, 0444);
> MODULE_PARM_DESC(resetwaittime, "Wait time in (1-180s) after I/O timeout before resetting adapter. Default: 180s");
>
> -int smp_affinity_enable = 1;
> +static int smp_affinity_enable = 1;
> module_param(smp_affinity_enable, int, 0444);
> MODULE_PARM_DESC(smp_affinity_enable, "SMP affinity feature enable/disable Default: enable(1)");
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: megaraid: make smp_affinity_enable static
2020-09-15 8:39 [PATCH] scsi: megaraid: make smp_affinity_enable static Jason Yan
2020-09-15 9:22 ` Damien Le Moal
@ 2020-09-15 22:08 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-15 22:08 UTC (permalink / raw)
To: Jason Yan
Cc: kashyap.desai, sumit.saxena, shivasharan.srikanteshwara, jejb,
martin.petersen, damien.lemoal, megaraidlinux.pdl, linux-scsi,
Hulk Robot
Jason,
> This addresses the following sparse warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c:80:5: warning: symbol
> 'smp_affinity_enable' was not declared. Should it be static?
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: megaraid: make smp_affinity_enable static
2020-09-15 8:39 [PATCH] scsi: megaraid: make smp_affinity_enable static Jason Yan
2020-09-15 9:22 ` Damien Le Moal
2020-09-15 22:08 ` Martin K. Petersen
@ 2020-09-22 3:57 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-22 3:57 UTC (permalink / raw)
To: linux-scsi, Jason Yan, megaraidlinux.pdl, damien.lemoal,
sumit.saxena, shivasharan.srikanteshwara, jejb, kashyap.desai
Cc: Martin K . Petersen, Hulk Robot
On Tue, 15 Sep 2020 16:39:48 +0800, Jason Yan wrote:
> This addresses the following sparse warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c:80:5: warning: symbol
> 'smp_affinity_enable' was not declared. Should it be static?
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: megaraid: Make smp_affinity_enable static
https://git.kernel.org/mkp/scsi/c/62aa501dc9dd
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-22 3:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 8:39 [PATCH] scsi: megaraid: make smp_affinity_enable static Jason Yan
2020-09-15 9:22 ` Damien Le Moal
2020-09-15 22:08 ` Martin K. Petersen
2020-09-22 3:57 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).