Re: [PATCH 22/29] scsi: ufs: qcom: Fix ufs_qcom_resume()

[Bjorn Andersson <bjorn.andersson@linaro.org>]

On Thu 31 Mar 15:34 PDT 2022, Bart Van Assche wrote:

> Clearing hba->is_sys_suspended if ufs_qcom_resume() succeeds is wrong. That
> variable must only be cleared if all actions involved in a resume succeed.
> Hence remove the statement that clears hba->is_sys_suspended from
> ufs_qcom_resume().
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Fixes: 81c0fc51b7a7 ("ufs-qcom: add support for Qualcomm Technologies Inc platforms")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>  drivers/scsi/ufs/ufs-qcom.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index f24210652fe9..808dae751527 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -640,12 +640,7 @@ static int ufs_qcom_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
>  			return err;
>  	}
>  
> -	err = ufs_qcom_ice_resume(host);
> -	if (err)
> -		return err;
> -
> -	hba->is_sys_suspended = false;
> -	return 0;
> +	return ufs_qcom_ice_resume(host);
>  }
>  
>  static void ufs_qcom_dev_ref_clk_ctrl(struct ufs_qcom_host *host, bool enable)