From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org, Andy Gross <agross@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bean Huo <beanhuo@micron.com>, Avri Altman <avri.altman@wdc.com>,
Daejun Park <daejun7.park@samsung.com>,
Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>
Subject: Re: [PATCH 02/29] scsi: ufs: Remove superfluous boolean conversions
Date: Thu, 31 Mar 2022 16:44:50 -0700 [thread overview]
Message-ID: <YkY88lHdTiiaBcB7@ripper> (raw)
In-Reply-To: <20220331223424.1054715-3-bvanassche@acm.org>
On Thu 31 Mar 15:33 PDT 2022, Bart Van Assche wrote:
> Remove "? true : false" if the preceding expression yields a boolean or if
> the result of the expression is assigned to a boolean since in these two
> cases the "? true : false" part is superfluous.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 3 +--
> drivers/scsi/ufs/ufshcd.c | 9 ++++-----
> drivers/scsi/ufs/ufshcd.h | 2 +-
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 0d2e950d0865..808b677f6083 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -299,8 +299,7 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
> struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> struct phy *phy = host->generic_phy;
> int ret = 0;
> - bool is_rate_B = (UFS_QCOM_LIMIT_HS_RATE == PA_HS_MODE_B)
> - ? true : false;
> + bool is_rate_B = UFS_QCOM_LIMIT_HS_RATE == PA_HS_MODE_B;
UFS_QCOM_LIMIT_HS_RATE is defined as PA_HS_MODE_B. I wonder if this is
expected to change at some point, or if we could clean this up further
(in a future change).
Regards,
Bjorn
>
> /* Reset UFS Host Controller and PHY */
> ret = ufs_qcom_host_reset(hba);
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dbf50b50870b..983fac14b7cd 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -712,8 +712,7 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba *hba)
> */
> static inline bool ufshcd_is_device_present(struct ufs_hba *hba)
> {
> - return (ufshcd_readl(hba, REG_CONTROLLER_STATUS) &
> - DEVICE_PRESENT) ? true : false;
> + return ufshcd_readl(hba, REG_CONTROLLER_STATUS) & DEVICE_PRESENT;
> }
>
> /**
> @@ -840,7 +839,7 @@ ufshcd_get_rsp_upiu_data_seg_len(struct utp_upiu_rsp *ucd_rsp_ptr)
> static inline bool ufshcd_is_exception_event(struct utp_upiu_rsp *ucd_rsp_ptr)
> {
> return be32_to_cpu(ucd_rsp_ptr->header.dword_2) &
> - MASK_RSP_EXCEPTION_EVENT ? true : false;
> + MASK_RSP_EXCEPTION_EVENT;
> }
>
> /**
> @@ -1350,7 +1349,7 @@ static int ufshcd_devfreq_target(struct device *dev,
> }
>
> /* Decide based on the rounded-off frequency and update */
> - scale_up = (*freq == clki->max_freq) ? true : false;
> + scale_up = *freq == clki->max_freq;
> if (!scale_up)
> *freq = clki->min_freq;
> /* Update the frequency */
> @@ -2800,7 +2799,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
> lrbp->sense_buffer = cmd->sense_buffer;
> lrbp->task_tag = tag;
> lrbp->lun = ufshcd_scsi_to_upiu_lun(cmd->device->lun);
> - lrbp->intr_cmd = !ufshcd_is_intr_aggr_allowed(hba) ? true : false;
> + lrbp->intr_cmd = !ufshcd_is_intr_aggr_allowed(hba);
>
> ufshcd_prepare_lrbp_crypto(scsi_cmd_to_rq(cmd), lrbp);
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 949427714d0e..b2740b51a546 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -985,7 +985,7 @@ static inline bool ufshcd_is_auto_hibern8_supported(struct ufs_hba *hba)
>
> static inline bool ufshcd_is_auto_hibern8_enabled(struct ufs_hba *hba)
> {
> - return FIELD_GET(UFSHCI_AHIBERN8_TIMER_MASK, hba->ahit) ? true : false;
> + return FIELD_GET(UFSHCI_AHIBERN8_TIMER_MASK, hba->ahit);
> }
>
> static inline bool ufshcd_is_wb_allowed(struct ufs_hba *hba)
next prev parent reply other threads:[~2022-03-31 23:42 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 22:33 [PATCH 00/29] UFS patches for kernel v5.19 Bart Van Assche
2022-03-31 22:33 ` [PATCH 01/29] scsi: ufs: Declare ufshcd_wait_for_register() static Bart Van Assche
2022-04-01 18:33 ` Avri Altman
2022-04-03 9:45 ` Bean Huo
2022-03-31 22:33 ` [PATCH 02/29] scsi: ufs: Remove superfluous boolean conversions Bart Van Assche
2022-03-31 23:44 ` Bjorn Andersson [this message]
2022-04-03 3:20 ` Bart Van Assche
2022-04-01 18:35 ` Avri Altman
2022-03-31 22:33 ` [PATCH 03/29] scsi: ufs: Simplify statements that return a boolean Bart Van Assche
2022-03-31 23:45 ` Bjorn Andersson
2022-04-01 18:49 ` Avri Altman
2022-04-03 3:30 ` Bart Van Assche
2022-03-31 22:33 ` [PATCH 04/29] scsi: ufs: Remove ufshcd_lrb.sense_bufflen Bart Van Assche
2022-04-01 18:56 ` Avri Altman
2022-03-31 22:34 ` [PATCH 05/29] scsi: ufs: Remove ufshcd_lrb.sense_buffer Bart Van Assche
2022-04-01 19:21 ` Avri Altman
2022-04-03 4:26 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 06/29] scsi: ufs: Use get_unaligned_be16() instead of be16_to_cpup() Bart Van Assche
2022-04-03 11:20 ` Bean Huo
2022-03-31 22:34 ` [PATCH 07/29] scsi: ufs: Remove the UFS_FIX() and END_FIX() macros Bart Van Assche
2022-04-01 19:43 ` Avri Altman
2022-03-31 22:34 ` [PATCH 08/29] scsi: ufs: Rename struct ufs_dev_fix into ufs_dev_quirk Bart Van Assche
2022-04-01 19:47 ` Avri Altman
2022-04-04 21:15 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 09/29] scsi: ufs: Declare the quirks array const Bart Van Assche
2022-04-01 19:56 ` Avri Altman
2022-04-04 21:14 ` Bart Van Assche
2022-04-08 14:41 ` Krzysztof Kozlowski
2022-04-05 6:14 ` Avri Altman
2022-03-31 22:34 ` [PATCH 10/29] scsi: ufs: Invert the return value of ufshcd_is_hba_active() Bart Van Assche
2022-04-02 6:32 ` Avri Altman
2022-03-31 22:34 ` [PATCH 11/29] scsi: ufs: Remove unused constants and code Bart Van Assche
2022-04-02 6:59 ` Avri Altman
2022-04-04 2:07 ` Bart Van Assche
2022-04-05 6:55 ` Avri Altman
2022-04-07 2:33 ` Stanley Chu
2022-03-31 22:34 ` [PATCH 12/29] scsi: ufs: Switch to aggregate initialization Bart Van Assche
2022-04-02 7:07 ` Avri Altman
2022-03-31 22:34 ` [PATCH 13/29] scsi: ufs: Remove the LUN quiescing code from ufshcd_wl_shutdown() Bart Van Assche
2022-04-01 6:20 ` Adrian Hunter
2022-04-01 13:52 ` Bart Van Assche
2022-04-01 14:35 ` Adrian Hunter
2022-04-05 19:11 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 14/29] scsi: ufs: Make the config_scaling_param calls type safe Bart Van Assche
2022-03-31 23:48 ` Bjorn Andersson
2022-04-01 4:08 ` Bart Van Assche
2022-04-03 3:51 ` Bjorn Andersson
2022-03-31 22:34 ` [PATCH 15/29] scsi: ufs: Remove the driver version Bart Van Assche
2022-04-03 7:10 ` Avri Altman
2022-04-03 21:51 ` Bart Van Assche
2022-04-03 15:52 ` Bean Huo
2022-04-04 6:25 ` Avri Altman
2022-03-31 22:34 ` [PATCH 16/29] scsi: ufs: Rename sdev_ufs_device into ufs_device_wlun Bart Van Assche
2022-04-03 7:25 ` Avri Altman
2022-03-31 22:34 ` [PATCH 17/29] scsi: ufs: Use an SPDX license identifier in the Kconfig file Bart Van Assche
2022-03-31 22:34 ` [PATCH 18/29] scsi: ufs: Remove paths from source code comments Bart Van Assche
2022-04-03 7:33 ` Avri Altman
2022-03-31 22:34 ` [PATCH 19/29] scsi: ufs: Remove the TRUE and FALSE definitions Bart Van Assche
2022-04-01 2:19 ` Chanho Park
2022-04-04 2:39 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 20/29] scsi: ufs: Remove locking from around single register writes Bart Van Assche
2022-04-05 6:19 ` Avri Altman
2022-03-31 22:34 ` [PATCH 21/29] scsi: ufs: Introduce ufshcd_clkgate_delay_set() Bart Van Assche
2022-04-05 6:20 ` Avri Altman
2022-03-31 22:34 ` [PATCH 22/29] scsi: ufs: qcom: Fix ufs_qcom_resume() Bart Van Assche
2022-03-31 23:50 ` Bjorn Andersson
2022-03-31 22:34 ` [PATCH 23/29] scsi: ufs: Remove unnecessary ufshcd-crypto.h include directives Bart Van Assche
2022-03-31 22:34 ` [PATCH 24/29] scsi: ufs: Fix kernel-doc syntax in ufshcd.h Bart Van Assche
2022-04-05 6:27 ` Avri Altman
2022-03-31 22:34 ` [PATCH 25/29] scsi: ufs: Minimize #include directives Bart Van Assche
2022-04-01 6:53 ` Adrian Hunter
2022-04-01 13:52 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 26/29] scsi: ufs: Split the ufshcd.h header file Bart Van Assche
2022-04-01 0:21 ` Chanho Park
2022-04-01 4:14 ` Bart Van Assche
2022-04-01 4:30 ` Chanho Park
2022-04-05 6:39 ` Avri Altman
2022-04-05 14:10 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 27/29] scsi: ufs: Move the struct ufs_ref_clk definition Bart Van Assche
2022-04-05 6:50 ` Avri Altman
2022-03-31 22:34 ` [PATCH 28/29] scsi: ufs: Move the ufs_is_valid_unit_desc_lun() definition Bart Van Assche
2022-04-05 6:53 ` Avri Altman
2022-04-05 14:13 ` Bart Van Assche
2022-03-31 22:34 ` [PATCH 29/29] scsi: ufs: Split the drivers/scsi/ufs directory Bart Van Assche
2022-04-01 5:12 ` Christoph Hellwig
2022-04-01 13:56 ` Bart Van Assche
2022-04-01 6:38 ` Adrian Hunter
2022-04-01 13:58 ` Bart Van Assche
2022-04-01 17:03 ` Alim Akhtar
2022-04-02 3:21 ` Bart Van Assche
[not found] ` <CGME20220331223522epcas2p4f8f20c2ec00dbc6d5a7bf855a1dd7395@epcms2p5>
2022-04-01 6:14 ` [PATCH 04/29] scsi: ufs: Remove ufshcd_lrb.sense_bufflen Keoseong Park
2022-04-01 9:28 ` [PATCH 00/29] UFS patches for kernel v5.19 Bean Huo
2022-04-01 9:32 ` Bean Huo
2022-04-01 14:12 ` Bart Van Assche
2022-04-03 5:59 ` Avri Altman
2022-04-03 21:36 ` Bean Huo
2022-04-03 21:54 ` Bart Van Assche
2022-04-04 8:12 ` Bean Huo
2022-04-04 21:13 ` Bart Van Assche
2022-04-05 9:33 ` Bean Huo
2022-04-05 14:22 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkY88lHdTiiaBcB7@ripper \
--to=bjorn.andersson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).