From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <michael.christie@oracle.com>
Cc: hch@infradead.org, martin.petersen@oracle.com,
james.bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: target: Fix WRITE_SAME No Data Buffer crash
Date: Mon, 27 Jun 2022 21:54:31 -0700 [thread overview]
Message-ID: <YrqJhyzhjaEkTJL/@infradead.org> (raw)
In-Reply-To: <20220628022325.14627-2-michael.christie@oracle.com>
On Mon, Jun 27, 2022 at 09:23:25PM -0500, Mike Christie wrote:
> In newer version of the SBC specs, we have a NDOB bit that indicates there
> is no data buffer that gets written out. If this bit is set using commands
> like "sg_write_same --ndob" we will crash in target_core_iblock/file's
> execute_write_same handlers when we go to access the se_cmd->t_data_sg
> because its NULL.
>
> This patch adds a check for the NDOB bit in the common WRITE SAME code
> because we don't support it. And, it adds a check for zero SG elements in
> each handler in case the initiator tries to send a normal WRITE SAME with
> no data buffer.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
(and I wonder if we have similar problems with other commands, the
target code could use same targeted fuzzing..)
next prev parent reply other threads:[~2022-06-28 4:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 2:23 [PATCH 0/1] target: Unmap fixes Mike Christie
2022-06-28 2:23 ` [PATCH 1/1] scsi: target: Fix WRITE_SAME No Data Buffer crash Mike Christie
2022-06-28 4:54 ` Christoph Hellwig [this message]
2022-07-07 20:42 ` Martin K. Petersen
2022-07-07 20:57 ` Dmitry Bogdanov
2022-07-07 21:38 ` Martin K. Petersen
2022-07-07 21:47 ` [PATCH 0/1] target: Unmap fixes Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrqJhyzhjaEkTJL/@infradead.org \
--to=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).