linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mike Christie <michael.christie@oracle.com>,
	martin.petersen@oracle.com,
	james.bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: target: Fix WRITE_SAME No Data Buffer crash
Date: Thu, 07 Jul 2022 16:42:36 -0400	[thread overview]
Message-ID: <yq1mtdk7j59.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <YrqJhyzhjaEkTJL/@infradead.org> (Christoph Hellwig's message of "Mon, 27 Jun 2022 21:54:31 -0700")


Christoph,

> (and I wonder if we have similar problems with other commands, the
> target code could use same targeted fuzzing..)

Yeah.

The USB gadget series implements initial support for RSOC. It might be
worth entertaining to augment that code with CDB masks for all the
commands we actually support. And then leverage these masks for command
validation.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2022-07-07 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28  2:23 [PATCH 0/1] target: Unmap fixes Mike Christie
2022-06-28  2:23 ` [PATCH 1/1] scsi: target: Fix WRITE_SAME No Data Buffer crash Mike Christie
2022-06-28  4:54   ` Christoph Hellwig
2022-07-07 20:42     ` Martin K. Petersen [this message]
2022-07-07 20:57       ` Dmitry Bogdanov
2022-07-07 21:38         ` Martin K. Petersen
2022-07-07 21:47 ` [PATCH 0/1] target: Unmap fixes Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1mtdk7j59.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=hch@infradead.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).