mpt3sas: BUG: KASAN: slab-out-of-bounds in _scsih_add_device

mpt3sas: BUG: KASAN: slab-out-of-bounds in _scsih_add_device

[Breno Leitao]

Hello,

I am running 6.9 kernel in one of my machines, and it shows the
following KASAN issue. I've tested in linux-next also, and the problem
is there also. In fact, the snippet below is from linux-next
(a17ef9e6c2c1cf0fc6cd6ca6a9ce525c67d1da7f)

Is this a known problem?

	[  416.135509] BUG: KASAN: slab-out-of-bounds in _scsih_add_device.constprop.0 (./arch/x86/include/asm/bitops.h:60 ./include/asm-generic/bitops/instrumented-atomic.h:29 drivers/scsi/mpt3sas/mpt3sas_scsih.c:7331) mpt3sas

	[  416.203247] Write of size 8 at addr ffff8881d26e3c60 by task kworker/u1536:2/2965
	[  416.203259]
	[  416.203269] Hardware name: ...
	[  416.203276] Workqueue: fw_event_mpt3sas0 _firmware_event_work [mpt3sas]
	[  416.243752]
	[  416.243758] Call Trace:
	[  416.243761]  <TASK>
	[  416.243767] dump_stack_lvl (lib/dump_stack.c:117) 
	[  416.274876] print_report (mm/kasan/report.c:378 mm/kasan/report.c:488) 
	[  416.274891] ? __virt_addr_valid (./arch/x86/include/asm/preempt.h:103 ./include/linux/rcupdate.h:896 ./include/linux/mmzone.h:2029 arch/x86/mm/physaddr.c:65) 
	[  416.274901] ? _scsih_add_device.constprop.0 (./arch/x86/include/asm/bitops.h:60 ./include/asm-generic/bitops/instrumented-atomic.h:29 drivers/scsi/mpt3sas/mpt3sas_scsih.c:7331) mpt3sas
	[  416.309307] kasan_report (mm/kasan/report.c:603) 
	[  416.309321] ? _scsih_add_device.constprop.0 (./arch/x86/include/asm/bitops.h:60 ./include/asm-generic/bitops/instrumented-atomic.h:29 drivers/scsi/mpt3sas/mpt3sas_scsih.c:7331) mpt3sas
	[  416.336976] kasan_check_range (mm/kasan/generic.c:183 mm/kasan/generic.c:189) 
	[  416.336990] _scsih_add_device.constprop.0 (./arch/x86/include/asm/bitops.h:60 ./include/asm-generic/bitops/instrumented-atomic.h:29 drivers/scsi/mpt3sas/mpt3sas_scsih.c:7331) mpt3sas
	[  416.376791] ? mpt3sas_transport_update_links (drivers/scsi/mpt3sas/mpt3sas_transport.c:1187) mpt3sas
	[  416.376845] ? _scsih_check_device.constprop.0 (drivers/scsi/mpt3sas/mpt3sas_scsih.c:7299) mpt3sas
	[  416.376884] ? mark_held_locks (kernel/locking/lockdep.c:4274) 
	[  416.376897] ? mpt3sas_transport_update_links (drivers/scsi/mpt3sas/mpt3sas_transport.c:1199) mpt3sas
	[  416.402989] ? _raw_spin_unlock_irqrestore (./include/linux/spinlock_api_smp.h:151 kernel/locking/spinlock.c:194) 
	[  416.403002] _firmware_event_work (drivers/scsi/mpt3sas/mpt3sas_scsih.c:7688 drivers/scsi/mpt3sas/mpt3sas_scsih.c:10762 drivers/scsi/mpt3sas/mpt3sas_scsih.c:10825) mpt3sas
	[  416.413092] ? mpt3sas_scsih_issue_tm (drivers/scsi/mpt3sas/mpt3sas_scsih.c:10821) mpt3sas
	[  416.445569] ? lockdep_hardirqs_on_prepare (kernel/locking/lockdep.c:4993) 
	[  416.445588] ? lock_downgrade (kernel/locking/lockdep.c:5762) 
	[  416.445594] ? find_held_lock (kernel/locking/lockdep.c:5244) 
	[  416.445604] ? lock_sync (kernel/locking/lockdep.c:5722) 
	[  416.445609] ? lock_downgrade (kernel/locking/lockdep.c:5762) 
	[  416.501157] process_one_work (kernel/workqueue.c:3272) 
	[  416.501177] ? lock_sync (kernel/locking/lockdep.c:5722) 
	[  416.523022] ? pwq_dec_nr_in_flight (kernel/workqueue.c:3169) 
	[  416.523041] ? assign_work (kernel/workqueue.c:1209) 
	[  416.523047] worker_thread (kernel/workqueue.c:3342 kernel/workqueue.c:3429) 
	[  416.523055] ? rescuer_thread (kernel/workqueue.c:3375) 
	[  416.556072] kthread (kernel/kthread.c:388) 
	[  416.556086] ? _raw_spin_unlock_irq (./arch/x86/include/asm/irqflags.h:42 ./arch/x86/include/asm/irqflags.h:77 ./include/linux/spinlock_api_smp.h:159 kernel/locking/spinlock.c:202) 
	[  416.556095] ? kthread_complete_and_exit (kernel/kthread.c:341) 
	[  416.587199] ret_from_fork (arch/x86/kernel/process.c:153) 
	[  416.587213] ? kthread_complete_and_exit (kernel/kthread.c:341) 
	[  416.587218] ret_from_fork_asm (arch/x86/entry/entry_64.S:257) 
	[  416.587230]  </TASK>
	[  416.587233]
	[  416.587234] Allocated by task 2949:
	[  416.587238] kasan_save_stack (mm/kasan/common.c:48) 
	[  416.587247] kasan_save_track (./arch/x86/include/asm/current.h:49 mm/kasan/common.c:60 mm/kasan/common.c:69) 
	[  416.587250] __kasan_kmalloc (mm/kasan/common.c:391) 
	[  416.587253] __kmalloc (mm/slub.c:3967 mm/slub.c:3979) 
	[  416.615271] mpt3sas_base_attach (drivers/scsi/mpt3sas/mpt3sas_base.c:8532) mpt3sas
	[  416.637921] _scsih_probe (drivers/scsi/mpt3sas/mpt3sas_scsih.c:12330) mpt3sas
	[  416.662117] local_pci_probe (drivers/pci/pci-driver.c:326) 
	[  416.662128] work_for_cpu_fn (kernel/workqueue.c:6558) 
	[  416.662134] process_one_work (kernel/workqueue.c:3272) 
	[  416.692274] worker_thread (kernel/workqueue.c:3342 kernel/workqueue.c:3429) 
	[  416.692287] kthread (kernel/kthread.c:388) 
	[  416.692291] ret_from_fork (arch/x86/kernel/process.c:153) 
	[  416.692297] ret_from_fork_asm (arch/x86/entry/entry_64.S:257) 
	[  416.692302]
	[  416.692306] The buggy address belongs to the object at ffff8881d26e3c60
	[  416.692306]  which belongs to the cache kmalloc-8 of size 8
	[  416.692310] The buggy address is located 0 bytes inside of
	[  416.692310]  allocated 1-byte region [ffff8881d26e3c60, ffff8881d26e3c61)
	[  416.692314]
	[  416.692316] The buggy address belongs to the physical page:
	[  416.692318] page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1d26e3
	[  416.692324] flags: 0x5ffff0000000800(slab|node=0|zone=2|lastcpupid=0x1ffff)
	[  416.692330] page_type: 0xffffffff()
	[  416.692336] raw: 05ffff0000000800 ffff88810004c280 dead000000000122 0000000000000000
	[  416.692341] raw: 0000000000000000 0000000000800080 00000001ffffffff 0000000000000000
	[  416.717271] page dumped because: kasan: bad access detected
	[  416.717277]
	[  416.717279] Memory state around the buggy address:
	[  416.717282]  ffff8881d26e3b00: fa fc fc fc fa fc fc fc 06 fc fc fc 06 fc fc fc
	[  416.717285]  ffff8881d26e3b80: 06 fc fc fc 06 fc fc fc 06 fc fc fc fa fc fc fc
	[  416.717288] >ffff8881d26e3c00: fa fc fc fc 01 fc fc fc 01 fc fc fc 01 fc fc fc
	[  416.717289]                                                        ^
	[  416.717292]  ffff8881d26e3c80: 01 fc fc fc fa fc fc fc fa fc fc fc fa fc fc fc
	[  416.717294]  ffff8881d26e3d00: fa fc fc fc 06 fc fc fc 03 fc fc fc 05 fc fc fc
	[  416.717296] ==================================================================
	[  416.717404] Disabling lock debugging due to kernel taint