From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Bean Huo <beanhuo@micron.com>, Can Guo <cang@codeaurora.org>,
Avri Altman <avri.altman@wdc.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Keoseong Park <keosung.park@samsung.com>
Subject: Re: [PATCH v2 18/20] scsi: ufs: Optimize the command queueing code
Date: Tue, 23 Nov 2021 10:24:05 -0800 [thread overview]
Message-ID: <b3d2764a-8dd3-1c4e-675d-c43039d28850@codeaurora.org> (raw)
In-Reply-To: <6dea2d9c-c04a-20a5-4292-e48badf89ba2@acm.org>
On 11/22/2021 3:48 PM, Bart Van Assche wrote:
> On 11/22/21 3:02 PM, Asutosh Das (asd) wrote:
>> Current code waits for the already issued requests to complete. It
>> doesn't issue the yet-to-be issued requests. Wouldn't freezing the
>> queue issue the requests in the context of scaling_{up/down}?
>> If yes, I don't think the current code is doing that.
>
> Hi Asutosh,
>
> How about the patch below that preserves most of the existing code for
> preparing for clock scaling?
>
> Thanks,
>
> Bart.
>
Hi Bart,
This looks good to me. Please push a change and I can test it out.
-asd
>
> Subject: [PATCH] scsi: ufs: Optimize the command queueing code
>
> Remove the clock scaling lock from ufshcd_queuecommand() since it is a
> performance bottleneck. Instead, use synchronize_rcu_expedited() to wait
> for ongoing ufshcd_queuecommand() calls.
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 12 +++++++-----
> drivers/scsi/ufs/ufshcd.h | 1 +
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5d214456bf82..1d929c28efaf 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1196,6 +1196,13 @@ static int ufshcd_clock_scaling_prepare(struct
> ufs_hba *hba)
> /* let's not get into low power until clock scaling is completed */
> ufshcd_hold(hba, false);
>
> + /*
> + * Wait for ongoing ufshcd_queuecommand() calls. Calling
> + * synchronize_rcu_expedited() instead of synchronize_rcu() reduces
> the
> + * waiting time from milliseconds to microseconds.
> + */
> + synchronize_rcu_expedited();
> +
> out:
> return ret;
> }
> @@ -2699,9 +2706,6 @@ static int ufshcd_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *cmd)
>
> WARN_ONCE(tag < 0, "Invalid tag %d\n", tag);
>
> - if (!down_read_trylock(&hba->clk_scaling_lock))
> - return SCSI_MLQUEUE_HOST_BUSY;
> -
> /*
> * Allows the UFS error handler to wait for prior
> ufshcd_queuecommand()
> * calls.
> @@ -2790,8 +2794,6 @@ static int ufshcd_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *cmd)
> out:
> rcu_read_unlock();
>
> - up_read(&hba->clk_scaling_lock);
> -
> if (ufs_trigger_eh()) {
> unsigned long flags;
>
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index c13ae56fbff8..695bede14dac 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -777,6 +777,7 @@ struct ufs_hba_monitor {
> * @clk_list_head: UFS host controller clocks list node head
> * @pwr_info: holds current power mode
> * @max_pwr_info: keeps the device max valid pwm
> + * @clk_scaling_lock: used to serialize device commands and clock scaling
> * @desc_size: descriptor sizes reported by device
> * @urgent_bkops_lvl: keeps track of urgent bkops level for device
> * @is_urgent_bkops_lvl_checked: keeps track if the urgent bkops level
> for
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-11-23 18:24 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 19:57 [PATCH v2 00/20] UFS patches for kernel v5.17 Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 01/20] block: Add a flag for internal commands Bart Van Assche
2021-11-22 8:46 ` John Garry
2021-11-22 17:38 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 02/20] scsi: core: Unexport scsi_track_queue_full() Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 03/20] scsi: core: Fix scsi_device_max_queue_depth() Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 04/20] scsi: core: Fix a race between scsi_done() and scsi_times_out() Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 05/20] scsi: core: Add support for internal commands Bart Van Assche
2021-11-22 8:58 ` John Garry
2021-11-22 17:46 ` Bart Van Assche
2021-11-22 18:08 ` John Garry
2021-11-22 19:04 ` Bart Van Assche
2021-11-23 8:13 ` Hannes Reinecke
2021-11-23 17:46 ` Bart Van Assche
2021-11-23 19:18 ` Bart Van Assche
2021-11-24 6:33 ` Hannes Reinecke
2021-11-19 19:57 ` [PATCH v2 06/20] scsi: core: Add support for reserved tags Bart Van Assche
2021-11-22 8:15 ` John Garry
2021-11-22 17:25 ` Bart Van Assche
2021-11-22 18:13 ` John Garry
2021-11-19 19:57 ` [PATCH v2 07/20] scsi: ufs: Rename a function argument Bart Van Assche
2021-11-22 20:25 ` Bean Huo
2021-11-19 19:57 ` [PATCH v2 08/20] scsi: ufs: Remove is_rpmb_wlun() Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 09/20] scsi: ufs: Remove the sdev_rpmb member Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 10/20] scsi: ufs: Remove dead code Bart Van Assche
2021-11-24 11:11 ` Adrian Hunter
2021-11-29 19:12 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 11/20] scsi: ufs: Switch to scsi_(get|put)_internal_cmd() Bart Van Assche
2021-11-23 12:20 ` Bean Huo
2021-11-23 17:54 ` Bart Van Assche
2021-11-23 19:41 ` Bart Van Assche
2021-11-24 18:18 ` Bean Huo
2021-11-24 11:02 ` Adrian Hunter
2021-11-24 11:15 ` Adrian Hunter
2021-11-29 19:32 ` Bart Van Assche
2021-11-30 6:41 ` Adrian Hunter
2021-11-30 17:51 ` Bart Van Assche
2021-11-30 19:15 ` Adrian Hunter
2021-11-30 19:21 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 12/20] scsi: ufs: Rework ufshcd_change_queue_depth() Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 13/20] scsi: ufs: Fix a deadlock in the error handler Bart Van Assche
2021-11-30 8:54 ` Bean Huo
2021-11-30 17:52 ` Bart Van Assche
2021-11-30 19:32 ` Bart Van Assche
2021-12-01 13:44 ` Bean Huo
2021-12-01 18:31 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 14/20] scsi: ufs: Introduce ufshcd_release_scsi_cmd() Bart Van Assche
2021-11-24 12:03 ` Adrian Hunter
2021-11-30 18:00 ` Bart Van Assche
2021-11-30 19:02 ` Adrian Hunter
2021-11-30 19:16 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 15/20] scsi: ufs: Improve SCSI abort handling Bart Van Assche
2021-11-24 12:28 ` Adrian Hunter
2021-11-30 4:13 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 16/20] scsi: ufs: Fix a kernel crash during shutdown Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 17/20] scsi: ufs: Stop using the clock scaling lock in the error handler Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 18/20] scsi: ufs: Optimize the command queueing code Bart Van Assche
2021-11-22 17:46 ` Asutosh Das (asd)
2021-11-22 18:13 ` Bart Van Assche
2021-11-22 23:02 ` Asutosh Das (asd)
2021-11-22 23:48 ` Bart Van Assche
2021-11-23 18:24 ` Asutosh Das (asd) [this message]
2021-12-01 18:33 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 19/20] scsi: ufs: Implement polling support Bart Van Assche
2021-11-30 8:43 ` Bean Huo
2021-11-30 8:57 ` Avri Altman
2021-11-30 9:15 ` Bean Huo
2021-11-30 14:26 ` Bart Van Assche
2021-11-30 15:40 ` Bean Huo
2021-11-30 17:34 ` Bart Van Assche
2021-11-30 17:37 ` Bart Van Assche
2021-11-19 19:57 ` [PATCH v2 20/20] scsi: ufs: Fix race conditions related to driver data Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d2764a-8dd3-1c4e-675d-c43039d28850@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=keosung.park@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).