* [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk
@ 2020-07-29 5:18 Stanley Chu
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Stanley Chu @ 2020-07-29 5:18 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb, beanhuo
Cc: asutoshd, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou, Stanley Chu
Hi,
This patchset introduces and applies DELAY_AFTER_LPM device quirk in MediaTek platforms.
Stanley Chu (2):
scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices
drivers/scsi/ufs/ufs-mediatek.c | 2 ++
drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
3 files changed, 20 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
2020-07-29 5:18 [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Stanley Chu
@ 2020-07-29 5:18 ` Stanley Chu
2020-07-29 5:31 ` Can Guo
2020-07-29 9:21 ` Can Guo
2020-07-29 5:18 ` [PATCH v1 2/2] scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices Stanley Chu
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Stanley Chu @ 2020-07-29 5:18 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb, beanhuo
Cc: asutoshd, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou, Stanley Chu
Some UFS devices require delay after VCC power rail is turned-off.
Introduce a device quirk "DELAY_AFTER_LPM" to add 5ms delays after
VCC power-off during suspend flow.
Signed-off-by: Andy Teng <andy.teng@mediatek.com>
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
2 files changed, 18 insertions(+)
diff --git a/drivers/scsi/ufs/ufs_quirks.h b/drivers/scsi/ufs/ufs_quirks.h
index 2a0041493e30..07f559ac5883 100644
--- a/drivers/scsi/ufs/ufs_quirks.h
+++ b/drivers/scsi/ufs/ufs_quirks.h
@@ -109,4 +109,11 @@ struct ufs_dev_fix {
*/
#define UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES (1 << 10)
+/*
+ * Some UFS devices require delay after VCC power rail is turned-off.
+ * Enable this quirk to introduce 5ms delays after VCC power-off during
+ * suspend flow.
+ */
+#define UFS_DEVICE_QUIRK_DELAY_AFTER_LPM (1 << 11)
+
#endif /* UFS_QUIRKS_H_ */
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index acba2271c5d3..63f4e2f75aa1 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8111,6 +8111,8 @@ static int ufshcd_link_state_transition(struct ufs_hba *hba,
static void ufshcd_vreg_set_lpm(struct ufs_hba *hba)
{
+ bool vcc_off = false;
+
/*
* It seems some UFS devices may keep drawing more than sleep current
* (atleast for 500us) from UFS rails (especially from VCCQ rail).
@@ -8139,13 +8141,22 @@ static void ufshcd_vreg_set_lpm(struct ufs_hba *hba)
if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba) &&
!hba->dev_info.is_lu_power_on_wp) {
ufshcd_setup_vreg(hba, false);
+ vcc_off = true;
} else if (!ufshcd_is_ufs_dev_active(hba)) {
ufshcd_toggle_vreg(hba->dev, hba->vreg_info.vcc, false);
+ vcc_off = true;
if (!ufshcd_is_link_active(hba)) {
ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq);
ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq2);
}
}
+
+ /*
+ * Some UFS devices require delay after VCC power rail is turned-off.
+ */
+ if (vcc_off && hba->vreg_info.vcc &&
+ hba->dev_quirks & UFS_DEVICE_QUIRK_DELAY_AFTER_LPM)
+ usleep_range(5000, 5100);
}
static int ufshcd_vreg_set_hpm(struct ufs_hba *hba)
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v1 2/2] scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices
2020-07-29 5:18 [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Stanley Chu
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
@ 2020-07-29 5:18 ` Stanley Chu
2020-07-29 7:32 ` [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Avri Altman
2020-07-30 2:24 ` Martin K. Petersen
3 siblings, 0 replies; 8+ messages in thread
From: Stanley Chu @ 2020-07-29 5:18 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb, beanhuo
Cc: asutoshd, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou, Stanley Chu
Micron UFS devices require DELAY_AFTER_LPM device quirk in
MediaTek platforms.
Signed-off-by: Andy Teng <andy.teng@mediatek.com>
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 31af8b3d2b53..7ff2682f481c 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -36,6 +36,8 @@
ufs_mtk_smc(UFS_MTK_SIP_DEVICE_RESET, high, res)
static struct ufs_dev_fix ufs_mtk_dev_fixups[] = {
+ UFS_FIX(UFS_VENDOR_MICRON, UFS_ANY_MODEL,
+ UFS_DEVICE_QUIRK_DELAY_AFTER_LPM),
UFS_FIX(UFS_VENDOR_SKHYNIX, "H9HQ21AFAMZDAR",
UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES),
END_FIX
--
2.18.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
@ 2020-07-29 5:31 ` Can Guo
2020-07-29 6:17 ` Stanley Chu
2020-07-29 9:21 ` Can Guo
1 sibling, 1 reply; 8+ messages in thread
From: Can Guo @ 2020-07-29 5:31 UTC (permalink / raw)
To: Stanley Chu
Cc: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb,
beanhuo, asutoshd, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou
Hi Stanley,
On 2020-07-29 13:18, Stanley Chu wrote:
> Some UFS devices require delay after VCC power rail is turned-off.
> Introduce a device quirk "DELAY_AFTER_LPM" to add 5ms delays after
> VCC power-off during suspend flow.
>
Just curious, I can understand if you want to add some delays before
turnning off VCC/VCCQ/VCCQ2, but what is the delay AFTER turnning
them off for? I mean the power has been cut by host from PMIC, how
can the delay benefit the UFS device?
Thanks,
Can Guo.
> Signed-off-by: Andy Teng <andy.teng@mediatek.com>
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
> drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs_quirks.h
> b/drivers/scsi/ufs/ufs_quirks.h
> index 2a0041493e30..07f559ac5883 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -109,4 +109,11 @@ struct ufs_dev_fix {
> */
> #define UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES (1 << 10)
>
> +/*
> + * Some UFS devices require delay after VCC power rail is turned-off.
> + * Enable this quirk to introduce 5ms delays after VCC power-off
> during
> + * suspend flow.
> + */
> +#define UFS_DEVICE_QUIRK_DELAY_AFTER_LPM (1 << 11)
> +
> #endif /* UFS_QUIRKS_H_ */
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index acba2271c5d3..63f4e2f75aa1 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8111,6 +8111,8 @@ static int ufshcd_link_state_transition(struct
> ufs_hba *hba,
>
> static void ufshcd_vreg_set_lpm(struct ufs_hba *hba)
> {
> + bool vcc_off = false;
> +
> /*
> * It seems some UFS devices may keep drawing more than sleep current
> * (atleast for 500us) from UFS rails (especially from VCCQ rail).
> @@ -8139,13 +8141,22 @@ static void ufshcd_vreg_set_lpm(struct ufs_hba
> *hba)
> if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba) &&
> !hba->dev_info.is_lu_power_on_wp) {
> ufshcd_setup_vreg(hba, false);
> + vcc_off = true;
> } else if (!ufshcd_is_ufs_dev_active(hba)) {
> ufshcd_toggle_vreg(hba->dev, hba->vreg_info.vcc, false);
> + vcc_off = true;
> if (!ufshcd_is_link_active(hba)) {
> ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq);
> ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq2);
> }
> }
> +
> + /*
> + * Some UFS devices require delay after VCC power rail is turned-off.
> + */
> + if (vcc_off && hba->vreg_info.vcc &&
> + hba->dev_quirks & UFS_DEVICE_QUIRK_DELAY_AFTER_LPM)
> + usleep_range(5000, 5100);
> }
>
> static int ufshcd_vreg_set_hpm(struct ufs_hba *hba)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
2020-07-29 5:31 ` Can Guo
@ 2020-07-29 6:17 ` Stanley Chu
0 siblings, 0 replies; 8+ messages in thread
From: Stanley Chu @ 2020-07-29 6:17 UTC (permalink / raw)
To: Can Guo
Cc: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb,
beanhuo, asutoshd, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou
Hi Can,
On Wed, 2020-07-29 at 13:31 +0800, Can Guo wrote:
> Hi Stanley,
>
> On 2020-07-29 13:18, Stanley Chu wrote:
> > Some UFS devices require delay after VCC power rail is turned-off.
> > Introduce a device quirk "DELAY_AFTER_LPM" to add 5ms delays after
> > VCC power-off during suspend flow.
> >
>
> Just curious, I can understand if you want to add some delays before
> turnning off VCC/VCCQ/VCCQ2, but what is the delay AFTER turnning
> them off for? I mean the power has been cut by host from PMIC, how
> can the delay benefit the UFS device?
>
The problem comes from both sides,
1. VCC power rail design by SoC vendors, and
2. Device strategy according to VCC changes
Take Micron UFS devices on MediaTek platform as example, our VCC drop
rate may be too slow and lead to incorrect resume strategy by device.
Without this delay, device may not resume successfully.
Thanks,
Stanley Chu
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk
2020-07-29 5:18 [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Stanley Chu
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
2020-07-29 5:18 ` [PATCH v1 2/2] scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices Stanley Chu
@ 2020-07-29 7:32 ` Avri Altman
2020-07-30 2:24 ` Martin K. Petersen
3 siblings, 0 replies; 8+ messages in thread
From: Avri Altman @ 2020-07-29 7:32 UTC (permalink / raw)
To: Stanley Chu, linux-scsi, martin.petersen, alim.akhtar, jejb, beanhuo
Cc: asutoshd, cang, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou
Looks fine.
Thanks,
Avri
>
> Hi,
> This patchset introduces and applies DELAY_AFTER_LPM device quirk in
> MediaTek platforms.
>
> Stanley Chu (2):
> scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
> scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices
>
> drivers/scsi/ufs/ufs-mediatek.c | 2 ++
> drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
> drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
> 3 files changed, 20 insertions(+)
>
> --
> 2.18.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
2020-07-29 5:31 ` Can Guo
@ 2020-07-29 9:21 ` Can Guo
1 sibling, 0 replies; 8+ messages in thread
From: Can Guo @ 2020-07-29 9:21 UTC (permalink / raw)
To: Stanley Chu
Cc: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb,
beanhuo, asutoshd, matthias.bgg, bvanassche, linux-mediatek,
linux-arm-kernel, linux-kernel, kuohong.wang, peter.wang,
chun-hung.wu, andy.teng, chaotian.jing, cc.chou
On 2020-07-29 13:18, Stanley Chu wrote:
> Some UFS devices require delay after VCC power rail is turned-off.
> Introduce a device quirk "DELAY_AFTER_LPM" to add 5ms delays after
> VCC power-off during suspend flow.
>
> Signed-off-by: Andy Teng <andy.teng@mediatek.com>
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
> drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs_quirks.h
> b/drivers/scsi/ufs/ufs_quirks.h
> index 2a0041493e30..07f559ac5883 100644
> --- a/drivers/scsi/ufs/ufs_quirks.h
> +++ b/drivers/scsi/ufs/ufs_quirks.h
> @@ -109,4 +109,11 @@ struct ufs_dev_fix {
> */
> #define UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES (1 << 10)
>
> +/*
> + * Some UFS devices require delay after VCC power rail is turned-off.
> + * Enable this quirk to introduce 5ms delays after VCC power-off
> during
> + * suspend flow.
> + */
> +#define UFS_DEVICE_QUIRK_DELAY_AFTER_LPM (1 << 11)
> +
> #endif /* UFS_QUIRKS_H_ */
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index acba2271c5d3..63f4e2f75aa1 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8111,6 +8111,8 @@ static int ufshcd_link_state_transition(struct
> ufs_hba *hba,
>
> static void ufshcd_vreg_set_lpm(struct ufs_hba *hba)
> {
> + bool vcc_off = false;
> +
> /*
> * It seems some UFS devices may keep drawing more than sleep current
> * (atleast for 500us) from UFS rails (especially from VCCQ rail).
> @@ -8139,13 +8141,22 @@ static void ufshcd_vreg_set_lpm(struct ufs_hba
> *hba)
> if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba) &&
> !hba->dev_info.is_lu_power_on_wp) {
> ufshcd_setup_vreg(hba, false);
> + vcc_off = true;
> } else if (!ufshcd_is_ufs_dev_active(hba)) {
> ufshcd_toggle_vreg(hba->dev, hba->vreg_info.vcc, false);
> + vcc_off = true;
> if (!ufshcd_is_link_active(hba)) {
> ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq);
> ufshcd_config_vreg_lpm(hba, hba->vreg_info.vccq2);
> }
> }
> +
> + /*
> + * Some UFS devices require delay after VCC power rail is turned-off.
> + */
> + if (vcc_off && hba->vreg_info.vcc &&
> + hba->dev_quirks & UFS_DEVICE_QUIRK_DELAY_AFTER_LPM)
> + usleep_range(5000, 5100);
> }
>
> static int ufshcd_vreg_set_hpm(struct ufs_hba *hba)
Reviewed-by: Can Guo <cang@codeaurora.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk
2020-07-29 5:18 [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Stanley Chu
` (2 preceding siblings ...)
2020-07-29 7:32 ` [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Avri Altman
@ 2020-07-30 2:24 ` Martin K. Petersen
3 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2020-07-30 2:24 UTC (permalink / raw)
To: alim.akhtar, beanhuo, jejb, linux-scsi, avri.altman, Stanley Chu
Cc: Martin K . Petersen, matthias.bgg, cang, bvanassche, asutoshd,
cc.chou, chaotian.jing, peter.wang, linux-kernel, kuohong.wang,
linux-mediatek, linux-arm-kernel, andy.teng, chun-hung.wu
On Wed, 29 Jul 2020 13:18:38 +0800, Stanley Chu wrote:
> This patchset introduces and applies DELAY_AFTER_LPM device quirk in MediaTek platforms.
>
> Stanley Chu (2):
> scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
> scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices
>
> drivers/scsi/ufs/ufs-mediatek.c | 2 ++
> drivers/scsi/ufs/ufs_quirks.h | 7 +++++++
> drivers/scsi/ufs/ufshcd.c | 11 +++++++++++
> 3 files changed, 20 insertions(+)
Applied to 5.9/scsi-queue, thanks!
[1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM"
https://git.kernel.org/mkp/scsi/c/33166bebcd6d
[2/2] scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices
https://git.kernel.org/mkp/scsi/c/4d4673745fe2
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-30 2:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 5:18 [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Stanley Chu
2020-07-29 5:18 ` [PATCH v1 1/2] scsi: ufs: Introduce device quirk "DELAY_AFTER_LPM" Stanley Chu
2020-07-29 5:31 ` Can Guo
2020-07-29 6:17 ` Stanley Chu
2020-07-29 9:21 ` Can Guo
2020-07-29 5:18 ` [PATCH v1 2/2] scsi: ufs-mediatek: Apply DELAY_AFTER_LPM quirk to Micron devices Stanley Chu
2020-07-29 7:32 ` [PATCH v1 0/2] scsi: ufs: Introduce and apply DELAY_AFTER_LPM device quirk Avri Altman
2020-07-30 2:24 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).