* [PATCH linux-next] scsi: lpfc: Remove unneeded result variable
@ 2022-08-24 7:51 cgel.zte
2022-08-24 14:14 ` James Smart
2022-09-01 4:39 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-08-24 7:51 UTC (permalink / raw)
To: martin.petersen
Cc: james.smart, dick.kennedy, jejb, linux-scsi, linux-kernel,
ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value from lpfc_issue_reg_vfi() directly instead of storing it
in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/scsi/lpfc/lpfc_bsg.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
index 9be3bb01a8ec..ac0c7ccf2eae 100644
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1977,8 +1977,6 @@ lpfc_sli4_bsg_set_loopback_mode(struct lpfc_hba *phba, int mode,
static int
lpfc_sli4_diag_fcport_reg_setup(struct lpfc_hba *phba)
{
- int rc;
-
if (phba->pport->fc_flag & FC_VFI_REGISTERED) {
lpfc_printf_log(phba, KERN_WARNING, LOG_LIBDFC,
"3136 Port still had vfi registered: "
@@ -1988,8 +1986,7 @@ lpfc_sli4_diag_fcport_reg_setup(struct lpfc_hba *phba)
phba->vpi_ids[phba->pport->vpi]);
return -EINVAL;
}
- rc = lpfc_issue_reg_vfi(phba->pport);
- return rc;
+ return lpfc_issue_reg_vfi(phba->pport);
}
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] scsi: lpfc: Remove unneeded result variable
2022-08-24 7:51 [PATCH linux-next] scsi: lpfc: Remove unneeded result variable cgel.zte
@ 2022-08-24 14:14 ` James Smart
2022-09-01 4:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2022-08-24 14:14 UTC (permalink / raw)
To: cgel.zte, martin.petersen
Cc: james.smart, dick.kennedy, jejb, linux-scsi, linux-kernel,
ye xingchen, Zeal Robot
On 8/24/2022 12:51 AM, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value from lpfc_issue_reg_vfi() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/scsi/lpfc/lpfc_bsg.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
> index 9be3bb01a8ec..ac0c7ccf2eae 100644
> --- a/drivers/scsi/lpfc/lpfc_bsg.c
> +++ b/drivers/scsi/lpfc/lpfc_bsg.c
> @@ -1977,8 +1977,6 @@ lpfc_sli4_bsg_set_loopback_mode(struct lpfc_hba *phba, int mode,
> static int
> lpfc_sli4_diag_fcport_reg_setup(struct lpfc_hba *phba)
> {
> - int rc;
> -
> if (phba->pport->fc_flag & FC_VFI_REGISTERED) {
> lpfc_printf_log(phba, KERN_WARNING, LOG_LIBDFC,
> "3136 Port still had vfi registered: "
> @@ -1988,8 +1986,7 @@ lpfc_sli4_diag_fcport_reg_setup(struct lpfc_hba *phba)
> phba->vpi_ids[phba->pport->vpi]);
> return -EINVAL;
> }
> - rc = lpfc_issue_reg_vfi(phba->pport);
> - return rc;
> + return lpfc_issue_reg_vfi(phba->pport);
> }
>
> /**
Thanks
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH linux-next] scsi: lpfc: Remove unneeded result variable
2022-08-24 7:51 [PATCH linux-next] scsi: lpfc: Remove unneeded result variable cgel.zte
2022-08-24 14:14 ` James Smart
@ 2022-09-01 4:39 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-09-01 4:39 UTC (permalink / raw)
To: cgel.zte
Cc: martin.petersen, james.smart, dick.kennedy, jejb, linux-scsi,
linux-kernel, ye xingchen, Zeal Robot
> Return the value from lpfc_issue_reg_vfi() directly instead of storing
> it in another redundant variable.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-01 4:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 7:51 [PATCH linux-next] scsi: lpfc: Remove unneeded result variable cgel.zte
2022-08-24 14:14 ` James Smart
2022-09-01 4:39 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).