* [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword
@ 2020-11-18 7:42 Zou Wei
2020-11-19 20:51 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-11-18 7:42 UTC (permalink / raw)
To: james.smart, dick.kennedy, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index c8b9434..a71df87 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -3336,7 +3336,7 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
*
* This function is called with hbalock held.
**/
-void
+static void
lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
{
union lpfc_wqe128 *wqe = &pwqeq->wqe;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword
2020-11-18 7:42 [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword Zou Wei
@ 2020-11-19 20:51 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2020-11-19 20:51 UTC (permalink / raw)
To: Zou Wei, dick.kennedy, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On 11/17/2020 11:42 PM, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: symbol 'lpfc_nvmet_prep_abort_wqe' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index c8b9434..a71df87 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3336,7 +3336,7 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
> *
> * This function is called with hbalock held.
> **/
> -void
> +static void
> lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
> {
> union lpfc_wqe128 *wqe = &pwqeq->wqe;
Zou, Thank You . I just submitted the same patch. Either one Martin
wants to take.. :)
-- james
Reviewed-by: James Smart <james.smart@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4163 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-19 20:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 7:42 [PATCH -next] scsi: lpfc: Mark lpfc_nvmet_prep_abort_wqe with static keyword Zou Wei
2020-11-19 20:51 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).