linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/9] use GFP_KERNEL
@ 2022-02-10 20:42 Julia Lawall
  2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Julia Lawall @ 2022-02-10 20:42 UTC (permalink / raw)
  To: linux-scsi
  Cc: kernel-janitors, MPT-FusionLinux.pdl, linux-crypto, linux-media,
	linux-kernel, netdev, alsa-devel, Sergey Shtylyov, linux-ide,
	linux-mtd

Platform_driver and pci_driver probe functions aren't called with
locks held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.

All changes have been compile-tested.

---

 drivers/ata/pata_mpc52xx.c               |    2 +-
 drivers/crypto/ux500/cryp/cryp_core.c    |    2 +-
 drivers/crypto/ux500/hash/hash_core.c    |    2 +-
 drivers/media/pci/cx18/cx18-driver.c     |    2 +-
 drivers/media/platform/fsl-viu.c         |    2 +-
 drivers/message/fusion/mptspi.c          |    2 +-
 drivers/mfd/sta2x11-mfd.c                |    2 +-
 drivers/mtd/devices/spear_smi.c          |    2 +-
 drivers/net/ethernet/moxa/moxart_ether.c |    4 ++--
 sound/soc/intel/boards/bytcr_wm5102.c    |    2 +-
 10 files changed, 11 insertions(+), 11 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 8/9] [SCSI] mptfusion: use GFP_KERNEL
  2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
@ 2022-02-10 20:42 ` Julia Lawall
  2022-02-11 22:10   ` Martin K. Petersen
  2022-02-12  0:20 ` [PATCH 0/9] " patchwork-bot+netdevbpf
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2022-02-10 20:42 UTC (permalink / raw)
  To: Sathya Prakash
  Cc: kernel-janitors, Sreekanth Reddy, Suganath Prabu Subramani,
	MPT-FusionLinux.pdl, linux-scsi, linux-kernel

Pci_driver probe functions aren't called with locks held
and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.

Problem found with Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/message/fusion/mptspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/message/fusion/mptspi.c b/drivers/message/fusion/mptspi.c
index acd4805dcf83..388675cc1765 100644
--- a/drivers/message/fusion/mptspi.c
+++ b/drivers/message/fusion/mptspi.c
@@ -1493,7 +1493,7 @@ mptspi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	/* SCSI needs scsi_cmnd lookup table!
 	 * (with size equal to req_depth*PtrSz!)
 	 */
-	ioc->ScsiLookup = kcalloc(ioc->req_depth, sizeof(void *), GFP_ATOMIC);
+	ioc->ScsiLookup = kcalloc(ioc->req_depth, sizeof(void *), GFP_KERNEL);
 	if (!ioc->ScsiLookup) {
 		error = -ENOMEM;
 		goto out_mptspi_probe;


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 8/9] [SCSI] mptfusion: use GFP_KERNEL
  2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
@ 2022-02-11 22:10   ` Martin K. Petersen
  0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-02-11 22:10 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Sathya Prakash, kernel-janitors, Sreekanth Reddy,
	Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi,
	linux-kernel


Julia,

> Pci_driver probe functions aren't called with locks held and thus
> don't need GFP_ATOMIC. Use GFP_KERNEL instead.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/9] use GFP_KERNEL
  2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
  2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
@ 2022-02-12  0:20 ` patchwork-bot+netdevbpf
  2022-02-14 12:54 ` (subset) " Mark Brown
  2022-02-15  3:19 ` Martin K. Petersen
  3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-12  0:20 UTC (permalink / raw)
  To: Julia Lawall
  Cc: linux-scsi, kernel-janitors, MPT-FusionLinux.pdl, linux-crypto,
	linux-media, linux-kernel, netdev, alsa-devel, s.shtylyov,
	linux-ide, linux-mtd

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 10 Feb 2022 21:42:14 +0100 you wrote:
> Platform_driver and pci_driver probe functions aren't called with
> locks held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
> 
> All changes have been compile-tested.
> 
> ---
> 
> [...]

Here is the summary with links:
  - [1/9] net: moxa: use GFP_KERNEL
    https://git.kernel.org/netdev/net-next/c/c9ac080b25d9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH 0/9] use GFP_KERNEL
  2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
  2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
  2022-02-12  0:20 ` [PATCH 0/9] " patchwork-bot+netdevbpf
@ 2022-02-14 12:54 ` Mark Brown
  2022-02-15  3:19 ` Martin K. Petersen
  3 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2022-02-14 12:54 UTC (permalink / raw)
  To: Julia Lawall, linux-scsi
  Cc: linux-mtd, MPT-FusionLinux.pdl, linux-kernel, linux-ide,
	Sergey Shtylyov, linux-crypto, kernel-janitors, netdev,
	linux-media, alsa-devel

On Thu, 10 Feb 2022 21:42:14 +0100, Julia Lawall wrote:
> Platform_driver and pci_driver probe functions aren't called with
> locks held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
> 
> All changes have been compile-tested.
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[3/9] ASoC: Intel: bytcr_wm5102: use GFP_KERNEL
      commit: 695c105933cfa04ccf84088342193ae43e37e0f5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/9] use GFP_KERNEL
  2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
                   ` (2 preceding siblings ...)
  2022-02-14 12:54 ` (subset) " Mark Brown
@ 2022-02-15  3:19 ` Martin K. Petersen
  3 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2022-02-15  3:19 UTC (permalink / raw)
  To: linux-scsi, Julia Lawall
  Cc: Martin K . Petersen, linux-mtd, alsa-devel, linux-crypto, netdev,
	Sergey Shtylyov, MPT-FusionLinux.pdl, kernel-janitors,
	linux-kernel, linux-media, linux-ide

On Thu, 10 Feb 2022 21:42:14 +0100, Julia Lawall wrote:

> Platform_driver and pci_driver probe functions aren't called with
> locks held and thus don't need GFP_ATOMIC. Use GFP_KERNEL instead.
> 
> All changes have been compile-tested.
> 

Applied to 5.18/scsi-queue, thanks!

[8/9] mptfusion: use GFP_KERNEL
      https://git.kernel.org/mkp/scsi/c/f69b0791df1d

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-15  3:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 20:42 [PATCH 0/9] use GFP_KERNEL Julia Lawall
2022-02-10 20:42 ` [PATCH 8/9] [SCSI] mptfusion: " Julia Lawall
2022-02-11 22:10   ` Martin K. Petersen
2022-02-12  0:20 ` [PATCH 0/9] " patchwork-bot+netdevbpf
2022-02-14 12:54 ` (subset) " Mark Brown
2022-02-15  3:19 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).