* [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
@ 2019-10-04 10:04 zhengbin
[not found] ` <CAGx+d6fcFnwN_zVshk6ua7o2a02V6L9ZZTXpggDj51Y3LGG50A@mail.gmail.com>
2019-10-10 2:33 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: zhengbin @ 2019-10-04 10:04 UTC (permalink / raw)
To: jsmart2021, james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi
Cc: zhengbin13
Fix sparse warnings:
drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
index 4e96d28..cc6b1b0 100644
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
@@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
* This routine is only called if we are SLI3, direct connect pt2pt
* mode and the remote NPort issues the PLOGI after link up.
*/
-void
+static void
lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
{
LPFC_MBOXQ_t *login_mbox;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
[not found] ` <CAGx+d6fcFnwN_zVshk6ua7o2a02V6L9ZZTXpggDj51Y3LGG50A@mail.gmail.com>
@ 2019-10-04 16:30 ` James Smart
0 siblings, 0 replies; 3+ messages in thread
From: James Smart @ 2019-10-04 16:30 UTC (permalink / raw)
To: Dick Kennedy, zhengbin
Cc: James Smart, James E.J. Bottomley, Martin K. Petersen,
Linux SCSI Mailinglist
On 10/4/2019 5:46 AM, Dick Kennedy wrote:
> Looks Good.
> ACK
>
> On Fri, Oct 4, 2019 at 5:58 AM zhengbin <zhengbin13@huawei.com
> <mailto:zhengbin13@huawei.com>> wrote:
>
> Fix sparse warnings:
>
> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol
> 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com <mailto:hulkci@huawei.com>>
> Signed-off-by: zhengbin <zhengbin13@huawei.com
> <mailto:zhengbin13@huawei.com>>
> ---
> drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dick Kennedy <dick.kennedy@broadcom.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Thanks!
-- james
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
2019-10-04 10:04 [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static zhengbin
[not found] ` <CAGx+d6fcFnwN_zVshk6ua7o2a02V6L9ZZTXpggDj51Y3LGG50A@mail.gmail.com>
@ 2019-10-10 2:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-10-10 2:33 UTC (permalink / raw)
To: zhengbin
Cc: jsmart2021, james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi
zhengbin,
> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-10 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 10:04 [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static zhengbin
[not found] ` <CAGx+d6fcFnwN_zVshk6ua7o2a02V6L9ZZTXpggDj51Y3LGG50A@mail.gmail.com>
2019-10-04 16:30 ` James Smart
2019-10-10 2:33 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).