* Re: [PATCH] megaraid_sas: change sdev queue depth max vs optimal
[not found] <20190726073214.23820-1-chandrakanth.patil@broadcom.com>
@ 2019-08-08 1:26 ` Martin K. Petersen
2019-08-08 17:26 ` Chandrakanth Patil
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2019-08-08 1:26 UTC (permalink / raw)
To: Chandrakanth Patil
Cc: linux-scsi, kashyap.desai, sumit.saxena, kiran-kumar.kasturi,
sankar.patra, sasikumar.pc, shivasharan.srikanteshwara,
anand.lodnoor
Chandrakanth,
> This patch provides the module parameter and sysfs interface to switch
> between the firmware provided (optimal) queue depth and controller
> queue depth (can_queue).
This smells a bit like a don't-be-broken flag.
Why isn't the firmware-provided value optimal?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] megaraid_sas: change sdev queue depth max vs optimal
2019-08-08 1:26 ` [PATCH] megaraid_sas: change sdev queue depth max vs optimal Martin K. Petersen
@ 2019-08-08 17:26 ` Chandrakanth Patil
2019-08-13 1:52 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Chandrakanth Patil @ 2019-08-08 17:26 UTC (permalink / raw)
To: Martin K. Petersen
Cc: linux-scsi, Kashyap Desai, Sumit Saxena, Kiran Kumar Kasturi,
Sankar Patra, Sasikumar PC, Shivasharan Srikanteshwara,
Anand Lodnoor
Martin,
The firmware provided queue depth provides optimum performance in most of
the cases/workloads. And this patch provides the option to the user to go
with max queue_depth or with optimum queue_depth.
-Chandrakanth
-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
Sent: Thursday, August 8, 2019 6:56 AM
To: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Cc: linux-scsi@vger.kernel.org; kashyap.desai@broadcom.com;
sumit.saxena@broadcom.com; kiran-kumar.kasturi@broadcom.com;
sankar.patra@broadcom.com; sasikumar.pc@broadcom.com;
shivasharan.srikanteshwara@broadcom.com; anand.lodnoor@broadcom.com
Subject: Re: [PATCH] megaraid_sas: change sdev queue depth max vs optimal
Chandrakanth,
> This patch provides the module parameter and sysfs interface to switch
> between the firmware provided (optimal) queue depth and controller
> queue depth (can_queue).
This smells a bit like a don't-be-broken flag.
Why isn't the firmware-provided value optimal?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] megaraid_sas: change sdev queue depth max vs optimal
2019-08-08 17:26 ` Chandrakanth Patil
@ 2019-08-13 1:52 ` Martin K. Petersen
0 siblings, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-08-13 1:52 UTC (permalink / raw)
To: Chandrakanth Patil
Cc: Martin K. Petersen, linux-scsi, Kashyap Desai, Sumit Saxena,
Kiran Kumar Kasturi, Sankar Patra, Sasikumar PC,
Shivasharan Srikanteshwara, Anand Lodnoor
Chandrakanth,
> The firmware provided queue depth provides optimum performance in most
> of the cases/workloads. And this patch provides the option to the user
> to go with max queue_depth or with optimum queue_depth.
I guess I'm just objecting to the notion that something is being
described as "optimum" when it clearly isn't.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-13 1:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190726073214.23820-1-chandrakanth.patil@broadcom.com>
2019-08-08 1:26 ` [PATCH] megaraid_sas: change sdev queue depth max vs optimal Martin K. Petersen
2019-08-08 17:26 ` Chandrakanth Patil
2019-08-13 1:52 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).