* [PATCH 0/2] Remove unused declarations for scsi
@ 2022-09-13 2:37 Gaosheng Cui
2022-09-13 2:37 ` [PATCH 1/2] scsi: qla2xxx: remove unused declarations for qla2xxx Gaosheng Cui
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gaosheng Cui @ 2022-09-13 2:37 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
andrew.vasquez, James.Bottomley, giridhar.malavali,
James.Bottomley, James.Bottomley, quinn.tran, himanshu.madhani,
bart.vanassche, nab, cuigaosheng1
Cc: linux-scsi, target-devel
This series contains a few cleanup patches, to remove unused
declarations which have been removed. Thanks!
Gaosheng Cui (2):
scsi: qla2xxx: remove unused declarations for qla2xxx
scsi: target: remove unused se_tmr_req_cache declaration
drivers/scsi/qla2xxx/qla_gbl.h | 12 ------------
drivers/scsi/qla2xxx/qla_target.h | 2 --
drivers/target/target_core_internal.h | 2 --
3 files changed, 16 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] scsi: qla2xxx: remove unused declarations for qla2xxx
2022-09-13 2:37 [PATCH 0/2] Remove unused declarations for scsi Gaosheng Cui
@ 2022-09-13 2:37 ` Gaosheng Cui
2022-09-13 2:37 ` [PATCH 2/2] scsi: target: remove unused se_tmr_req_cache declaration Gaosheng Cui
2022-09-16 1:48 ` [PATCH 0/2] Remove unused declarations for scsi Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Gaosheng Cui @ 2022-09-13 2:37 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
andrew.vasquez, James.Bottomley, giridhar.malavali,
James.Bottomley, James.Bottomley, quinn.tran, himanshu.madhani,
bart.vanassche, nab, cuigaosheng1
Cc: linux-scsi, target-devel
qla2x00_get_fw_version_str() has been removed since
commit abbd8870b9cb ("[SCSI] qla2xxx: Factor-out ISP specific
functions to method-based call tables.").
qla2x00_release_nvram_protection() has been removed since
commit 459c537807bd ("[SCSI] qla2xxx: Add ISP24xx
flash-manipulation routines.").
qla82xx_rdmem() and qla82xx_wrmem() have been removed since
commit 3711333dfbee ("[SCSI] qla2xxx: Updates for ISP82xx.").
qla25xx_rd_req_reg(), qla24xx_rd_req_reg(), qla25xx_wrt_rsp_reg(),
qla24xx_wrt_rsp_reg(), qla25xx_wrt_req_reg() and qla24xx_wrt_req_reg()
have been removed since commit 08029990b25b ("[SCSI] qla2xxx: Refactor
request/response-queue register handling.").
qla2x00_async_login_done() has been removed since
commit 726b85487067 ("qla2xxx: Add framework for async fabric discovery").
qlt_24xx_process_response_error() has been removed since
commit c5419e2618b9 ("scsi: qla2xxx: Combine Active command arrays.").
So remove the declarations for them from header file.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/scsi/qla2xxx/qla_gbl.h | 12 ------------
drivers/scsi/qla2xxx/qla_target.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h
index 2fc280e61306..e3256e721be1 100644
--- a/drivers/scsi/qla2xxx/qla_gbl.h
+++ b/drivers/scsi/qla2xxx/qla_gbl.h
@@ -70,8 +70,6 @@ extern int qla2x00_async_prlo(struct scsi_qla_host *, fc_port_t *);
extern int qla2x00_async_adisc(struct scsi_qla_host *, fc_port_t *,
uint16_t *);
extern int qla2x00_async_tm_cmd(fc_port_t *, uint32_t, uint32_t, uint32_t);
-extern void qla2x00_async_login_done(struct scsi_qla_host *, fc_port_t *,
- uint16_t *);
struct qla_work_evt *qla2x00_alloc_work(struct scsi_qla_host *,
enum qla_work_type);
extern int qla24xx_async_gnl(struct scsi_qla_host *, fc_port_t *);
@@ -278,7 +276,6 @@ extern int qla24xx_vport_create_req_sanity_check(struct fc_vport *);
extern scsi_qla_host_t *qla24xx_create_vhost(struct fc_vport *);
extern void qla2x00_sp_free_dma(srb_t *sp);
-extern char *qla2x00_get_fw_version_str(struct scsi_qla_host *, char *);
extern void qla2x00_mark_device_lost(scsi_qla_host_t *, fc_port_t *, int);
extern void qla2x00_mark_all_devices_lost(scsi_qla_host_t *);
@@ -615,7 +612,6 @@ void __qla_consume_iocb(struct scsi_qla_host *vha, void **pkt, struct rsp_que **
/*
* Global Function Prototypes in qla_sup.c source file.
*/
-extern void qla2x00_release_nvram_protection(scsi_qla_host_t *);
extern int qla24xx_read_flash_data(scsi_qla_host_t *, uint32_t *,
uint32_t, uint32_t);
extern uint8_t *qla2x00_read_nvram_data(scsi_qla_host_t *, void *, uint32_t,
@@ -787,12 +783,6 @@ extern void qla2x00_init_response_q_entries(struct rsp_que *);
extern int qla25xx_delete_req_que(struct scsi_qla_host *, struct req_que *);
extern int qla25xx_delete_rsp_que(struct scsi_qla_host *, struct rsp_que *);
extern int qla25xx_delete_queues(struct scsi_qla_host *);
-extern uint16_t qla24xx_rd_req_reg(struct qla_hw_data *, uint16_t);
-extern uint16_t qla25xx_rd_req_reg(struct qla_hw_data *, uint16_t);
-extern void qla24xx_wrt_req_reg(struct qla_hw_data *, uint16_t, uint16_t);
-extern void qla25xx_wrt_req_reg(struct qla_hw_data *, uint16_t, uint16_t);
-extern void qla25xx_wrt_rsp_reg(struct qla_hw_data *, uint16_t, uint16_t);
-extern void qla24xx_wrt_rsp_reg(struct qla_hw_data *, uint16_t, uint16_t);
/* qlafx00 related functions */
extern int qlafx00_pci_config(struct scsi_qla_host *);
@@ -877,8 +867,6 @@ extern void qla82xx_init_flags(struct qla_hw_data *);
extern void qla82xx_set_drv_active(scsi_qla_host_t *);
extern int qla82xx_wr_32(struct qla_hw_data *, ulong, u32);
extern int qla82xx_rd_32(struct qla_hw_data *, ulong);
-extern int qla82xx_rdmem(struct qla_hw_data *, u64, void *, int);
-extern int qla82xx_wrmem(struct qla_hw_data *, u64, void *, int);
/* ISP 8021 IDC */
extern void qla82xx_clear_drv_active(struct qla_hw_data *);
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index 080c46eb8245..7df86578214f 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -1075,8 +1075,6 @@ extern void qlt_81xx_config_nvram_stage2(struct scsi_qla_host *,
struct init_cb_81xx *);
extern void qlt_81xx_config_nvram_stage1(struct scsi_qla_host *,
struct nvram_81xx *);
-extern int qlt_24xx_process_response_error(struct scsi_qla_host *,
- struct sts_entry_24xx *);
extern void qlt_modify_vp_config(struct scsi_qla_host *,
struct vp_config_entry_24xx *);
extern void qlt_probe_one_stage1(struct scsi_qla_host *, struct qla_hw_data *);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] scsi: target: remove unused se_tmr_req_cache declaration
2022-09-13 2:37 [PATCH 0/2] Remove unused declarations for scsi Gaosheng Cui
2022-09-13 2:37 ` [PATCH 1/2] scsi: qla2xxx: remove unused declarations for qla2xxx Gaosheng Cui
@ 2022-09-13 2:37 ` Gaosheng Cui
2022-09-16 1:48 ` [PATCH 0/2] Remove unused declarations for scsi Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Gaosheng Cui @ 2022-09-13 2:37 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
andrew.vasquez, James.Bottomley, giridhar.malavali,
James.Bottomley, James.Bottomley, quinn.tran, himanshu.madhani,
bart.vanassche, nab, cuigaosheng1
Cc: linux-scsi, target-devel
se_tmr_req_cache has been removed since
commit c8e31f26feeb ("target: Add SCF_SCSI_TMR_CDB usage
and drop se_tmr_req_cache"), so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/target/target_core_internal.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/target/target_core_internal.h b/drivers/target/target_core_internal.h
index a889a6237d9c..30fcf69e1a1d 100644
--- a/drivers/target/target_core_internal.h
+++ b/drivers/target/target_core_internal.h
@@ -133,8 +133,6 @@ struct se_node_acl *core_tpg_add_initiator_node_acl(struct se_portal_group *tpg,
void core_tpg_del_initiator_node_acl(struct se_node_acl *acl);
/* target_core_transport.c */
-extern struct kmem_cache *se_tmr_req_cache;
-
int init_se_kmem_caches(void);
void release_se_kmem_caches(void);
u32 scsi_get_new_index(scsi_index_t);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] Remove unused declarations for scsi
2022-09-13 2:37 [PATCH 0/2] Remove unused declarations for scsi Gaosheng Cui
2022-09-13 2:37 ` [PATCH 1/2] scsi: qla2xxx: remove unused declarations for qla2xxx Gaosheng Cui
2022-09-13 2:37 ` [PATCH 2/2] scsi: target: remove unused se_tmr_req_cache declaration Gaosheng Cui
@ 2022-09-16 1:48 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-09-16 1:48 UTC (permalink / raw)
To: Gaosheng Cui
Cc: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
andrew.vasquez, James.Bottomley, giridhar.malavali,
James.Bottomley, James.Bottomley, quinn.tran, himanshu.madhani,
bart.vanassche, nab, linux-scsi, target-devel
Gaosheng,
> This series contains a few cleanup patches, to remove unused
> declarations which have been removed. Thanks!
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-16 1:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 2:37 [PATCH 0/2] Remove unused declarations for scsi Gaosheng Cui
2022-09-13 2:37 ` [PATCH 1/2] scsi: qla2xxx: remove unused declarations for qla2xxx Gaosheng Cui
2022-09-13 2:37 ` [PATCH 2/2] scsi: target: remove unused se_tmr_req_cache declaration Gaosheng Cui
2022-09-16 1:48 ` [PATCH 0/2] Remove unused declarations for scsi Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).