* [PATCH] scsi: csiostor: Adjust indentation in csio_device_reset
@ 2019-12-18 1:47 Nathan Chancellor
2019-12-19 23:53 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2019-12-18 1:47 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, clang-built-linux, Nathan Chancellor
Clang warns:
../drivers/scsi/csiostor/csio_scsi.c:1386:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
csio_lnodes_exit(hw, 1);
^
../drivers/scsi/csiostor/csio_scsi.c:1382:2: note: previous statement is
here
if (*buf != '1')
^
1 warning generated.
This warning occurs because there is a space after the tab on this line.
Remove it so that the indentation is consistent with the Linux kernel
coding style and clang no longer warns.
Fixes: a3667aaed569 ("[SCSI] csiostor: Chelsio FCoE offload driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/818
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/scsi/csiostor/csio_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 469d0bc9f5fe..00cf33573136 100644
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -1383,7 +1383,7 @@ csio_device_reset(struct device *dev,
return -EINVAL;
/* Delete NPIV lnodes */
- csio_lnodes_exit(hw, 1);
+ csio_lnodes_exit(hw, 1);
/* Block upper IOs */
csio_lnodes_block_request(hw);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: csiostor: Adjust indentation in csio_device_reset
2019-12-18 1:47 [PATCH] scsi: csiostor: Adjust indentation in csio_device_reset Nathan Chancellor
@ 2019-12-19 23:53 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-12-19 23:53 UTC (permalink / raw)
To: Nathan Chancellor
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, clang-built-linux
Nathan,
> Clang warns:
>
> ../drivers/scsi/csiostor/csio_scsi.c:1386:3: warning: misleading
> indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
> csio_lnodes_exit(hw, 1);
> ^
> ../drivers/scsi/csiostor/csio_scsi.c:1382:2: note: previous statement is
Applied to 5.6/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 1:47 [PATCH] scsi: csiostor: Adjust indentation in csio_device_reset Nathan Chancellor
2019-12-19 23:53 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).