linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()'
@ 2021-12-09 21:11 Christophe JAILLET
  2021-12-14  4:34 ` Martin K. Petersen
  2021-12-17  4:04 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-12-09 21:11 UTC (permalink / raw)
  To: don.brace, jejb, martin.petersen
  Cc: storagedev, linux-scsi, linux-kernel, kernel-janitors,
	Christophe JAILLET

'lunzerobits' is unused. Remove it.

This a left over of commit 2d62a33e05d4("hpsa: eliminate fake lun0
enclosures")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/scsi/hpsa.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index cdf3328cc065..a47bcce3c9c7 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -4354,7 +4354,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)
 	int i, ndevs_to_allocate;
 	int raid_ctlr_position;
 	bool physical_device;
-	DECLARE_BITMAP(lunzerobits, MAX_EXT_TARGETS);
 
 	currentsd = kcalloc(HPSA_MAX_DEVICES, sizeof(*currentsd), GFP_KERNEL);
 	physdev_list = kzalloc(sizeof(*physdev_list), GFP_KERNEL);
@@ -4368,7 +4367,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)
 		dev_err(&h->pdev->dev, "out of memory\n");
 		goto out;
 	}
-	memset(lunzerobits, 0, sizeof(lunzerobits));
 
 	h->drv_req_rescan = 0; /* cancel scheduled rescan - we're doing it. */
 
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()'
  2021-12-09 21:11 [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()' Christophe JAILLET
@ 2021-12-14  4:34 ` Martin K. Petersen
  2021-12-17  4:04 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-12-14  4:34 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: don.brace, jejb, martin.petersen, storagedev, linux-scsi,
	linux-kernel, kernel-janitors


Christophe,

> 'lunzerobits' is unused. Remove it.

Applied to 5.17/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()'
  2021-12-09 21:11 [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()' Christophe JAILLET
  2021-12-14  4:34 ` Martin K. Petersen
@ 2021-12-17  4:04 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-12-17  4:04 UTC (permalink / raw)
  To: don.brace, jejb, Christophe JAILLET
  Cc: Martin K . Petersen, linux-scsi, kernel-janitors, storagedev,
	linux-kernel

On Thu, 9 Dec 2021 22:11:56 +0100, Christophe JAILLET wrote:

> 'lunzerobits' is unused. Remove it.
> 
> This a left over of commit 2d62a33e05d4("hpsa: eliminate fake lun0
> enclosures")
> 
> 

Applied to 5.17/scsi-queue, thanks!

[1/1] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()'
      https://git.kernel.org/mkp/scsi/c/8c2d04551545

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-17  4:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 21:11 [PATCH] scsi: hpsa: Remove an unused variable in 'hpsa_update_scsi_devices()' Christophe JAILLET
2021-12-14  4:34 ` Martin K. Petersen
2021-12-17  4:04 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).