linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 0/3] net: make udp tunnel devices support fraglist
@ 2021-01-15  9:47 Xin Long
  2021-01-15  9:47 ` [PATCH net-next 1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features Xin Long
  2021-01-19  4:30 ` [PATCH net-next 0/3] net: make udp tunnel devices support fraglist patchwork-bot+netdevbpf
  0 siblings, 2 replies; 5+ messages in thread
From: Xin Long @ 2021-01-15  9:47 UTC (permalink / raw)
  To: network dev, linux-sctp
  Cc: Marcelo Ricardo Leitner, Neil Horman, davem, Jakub Kicinski,
	Martin Varghese, Alexander Duyck

Like GRE device, UDP tunnel devices should also support fraglist, so
that some protocol (like SCTP) HW GSO that requires NETIF_F_FRAGLIST
in the dev can work. Especially when the lower device support both
NETIF_F_GSO_UDP_TUNNEL and NETIF_F_GSO_SCTP.

Xin Long (3):
  vxlan: add NETIF_F_FRAGLIST flag for dev features
  geneve: add NETIF_F_FRAGLIST flag for dev features
  bareudp: add NETIF_F_FRAGLIST flag for dev features

 drivers/net/bareudp.c | 5 +++--
 drivers/net/geneve.c  | 5 +++--
 drivers/net/vxlan.c   | 5 +++--
 3 files changed, 9 insertions(+), 6 deletions(-)

-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next 1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features
  2021-01-15  9:47 [PATCH net-next 0/3] net: make udp tunnel devices support fraglist Xin Long
@ 2021-01-15  9:47 ` Xin Long
  2021-01-15  9:47   ` [PATCH net-next 2/3] geneve: " Xin Long
  2021-01-19  4:30 ` [PATCH net-next 0/3] net: make udp tunnel devices support fraglist patchwork-bot+netdevbpf
  1 sibling, 1 reply; 5+ messages in thread
From: Xin Long @ 2021-01-15  9:47 UTC (permalink / raw)
  To: network dev, linux-sctp
  Cc: Marcelo Ricardo Leitner, Neil Horman, davem, Jakub Kicinski,
	Martin Varghese, Alexander Duyck

Some protocol HW GSO requires fraglist supported by the device, like
SCTP. Without NETIF_F_FRAGLIST set in the dev features of vxlan, it
would have to do SW GSO before the packets enter the driver, even
when the vxlan dev and lower dev (like veth) both have the feature
of NETIF_F_GSO_SCTP.

So this patch is to add it for vxlan.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 drivers/net/vxlan.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index b936443..3929e43 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -3283,12 +3283,13 @@ static void vxlan_setup(struct net_device *dev)
 	SET_NETDEV_DEVTYPE(dev, &vxlan_type);
 
 	dev->features	|= NETIF_F_LLTX;
-	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
+	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
 	dev->features   |= NETIF_F_RXCSUM;
 	dev->features   |= NETIF_F_GSO_SOFTWARE;
 
 	dev->vlan_features = dev->features;
-	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
+	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
+	dev->hw_features |= NETIF_F_RXCSUM;
 	dev->hw_features |= NETIF_F_GSO_SOFTWARE;
 	netif_keep_dst(dev);
 	dev->priv_flags |= IFF_NO_QUEUE;
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next 2/3] geneve: add NETIF_F_FRAGLIST flag for dev features
  2021-01-15  9:47 ` [PATCH net-next 1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features Xin Long
@ 2021-01-15  9:47   ` Xin Long
  2021-01-15  9:47     ` [PATCH net-next 3/3] bareudp: " Xin Long
  0 siblings, 1 reply; 5+ messages in thread
From: Xin Long @ 2021-01-15  9:47 UTC (permalink / raw)
  To: network dev, linux-sctp
  Cc: Marcelo Ricardo Leitner, Neil Horman, davem, Jakub Kicinski,
	Martin Varghese, Alexander Duyck

Some protocol HW GSO requires fraglist supported by the device, like
SCTP. Without NETIF_F_FRAGLIST set in the dev features of geneve, it
would have to do SW GSO before the packets enter the driver, even
when the geneve dev and lower dev (like veth) both have the feature
of NETIF_F_GSO_SCTP.

So this patch is to add it for geneve.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 drivers/net/geneve.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 6aa775d..4ac0373 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1197,11 +1197,12 @@ static void geneve_setup(struct net_device *dev)
 	SET_NETDEV_DEVTYPE(dev, &geneve_type);
 
 	dev->features    |= NETIF_F_LLTX;
-	dev->features    |= NETIF_F_SG | NETIF_F_HW_CSUM;
+	dev->features    |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
 	dev->features    |= NETIF_F_RXCSUM;
 	dev->features    |= NETIF_F_GSO_SOFTWARE;
 
-	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
+	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
+	dev->hw_features |= NETIF_F_RXCSUM;
 	dev->hw_features |= NETIF_F_GSO_SOFTWARE;
 
 	/* MTU range: 68 - (something less than 65535) */
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next 3/3] bareudp: add NETIF_F_FRAGLIST flag for dev features
  2021-01-15  9:47   ` [PATCH net-next 2/3] geneve: " Xin Long
@ 2021-01-15  9:47     ` Xin Long
  0 siblings, 0 replies; 5+ messages in thread
From: Xin Long @ 2021-01-15  9:47 UTC (permalink / raw)
  To: network dev, linux-sctp
  Cc: Marcelo Ricardo Leitner, Neil Horman, davem, Jakub Kicinski,
	Martin Varghese, Alexander Duyck

Like vxlan and geneve, bareudp also needs this dev feature
to support some protocol's HW GSO.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 drivers/net/bareudp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index 57dfaf4..7511bca 100644
--- a/drivers/net/bareudp.c
+++ b/drivers/net/bareudp.c
@@ -526,11 +526,12 @@ static void bareudp_setup(struct net_device *dev)
 	dev->netdev_ops = &bareudp_netdev_ops;
 	dev->needs_free_netdev = true;
 	SET_NETDEV_DEVTYPE(dev, &bareudp_type);
-	dev->features    |= NETIF_F_SG | NETIF_F_HW_CSUM;
+	dev->features    |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
 	dev->features    |= NETIF_F_RXCSUM;
 	dev->features    |= NETIF_F_LLTX;
 	dev->features    |= NETIF_F_GSO_SOFTWARE;
-	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_RXCSUM;
+	dev->hw_features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_FRAGLIST;
+	dev->hw_features |= NETIF_F_RXCSUM;
 	dev->hw_features |= NETIF_F_GSO_SOFTWARE;
 	dev->hard_header_len = 0;
 	dev->addr_len = 0;
-- 
2.1.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next 0/3] net: make udp tunnel devices support fraglist
  2021-01-15  9:47 [PATCH net-next 0/3] net: make udp tunnel devices support fraglist Xin Long
  2021-01-15  9:47 ` [PATCH net-next 1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features Xin Long
@ 2021-01-19  4:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-19  4:30 UTC (permalink / raw)
  To: Xin Long
  Cc: netdev, linux-sctp, marcelo.leitner, nhorman, davem, kuba,
	martin.varghese, alexander.duyck

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Fri, 15 Jan 2021 17:47:44 +0800 you wrote:
> Like GRE device, UDP tunnel devices should also support fraglist, so
> that some protocol (like SCTP) HW GSO that requires NETIF_F_FRAGLIST
> in the dev can work. Especially when the lower device support both
> NETIF_F_GSO_UDP_TUNNEL and NETIF_F_GSO_SCTP.
> 
> Xin Long (3):
>   vxlan: add NETIF_F_FRAGLIST flag for dev features
>   geneve: add NETIF_F_FRAGLIST flag for dev features
>   bareudp: add NETIF_F_FRAGLIST flag for dev features
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features
    https://git.kernel.org/netdev/net-next/c/cb2c57112432
  - [net-next,2/3] geneve: add NETIF_F_FRAGLIST flag for dev features
    https://git.kernel.org/netdev/net-next/c/18423e1a9d7d
  - [net-next,3/3] bareudp: add NETIF_F_FRAGLIST flag for dev features
    https://git.kernel.org/netdev/net-next/c/3224dcfd850f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-19  4:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15  9:47 [PATCH net-next 0/3] net: make udp tunnel devices support fraglist Xin Long
2021-01-15  9:47 ` [PATCH net-next 1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features Xin Long
2021-01-15  9:47   ` [PATCH net-next 2/3] geneve: " Xin Long
2021-01-15  9:47     ` [PATCH net-next 3/3] bareudp: " Xin Long
2021-01-19  4:30 ` [PATCH net-next 0/3] net: make udp tunnel devices support fraglist patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).