From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: linux-sctp@vger.kernel.org
Subject: Re: [PATCH lksctp-tools] Use symvmer attribute, not asms for symbol versioning
Date: Sat, 03 Oct 2020 18:07:31 +0000 [thread overview]
Message-ID: <20201003180731.GJ70998@localhost.localdomain> (raw)
On Fri, Sep 18, 2020 at 08:48:30PM +0200, Petr Lautrbach wrote:
> This project could not be built with LTO as it uses ASMs to implement
> symbol versioning. ASMs like this are fundamentally incompatible with
> LTO because GCC does not look inside the ASM string to find symbol
> references. Starting with gcc-10 there is a new symbol attribute for
> implementing symbol versioning.
>
> A fallback to the old way of implementing symbol versioning via asms is
> included, so it should work with clang as well as gcc-9 and
> earlier.
>
> Fixes: https://github.com/sctp/lksctp-tools/issues/35
>
> Author: Jeff Law <law@redhat.com>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Petr Lautrbach <plautrba@redhat.com>
Cc: linux-sctp@vger.kernel.org
Subject: Re: [PATCH lksctp-tools] Use symvmer attribute, not asms for symbol versioning
Date: Sat, 3 Oct 2020 15:07:31 -0300 [thread overview]
Message-ID: <20201003180731.GJ70998@localhost.localdomain> (raw)
Message-ID: <20201003180731.yNpgXLj_r07zajag1UkKeZZDg3CAFwPvCVkIuX2Ez3Q@z> (raw)
In-Reply-To: <20200918184830.469979-1-plautrba@redhat.com>
On Fri, Sep 18, 2020 at 08:48:30PM +0200, Petr Lautrbach wrote:
> This project could not be built with LTO as it uses ASMs to implement
> symbol versioning. ASMs like this are fundamentally incompatible with
> LTO because GCC does not look inside the ASM string to find symbol
> references. Starting with gcc-10 there is a new symbol attribute for
> implementing symbol versioning.
>
> A fallback to the old way of implementing symbol versioning via asms is
> included, so it should work with clang as well as gcc-9 and
> earlier.
>
> Fixes: https://github.com/sctp/lksctp-tools/issues/35
>
> Author: Jeff Law <law@redhat.com>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Applied, thanks.
next prev reply other threads:[~2020-10-03 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 18:48 [PATCH lksctp-tools] Use symvmer attribute, not asms for symbol versioning Petr Lautrbach
2020-10-03 18:07 ` Marcelo Ricardo Leitner [this message]
2020-10-03 18:07 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003180731.GJ70998@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).