From: Wei Yongjun <weiyongjun1@huawei.com>
To: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Kees Cook <keescook@chromium.org>,
Micah Morton <mortonm@chromium.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<linux-security-module@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] LSM: fix return value check in safesetid_init_securityfs()
Date: Tue, 12 Feb 2019 07:58:31 +0000 [thread overview]
Message-ID: <20190212075831.114668-1-weiyongjun1@huawei.com> (raw)
In case of error, the function securityfs_create_dir() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: aeca4e2ca65c ("LSM: add SafeSetID module that gates setid calls")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
security/safesetid/securityfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/safesetid/securityfs.c b/security/safesetid/securityfs.c
index 61be4ee459cc..2c6c829be044 100644
--- a/security/safesetid/securityfs.c
+++ b/security/safesetid/securityfs.c
@@ -167,7 +167,7 @@ static int __init safesetid_init_securityfs(void)
return 0;
safesetid_policy_dir = securityfs_create_dir("safesetid", NULL);
- if (!safesetid_policy_dir) {
+ if (IS_ERR(safesetid_policy_dir)) {
ret = PTR_ERR(safesetid_policy_dir);
goto error;
}
next reply other threads:[~2019-02-12 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 7:58 Wei Yongjun [this message]
2019-02-12 16:55 ` [PATCH -next] LSM: fix return value check in safesetid_init_securityfs() Kees Cook
2019-02-12 19:01 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212075831.114668-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).